From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Ye Bin <yebin10@huawei.com>
Cc: Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH 1/3] scsi: qla2xxx: Fix inconsistent of format with argument type in tcm_qla2xxx.c
Date: Thu, 1 Oct 2020 11:47:16 -0500 [thread overview]
Message-ID: <16EE7295-38DA-448B-A72F-7B50139D72D2@oracle.com> (raw)
In-Reply-To: <20200930022515.2862532-2-yebin10@huawei.com>
> On Sep 29, 2020, at 9:25 PM, Ye Bin <yebin10@huawei.com> wrote:
>
> Fix follow warnings:
> [drivers/scsi/qla2xxx/tcm_qla2xxx.c:884]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> [drivers/scsi/qla2xxx/tcm_qla2xxx.c:885]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> [drivers/scsi/qla2xxx/tcm_qla2xxx.c:886]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> [drivers/scsi/qla2xxx/tcm_qla2xxx.c:887]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> [drivers/scsi/qla2xxx/tcm_qla2xxx.c:888]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> index 44bfe162654a..61017acd3458 100644
> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> @@ -850,7 +850,7 @@ static ssize_t tcm_qla2xxx_tpg_attrib_##name##_show( \
> struct tcm_qla2xxx_tpg *tpg = container_of(se_tpg, \
> struct tcm_qla2xxx_tpg, se_tpg); \
> \
> - return sprintf(page, "%u\n", tpg->tpg_attrib.name); \
> + return sprintf(page, "%d\n", tpg->tpg_attrib.name); \
> } \
> \
> static ssize_t tcm_qla2xxx_tpg_attrib_##name##_store( \
> --
> 2.25.4
>
Looks good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-01 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 2:25 [PATCH 0/3] Fix inconsistent of format with argument type Ye Bin
2020-09-30 2:25 ` [PATCH 1/3] scsi: qla2xxx: Fix inconsistent of format with argument type in tcm_qla2xxx.c Ye Bin
2020-10-01 11:03 ` [EXT] " Nilesh Javali
2020-10-01 16:47 ` Himanshu Madhani [this message]
2020-09-30 2:25 ` [PATCH 2/3] scsi: qla2xxx: Fix inconsistent of format with argument type in qla_os.c Ye Bin
2020-10-01 11:04 ` Nilesh Javali
2020-10-01 16:46 ` Himanshu Madhani
2020-09-30 2:25 ` [PATCH 3/3] scsi: qla2xxx: Fix inconsistent of format with argument type in qla_dbg.c Ye Bin
2020-10-01 11:05 ` Nilesh Javali
2020-10-01 16:46 ` Himanshu Madhani
2020-10-02 23:03 ` [PATCH 0/3] Fix inconsistent of format with argument type Martin K. Petersen
2020-10-07 3:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16EE7295-38DA-448B-A72F-7B50139D72D2@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=hulkci@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.