From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7BE1CD31 for ; Sun, 17 Mar 2024 16:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692866; cv=none; b=iKCR/fFOk55Oy6jB/sLmOzQtSXbA5VtTrsGKmjvU9sM+ZZSaQ9/5kD/HRhr37qx5cnbeLV5+Q0nhhXjlJdrsjrdJvmf+md8qqWjvVGoCn9QtdrjYgYYd9tXsC5/dI2iN/8sopLwf39McfQE1EHbkS7P+w3N53KgyklIO6LraunU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710692866; c=relaxed/simple; bh=tptFNoMWAOOlzBO5sAOseuR3BJfkcQOLBcvNInTjS8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QCIR3Yv/s4y1/7TGVL1rtkW0aWHkamr2jkdKoq9YtnlAvEzNkz5bqM/RszTPItkabsr0LkSB0enZobMyjyD5OL68Zxl7coCz/EdL356QMPF2VdetBfqNcjhnq7ABvwTfhBJxr7ij9bOqqH+kPbsdRpCwlIWuJrzj5ParjxTz3CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UZd4qXwO; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UZd4qXwO" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a44e3176120so464755566b.1 for ; Sun, 17 Mar 2024 09:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710692863; x=1711297663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=UZd4qXwONuIWTsnjajOaXBo0Rcv9IiyRnaurSu9PGERooAthMayQyQC86w9M6jut98 ZCce1W7vm1iJMiCJDVnq8DJQozKZAilSgdUom2bwii7MLZD3fK9QCTZnJJuMOV5C+wQ8 S33CUWzCxU2UtKxUUAr8XTQJ18hPdEZowPSMd8cR9blFk01dcSxDYlN/gvSaApL35Xvk Vf137xjD6R+jQV20sZgMulcAmskBk+J6gSpm68XKR65xSzpMbxifkCAIFUC4MBSaIHnS ZI4gavcvFomjs6wZLeidRglQCRJgL/yJYI/uMG57uO3yZvI0jHhCGDeqDV9KwAnYzF8c KYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710692863; x=1711297663; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=Se9SATfabEMYMO5RyPe6hKskWXNFd7U3y80mzTGK8+csjZ2GVtOZXv14QkGyd1KDOi RXYoKxn8Y8YVZEFRjB2UzHs4l8bHDhPwllavLYXbEml2b4XLPRyfOSKzIxlKkYE1KvYR fCkL4qL/V/P3p9cR4H1M17XVZSzjmLFhLx8F7IuOsKz3oA8dhxQ+xkYx6E0p3u8FJjSU cg6VcYxbWbjb1TFPG4uIF2Q1wbfm/YrJXju6xunLVKYneiIFRWPVGJbBl11WRC/2odqy ocsjHvTsicdb2VaWJscaaRykwoIGcyWfkrGwATJ4iYsHMFDRLbYYrEvcO4wAgy8uuogZ iepg== X-Forwarded-Encrypted: i=1; AJvYcCXVpPvVlEnUVj9bjQ+7GhZSgRjKwSJohYY7ATpvlJUQ3Ax+Y168pFA1kvHeUc0cOnArLGuzJnH4cwgXBHw4GTp/Ko3VdVphbksSXg== X-Gm-Message-State: AOJu0YyIAclY9yhTFyY7Y/HS/FId1S+rcFqtK8BmbNAKS0oJolZm9VJs d9scG6raJv1BKbky0DX0CjIduPFywFSgdHEY+5kxfWM/zFHFVMfu2hjlC+plvGU= X-Google-Smtp-Source: AGHT+IFUx3DiGw5K8wzzgyv5/heiiNtklq9IaWGxscuOA2ycZY2UvKzdHUAqMl6UtjtfDCPC1JocDw== X-Received: by 2002:a17:906:4a04:b0:a46:c022:4d2d with SMTP id w4-20020a1709064a0400b00a46c0224d2dmr140019eju.54.1710692863067; Sun, 17 Mar 2024 09:27:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id hy10-20020a1709068a6a00b00a45fcda4782sm3886952ejc.56.2024.03.17.09.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Mar 2024 09:27:42 -0700 (PDT) Message-ID: <16a22924-054d-4d50-9f32-cc07c0bbbdf4@linaro.org> Date: Sun, 17 Mar 2024 17:27:40 +0100 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/25] ASoC: dt-bindings: meson: axg-pdm: document 'sysrate' property Content-Language: en-US To: Jan Dakinevich , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org Cc: kernel@salutedevices.com References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-14-jan.dakinevich@salutedevices.com> <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/03/2024 16:55, Jan Dakinevich wrote: > > > On 3/15/24 13:00, Krzysztof Kozlowski wrote: >> On 15/03/2024 00:21, Jan Dakinevich wrote: >>> This option allow to redefine the rate of DSP system clock. >> >> And why is it suitable for bindings? Describe the hardware, not what you >> want to do in the driver. >> > > What do you mean? I am adding some new property and should describe it > in dt-bindinds. Isn't it? No, if the property is not suitable for bindings, you should not add it in the first place. So again: explain what sort of hardware, not driver, problem you are solving here, so we can understand why do you need new property. Otherwise use existing properties or no properties, because we do not define all possible clocks in the bindings. Let's be clear: with such commit msg explanation as you have, my answer is: no, driver should set clock frequency and you do not need this property at all. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB0ADC54E60 for ; Sun, 17 Mar 2024 16:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hR0jC4ufyRuwu60apvOBWUpVxBl93wcXPirsyws9//k=; b=UEX6HkKjk82cSE Ixcqt9SahQeTOmTilDXSAZfZCj0eSAo/DQkr/BCEI+2wuzkW/Uu9RsSyJjM0/5cZIBinJpAp4DaED kG3mPZYe2CYbrYaYKv5yv334ngyuor2PCc4XjNQXAK7+FYRSajhlXFiddC5ZDwM026syfmhfuaxxG sA/TRSraWPZI0JrDsoXpzbXqdI6On3C3muLLG8S9mTjtJzilKgwu2xwTN+VLStSAntWVm3qq0O0TK sX71O2zpyRGjWV1Etsw/MkwVwXABQp1lBelNlfU1qpUjq/G6AjF8uLQI4UIwt/RcpkW9WVBaAzG2G pftwoSL6iZ5n7/XGbLqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rltMS-00000005jUh-49sH; Sun, 17 Mar 2024 16:27:49 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rltMP-00000005jS1-0CnR for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 16:27:47 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a46805cd977so324813066b.0 for ; Sun, 17 Mar 2024 09:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710692863; x=1711297663; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=m0rE6BxSPN/mWxR8z4absqNUuXVPBXEIPZ7gsU8Jsa8/KnM+DQedXpSq3SflSKqyyr QZQ4HGgs9QDnhkLy1+8bmXCTiMUv36gZLE/rwX1rBumAnN46rTR7kPwkPv5psNVK4/jD cAgoQSmH0K4jMf/pfXkHkrQrgKzyGj2Sr82bFMgS7T1PoMjlUr2sSjcRsVdRM9Yvy4yL KfyEurz29wl07Seygs6YntkNMaUztxX7u4/kvDtxK+Bxs4n4J1s+dShxZAjh/Qkm8Ood VrPMroh0nlQx89g6G6FxeywGn195UpF9q1IGAuJW5y0T2F0A49VTs5Lbb8wje6qMYdIe eZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710692863; x=1711297663; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=hvnm1p6H3osHm+Uk9yF8h5vCmi6nAUF/BZ79tjeTi84pt1eYu9Fa7zUY15S7+QQ1P1 1ovxYgE7WZPubEUgNCqfW8oEpTZyYTg1uEdwYhLbZqfm9+U4p8LEtZzNcibd4z9wL5yx HyE7+YG6VQA1Gt1By267TT2qf+jApA5F2vCvoXIa5A7yNjJo09jc4tOxSmSBw1qm1Sv0 i2KHXxL7OdcAGxtT12STwO/A7Pvjo7ZizMDQ8fbVnkFtuppfhaI8RicGLUXEu9marPFh WJRH8hrDNvALQMebZgbuMJfi8/CRlIMrf8RnPWapt0xC+rXJSmYpPEzc4EotQSHtK/8E b6KQ== X-Forwarded-Encrypted: i=1; AJvYcCW93riWpmfzMFf649QbtdLuDahiEybGGIGhPKb7cINSIbvGiUR45uqYXH8Y3Ibi3wxDTyozu7V2KKDYr+ovOoPAzKQ5P5D8oDEDm8/2+ha/cnZnkSg= X-Gm-Message-State: AOJu0YwEJpmwhJYzNMJdZoo5/vWPYKo/fgfPLGNIhQj5f5YnjLYdir4/ AHwueVSNHRFDtSykojItbKCia4g1yfVqW3AS511J58A02g5RHCPeG26/AVTvzCg= X-Google-Smtp-Source: AGHT+IFUx3DiGw5K8wzzgyv5/heiiNtklq9IaWGxscuOA2ycZY2UvKzdHUAqMl6UtjtfDCPC1JocDw== X-Received: by 2002:a17:906:4a04:b0:a46:c022:4d2d with SMTP id w4-20020a1709064a0400b00a46c0224d2dmr140019eju.54.1710692863067; Sun, 17 Mar 2024 09:27:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id hy10-20020a1709068a6a00b00a45fcda4782sm3886952ejc.56.2024.03.17.09.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Mar 2024 09:27:42 -0700 (PDT) Message-ID: <16a22924-054d-4d50-9f32-cc07c0bbbdf4@linaro.org> Date: Sun, 17 Mar 2024 17:27:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/25] ASoC: dt-bindings: meson: axg-pdm: document 'sysrate' property Content-Language: en-US To: Jan Dakinevich , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org Cc: kernel@salutedevices.com References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-14-jan.dakinevich@salutedevices.com> <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_092745_400860_E8A0D56D X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/03/2024 16:55, Jan Dakinevich wrote: > > > On 3/15/24 13:00, Krzysztof Kozlowski wrote: >> On 15/03/2024 00:21, Jan Dakinevich wrote: >>> This option allow to redefine the rate of DSP system clock. >> >> And why is it suitable for bindings? Describe the hardware, not what you >> want to do in the driver. >> > > What do you mean? I am adding some new property and should describe it > in dt-bindinds. Isn't it? No, if the property is not suitable for bindings, you should not add it in the first place. So again: explain what sort of hardware, not driver, problem you are solving here, so we can understand why do you need new property. Otherwise use existing properties or no properties, because we do not define all possible clocks in the bindings. Let's be clear: with such commit msg explanation as you have, my answer is: no, driver should set clock frequency and you do not need this property at all. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81D79C54E67 for ; Sun, 17 Mar 2024 16:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5RSSwC7na79fcXDmADWAgvDmjjY6HkJzS67+dAexCSo=; b=UxMtn0b4lwSEaD Z1AuSY+qIHgHbGO3IhyvDWQXSXLOF5ynHvByOkxLwuK0DHEf1w5VTNAL4vOX1GSODYsNsjLLQx9IH 19Ifm1M5Rzw52L9E657a69jb1LXsv1peu1PXrT1KIUlZl/hNKNPaZ+2b/0CASlO6BhfxFkfdXnzmC P6/QaQERHQkXrIi2SPl6ioL/0VTO2r+AkcholVu3qv46532TflJM12I1uQ6bG6EVoXkiQCBzFjOI+ C4SuBFMDftQ4pmnVXiwnNcnd8d1TNgwadATE9K02uiSqDXDsC4STqWunjo1P3wJLuUxThn8ODYDnJ brc7+F0kI0ypvZgU3w5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rltMS-00000005jUC-1Mln; Sun, 17 Mar 2024 16:27:48 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rltMP-00000005jS2-0CAU for linux-amlogic@lists.infradead.org; Sun, 17 Mar 2024 16:27:47 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a4644bde1d4so470643166b.3 for ; Sun, 17 Mar 2024 09:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710692863; x=1711297663; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=m0rE6BxSPN/mWxR8z4absqNUuXVPBXEIPZ7gsU8Jsa8/KnM+DQedXpSq3SflSKqyyr QZQ4HGgs9QDnhkLy1+8bmXCTiMUv36gZLE/rwX1rBumAnN46rTR7kPwkPv5psNVK4/jD cAgoQSmH0K4jMf/pfXkHkrQrgKzyGj2Sr82bFMgS7T1PoMjlUr2sSjcRsVdRM9Yvy4yL KfyEurz29wl07Seygs6YntkNMaUztxX7u4/kvDtxK+Bxs4n4J1s+dShxZAjh/Qkm8Ood VrPMroh0nlQx89g6G6FxeywGn195UpF9q1IGAuJW5y0T2F0A49VTs5Lbb8wje6qMYdIe eZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710692863; x=1711297663; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1n2WFX+7suz3HRMA03UCKEjbkhnw9bIPtT5LjeIC65w=; b=beAREWM8u1U0PAVqJL7y0VlOoUWKLN4/9yCHMcma4BmiiAIYpc71VEeZ+wOyqExwNV AvXY9Dep582MkFFwocXrSoonIaPVuJbbIBVvijnUN++CKbYesuXLsSErQESklXBEficH M3O3pGoylM5AbYQX5S7KggSDh11gKR4jSdZG2Y+AEw3pICXlzTfDMaa83xHXh+m9gbeK k+SQ21P8YJP9fZ4ifgUFNj7ls4/Xs6C38eHjR4xDv/bVO95hynxAIp4VIGqALxY6wJiN QV8aRqcxbfUyvxi0yfunNS41errtEN3zPntvsf9Vu/1ACszP8n6YHu0BC8aRtHSGF1/2 iaNA== X-Forwarded-Encrypted: i=1; AJvYcCX3Ti8V9K9NERQsDdI5KcTkYCAr005ZBjOL3UP8G2A0jMTRIu7jq6g6pPsE7JEEwCE0P9rInBL47gcLLm4rZVgY9MVeT98DeeDU80neupl/Ne0= X-Gm-Message-State: AOJu0Yx1gOTPL/vVxOMYtSCWzZ7lDABR+agKjFc9XDxZ/BnnfqipokS6 iJ811nmbtgGBlqFo+XTaUjr8I/njeyTwbpLv0qtnFko40CQsp8up4AYAuzESCME= X-Google-Smtp-Source: AGHT+IFUx3DiGw5K8wzzgyv5/heiiNtklq9IaWGxscuOA2ycZY2UvKzdHUAqMl6UtjtfDCPC1JocDw== X-Received: by 2002:a17:906:4a04:b0:a46:c022:4d2d with SMTP id w4-20020a1709064a0400b00a46c0224d2dmr140019eju.54.1710692863067; Sun, 17 Mar 2024 09:27:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id hy10-20020a1709068a6a00b00a45fcda4782sm3886952ejc.56.2024.03.17.09.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Mar 2024 09:27:42 -0700 (PDT) Message-ID: <16a22924-054d-4d50-9f32-cc07c0bbbdf4@linaro.org> Date: Sun, 17 Mar 2024 17:27:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/25] ASoC: dt-bindings: meson: axg-pdm: document 'sysrate' property Content-Language: en-US To: Jan Dakinevich , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org Cc: kernel@salutedevices.com References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-14-jan.dakinevich@salutedevices.com> <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <827c4f17-043e-4e09-aea6-0fee22d1b234@salutedevices.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_092745_516414_52879BDA X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 17/03/2024 16:55, Jan Dakinevich wrote: > > > On 3/15/24 13:00, Krzysztof Kozlowski wrote: >> On 15/03/2024 00:21, Jan Dakinevich wrote: >>> This option allow to redefine the rate of DSP system clock. >> >> And why is it suitable for bindings? Describe the hardware, not what you >> want to do in the driver. >> > > What do you mean? I am adding some new property and should describe it > in dt-bindinds. Isn't it? No, if the property is not suitable for bindings, you should not add it in the first place. So again: explain what sort of hardware, not driver, problem you are solving here, so we can understand why do you need new property. Otherwise use existing properties or no properties, because we do not define all possible clocks in the bindings. Let's be clear: with such commit msg explanation as you have, my answer is: no, driver should set clock frequency and you do not need this property at all. Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic