Re: [PATCH 2/4] wiphy: remove nl80211 from wiphy object

From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 2/4] wiphy: remove nl80211 from wiphy object
Date: Thu, 8 Sep 2022 09:53:44 -0500	[thread overview]
Message-ID: <16a64a4f-5339-e0cd-3fb9-340588cf855d@gmail.com> (raw)
In-Reply-To: <20220907233201.227577-2-prestwoj@gmail.com>

Hi James,

On 9/7/22 18:31, James Prestwood wrote:
> The nl80211 object is already a global and there is no need
> to track this in wiphy itself.

Wiphy is a bit of a weird case since you have a global and a wiphy-specific dump 
for regdom.  As well as the regdom query.  But wouldn't you actually go the 
other direction?

l_genl_family_new creates a lightweight handle to the GENL object.  Once you 
unref this handle, any requests started on this handle are automagically 
destroyed.  So you strictly speaking do not need to track the command ids 
anymore.  So for example you could get rid of 'get_reg_id' fairly easily. 
'dump_id' is a bit trickier since it is used for conflict detection, but maybe..?

> ---
>   src/wiphy.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 

Regards,
-Denis