From: Ramon Fried <rfried.dev@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 9/9] net: macb: Fix check for little-endian system in gmac_configure_dma()
Date: Mon, 24 Jun 2019 16:07:16 +0300 [thread overview]
Message-ID: <16abc7f3-3670-e58a-a105-9c4b1b29eda4@gmail.com> (raw)
In-Reply-To: <CACUy__Ugw2eWL+AxEGp2QkxTgpLjb9nprH_bsD6x8jXZoG=qAQ@mail.gmail.com>
On 6/24/19 4:02 PM, Daniel Schwierzeck wrote:
> can't you simply remove the non-DM part of the driver and add a
> device-tree property for the endianess?
>
> If that's not possible short-term, than maybe add a Kconfig symbol like this:
>
> config MACB_BIG_ENDIAN
> bool "...."
> depends on MACB
> default y if SYS_BIG_ENDIAN
> default n
>
> this way it's automatically sync'ed with
> CONFIG_SYS_LITTLE_ENDIAN/CONFIG_SYS_BIG_ENDIAN, but a board config
> could still override this setting.
I can even do better, Linux for instance automatically detects the endianess for the CPU
by writing to a scratch register on MACB HW and read it back.
But I don't understand the need for a specific board to define anything different than the SYS_ENDIANES for this driver.
Thanks,
Ramon.
next prev parent reply other threads:[~2019-06-24 13:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 4:02 [U-Boot] [PATCH v7 0/9] Update SiFive Unleashed Drivers Anup Patel
2019-06-24 4:02 ` [U-Boot] [PATCH v7 1/9] clk: sifive: Factor-out PLL library as separate module Anup Patel
2019-06-24 4:02 ` [U-Boot] [PATCH v7 2/9] clk: sifive: Sync-up WRPLL library with upstream Linux Anup Patel
2019-06-24 4:02 ` [U-Boot] [PATCH v7 3/9] clk: sifive: Sync-up DT bindings header " Anup Patel
2019-06-24 5:03 ` Bin Meng
2019-06-24 4:02 ` [U-Boot] [PATCH v7 4/9] clk: sifive: Sync-up main driver " Anup Patel
2019-06-24 4:03 ` [U-Boot] [PATCH v7 5/9] clk: sifive: Drop GEMGXL clock driver Anup Patel
2019-06-24 4:03 ` [U-Boot] [PATCH v7 6/9] net: macb: Extend MACB driver for SiFive Unleashed board Anup Patel
2019-06-24 5:03 ` Bin Meng
2019-06-25 5:21 ` Ramon Fried
2019-06-25 5:48 ` Anup Patel
2019-06-24 4:03 ` [U-Boot] [PATCH v7 7/9] riscv: sifive: fu540: Setup ethaddr env variable using OTP Anup Patel
2019-06-24 5:03 ` Bin Meng
2019-07-10 17:15 ` Troy Benjegerdes
2019-07-10 23:47 ` Alistair Francis
2019-07-11 4:28 ` Anup Patel
2019-07-11 10:19 ` Ramon Fried
2019-07-12 8:39 ` Anup Patel
2019-07-15 7:07 ` Ramon Fried
2019-07-20 0:42 ` Joey Hewitt
2019-07-23 2:58 ` Joe Hershberger
2019-06-24 4:03 ` [U-Boot] [PATCH v7 8/9] doc: sifive-fu540: Update README for steps to create FW_PAYLOAD Anup Patel
2019-06-24 4:03 ` [U-Boot] [PATCH v7 9/9] net: macb: Fix check for little-endian system in gmac_configure_dma() Anup Patel
2019-06-24 5:03 ` Bin Meng
2019-06-24 12:22 ` Ramon Fried
2019-06-24 12:32 ` Bin Meng
2019-06-24 12:51 ` Ramon Fried
2019-06-24 13:02 ` Daniel Schwierzeck
2019-06-24 13:07 ` Ramon Fried [this message]
2019-06-25 4:11 ` Anup Patel
2019-06-24 13:12 ` Bin Meng
2019-06-24 13:27 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16abc7f3-3670-e58a-a105-9c4b1b29eda4@gmail.com \
--to=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.