From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD87C072B1 for ; Tue, 28 May 2019 16:11:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97449208C3 for ; Tue, 28 May 2019 16:11:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cLpFVXoO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbfE1QLF (ORCPT ); Tue, 28 May 2019 12:11:05 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:38870 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbfE1QLF (ORCPT ); Tue, 28 May 2019 12:11:05 -0400 Received: by mail-ed1-f66.google.com with SMTP id g13so2770817edu.5 for ; Tue, 28 May 2019 09:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=5NKCxpzbXsbsdqOSjRjf5/FGHtpKxTTM//85T6IDabE=; b=cLpFVXoOfaeKqTCGXaNtMKnxeMWVwEjeFGu03K3vyZC6eBv0PiWQv6yuwybs3T2QSE Abu1D0JQfhjjZTh1U/U+E+6dBESTJ+sDP24AwcxnZnZW6Wdhzzspgr7zVgt+ePfOJRYf kVHnHSVp6kD9vLVC2eOZMhKim+NPnN2ssaoZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=5NKCxpzbXsbsdqOSjRjf5/FGHtpKxTTM//85T6IDabE=; b=gPIPBub4RD3kG6a5bl4JMGeYnAkcAI0T4o6Mdg1IotP6cwQRx72rOAs7fCaazN2098 lXorZjITOX+vb9n/YiTSa65cc0GXStR5r19mxkTKdthsmzMU0rekwAkGLcM3MM8o+lfZ Y3M/Zr+GWR73Rls0Ol+spZCFE2TVCV7cky+Xqmpzm4VqTqUCJY4bby/whXflyT6X4Ss3 8f5NXSuLUeTEEevXmD4p/i6fvR3qxVoCjLts+hbD7JG1RlB1WTY3SLL7v0HGCG1ZJCbP 6iAaLPKCp+HDn1QLKr5I5fWN8w83DG1wuidG79iolbyeD3AVEkHVmMFEZ2/Z7KwgFdRi H1ZQ== X-Gm-Message-State: APjAAAW4wi4a/rNgzV+n8u7CMcYeHxVMVaXD2FL1E2hFwqurUlspT4t9 p0AJfZ2FhxheDm7zn9jJeaf7IQ== X-Google-Smtp-Source: APXvYqzO78eTgJM+fsJJF5GBrbnmxF7cyzHQDEkxqk1bfWfaLwgdTR6aYkCkV+M7paGXI74GmgyYWA== X-Received: by 2002:a17:906:ccd8:: with SMTP id ot24mr38325047ejb.263.1559059863761; Tue, 28 May 2019 09:11:03 -0700 (PDT) Received: from [192.168.178.17] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id m16sm2268549ejj.57.2019.05.28.09.11.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 May 2019 09:11:03 -0700 (PDT) From: Arend Van Spriel To: Doug Anderson , Kalle Valo CC: Madhan Mohan R , Ulf Hansson , LKML , Hante Meuleman , "David S. Miller" , netdev , "Chi-Hsien Lin" , Brian Norris , "linux-wireless" , YueHaibing , Adrian Hunter , "open list:ARM/Rockchip SoC..." , , Matthias Kaehlcke , Naveen Gupta , Wright Feng , , Double Lo , Franky Lin Date: Tue, 28 May 2019 18:11:00 +0200 Message-ID: <16aff358a20.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <16aff33f3e0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> References: <20190517225420.176893-2-dianders@chromium.org> <20190528121833.7D3A460A00@smtp.codeaurora.org> <16aff33f3e0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> User-Agent: AquaMail/1.20.0-1451 (build: 102000001) Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On May 28, 2019 6:09:21 PM Arend Van Spriel wrote: > On May 28, 2019 5:52:10 PM Doug Anderson wrote: > >> Hi, >> >> On Tue, May 28, 2019 at 5:18 AM Kalle Valo wrote: >>> >>> Douglas Anderson wrote: >>> >>> > In commit 29f6589140a1 ("brcmfmac: disable command decode in >>> > sdio_aos") we disabled something called "command decode in sdio_aos" >>> > for a whole bunch of Broadcom SDIO WiFi parts. >>> > >>> > After that patch landed I find that my kernel log on >>> > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: >>> > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 >>> > >>> > This seems to happen every time the Broadcom WiFi transitions out of >>> > sleep mode. Reverting the part of the commit that affects the WiFi on >>> > my boards fixes the problem for me, so that's what this patch does. >>> > >>> > Note that, in general, the justification in the original commit seemed >>> > a little weak. It looked like someone was testing on a SD card >>> > controller that would sometimes die if there were CRC errors on the >>> > bus. This used to happen back in early days of dw_mmc (the controller >>> > on my boards), but we fixed it. Disabling a feature on all boards >>> > just because one SD card controller is broken seems bad. ...so >>> > instead of just this patch possibly the right thing to do is to fully >>> > revert the original commit. >>> > >>> > Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") >>> > Signed-off-by: Douglas Anderson >>> >>> I don't see patch 2 in patchwork and I assume discussion continues. >> >> Apologies. I made sure to CC you individually on all the patches but >> didn't think about the fact that you use patchwork to manage and so >> didn't ensure all patches made it to all lists (by default each patch >> gets recipients individually from get_maintainer). I'll make sure to >> fix for patch set #2. If you want to see all the patches, you can at >> least find them on lore.kernel.org linked from the cover: >> >> https://lore.kernel.org/patchwork/cover/1075373/ >> >> >>> Please resend if/when I need to apply something. >>> >>> 2 patches set to Changes Requested. >>> >>> 10948785 [1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 >> >> As per Arend I'll change patch #1 to a full revert instead of a >> partial revert. Arend: please yell if you want otherwise. > > No yelling here. If any it is expected from Cypress. Maybe good to add them > specifically in Cc: Of the revert patch that is. Gr. AvS From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend Van Spriel Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 Date: Tue, 28 May 2019 18:11:00 +0200 Message-ID: <16aff358a20.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> References: <20190517225420.176893-2-dianders@chromium.org> <20190528121833.7D3A460A00@smtp.codeaurora.org> <16aff33f3e0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <16aff33f3e0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson , Kalle Valo Cc: Madhan Mohan R , Ulf Hansson , LKML , Hante Meuleman , "David S. Miller" , netdev , Chi-Hsien Lin , Brian Norris , linux-wireless , YueHaibing , Adrian Hunter , "open list:ARM/Rockchip SoC..." , brcm80211-dev-list.pdl@broadcom.com, Matthias Kaehlcke , Naveen Gupta , Wright Feng , brcm80211-dev-list@cypress.com, Double Lo , Fra List-Id: linux-rockchip.vger.kernel.org On May 28, 2019 6:09:21 PM Arend Van Spriel wrote: > On May 28, 2019 5:52:10 PM Doug Anderson wrote: > >> Hi, >> >> On Tue, May 28, 2019 at 5:18 AM Kalle Valo wrote: >>> >>> Douglas Anderson wrote: >>> >>> > In commit 29f6589140a1 ("brcmfmac: disable command decode in >>> > sdio_aos") we disabled something called "command decode in sdio_aos" >>> > for a whole bunch of Broadcom SDIO WiFi parts. >>> > >>> > After that patch landed I find that my kernel log on >>> > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: >>> > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 >>> > >>> > This seems to happen every time the Broadcom WiFi transitions out of >>> > sleep mode. Reverting the part of the commit that affects the WiFi on >>> > my boards fixes the problem for me, so that's what this patch does. >>> > >>> > Note that, in general, the justification in the original commit seemed >>> > a little weak. It looked like someone was testing on a SD card >>> > controller that would sometimes die if there were CRC errors on the >>> > bus. This used to happen back in early days of dw_mmc (the controller >>> > on my boards), but we fixed it. Disabling a feature on all boards >>> > just because one SD card controller is broken seems bad. ...so >>> > instead of just this patch possibly the right thing to do is to fully >>> > revert the original commit. >>> > >>> > Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") >>> > Signed-off-by: Douglas Anderson >>> >>> I don't see patch 2 in patchwork and I assume discussion continues. >> >> Apologies. I made sure to CC you individually on all the patches but >> didn't think about the fact that you use patchwork to manage and so >> didn't ensure all patches made it to all lists (by default each patch >> gets recipients individually from get_maintainer). I'll make sure to >> fix for patch set #2. If you want to see all the patches, you can at >> least find them on lore.kernel.org linked from the cover: >> >> https://lore.kernel.org/patchwork/cover/1075373/ >> >> >>> Please resend if/when I need to apply something. >>> >>> 2 patches set to Changes Requested. >>> >>> 10948785 [1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 >> >> As per Arend I'll change patch #1 to a full revert instead of a >> partial revert. Arend: please yell if you want otherwise. > > No yelling here. If any it is expected from Cypress. Maybe good to add them > specifically in Cc: Of the revert patch that is. Gr. AvS