Re: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ?

From: Joe Perches <joe@perches.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>,
	"Ismail, Mustafa" <mustafa.ismail@intel.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ?
Date: Tue, 08 Jun 2021 09:25:34 -0700	[thread overview]
Message-ID: <16b30bff1b1403192f18f110ac83451d4f7d5bc1.camel@perches.com> (raw)
In-Reply-To: <38e0a7b9c19543c2aee679bdd346c5a9@intel.com>

On Tue, 2021-06-08 at 16:18 +0000, Saleem, Shiraz wrote:
> > > Looks reasonable to me. Wondering if irdma_update_stats should
> > > also use your IRDMA_STAT macro.
> > 
> > Probably, and it could really a macro or two of its own.
> > 
> > And it looks like that block has it's own copy/paste defects.
> > 
> > Maybe:
> > ---
[]
> > +#define irdma_update_stat(index, var, size)				\
> 
> Maybe var --> name. Other than that looks good.

Just a suggestion.  Do what you want with it.

And also the field name/MACRO mismatches are a bit odd at best.

I'd rename one or the other to match.

> +     irdma_update_stat(IP4TXFRAGS, ip4txfrag, 48);
[]
> +     irdma_update_stat(TCPTXSEG, tcptxsegs, 48);
[]
> +     irdma_update_stat(RDMAVBND, rdmavbn, 48);