From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1920C4338F for ; Wed, 18 Aug 2021 09:46:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D6C46101A for ; Wed, 18 Aug 2021 09:46:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D6C46101A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGI9f-0003WA-3B for qemu-devel@archiver.kernel.org; Wed, 18 Aug 2021 05:46:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGI8s-0002qg-EC for qemu-devel@nongnu.org; Wed, 18 Aug 2021 05:45:50 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:38678 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGI8q-0001jZ-GY for qemu-devel@nongnu.org; Wed, 18 Aug 2021 05:45:50 -0400 Received: from host86-179-247-14.range86-179.btcentralplus.com ([86.179.247.14] helo=[192.168.50.176]) by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mGI8R-000Ci5-Hf; Wed, 18 Aug 2021 10:45:29 +0100 To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210810140653.3969823-1-berrange@redhat.com> <20210810140653.3969823-2-berrange@redhat.com> <11174538-e2fb-cd99-de92-3153fa56d017@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <16bd9721-a296-9cc7-0a94-dd76e2696b81@ilande.co.uk> Date: Wed, 18 Aug 2021 10:45:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 86.179.247.14 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 1/2] gitlab: exclude sparc-softmmu and riscv32-softmmu from cross builds X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.961, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Willian Rampazzo , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/08/2021 10:29, Daniel P. Berrangé wrote: > On Wed, Aug 18, 2021 at 10:15:47AM +0100, Mark Cave-Ayland wrote: >> On 10/08/2021 15:06, Daniel P. Berrangé wrote: >> >>> We need to cut down compile time by excluding more targets. Both these >>> targets still have their 64-bit variant enabled, so the loss of coverage >>> is mitigated to some degree. >>> >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> .gitlab-ci.d/crossbuild-template.yml | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml >>> index 7d3ad00a1e..cfb576b54c 100644 >>> --- a/.gitlab-ci.d/crossbuild-template.yml >>> +++ b/.gitlab-ci.d/crossbuild-template.yml >>> @@ -9,7 +9,8 @@ >>> ../configure --enable-werror --disable-docs $QEMU_CONFIGURE_OPTS >>> --disable-user --target-list-exclude="arm-softmmu cris-softmmu >>> i386-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu >>> - mips64-softmmu ppc-softmmu sh4-softmmu xtensa-softmmu" >>> + mips64-softmmu ppc-softmmu riscv32-softmmu sh4-softmmu >>> + sparc-softmmu xtensa-softmmu" >>> - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS >>> - if grep -q "EXESUF=.exe" config-host.mak; >>> then make installer; >> >> I'd prefer to keep sparc-softmmu if possible, simply because my everyday >> platform is Linux and so having a cross-build for Windows will catch things >> that I may miss on a day-to-day basis. Is sparc-softmmu currently enabled as >> part of the native MINGW64 build? > > Note the builds still include 'sparc64-softmmu', so we're only loosing > cover in places where it diverges fromthe 64-bit build, but this will > sstil get coverage in native builds. Okay I see. From my perspective sparc-softmmu covers more corner cases simply because everything is wired up as cMMIO peripherals on a custum bus compared with sparc64-softmmu which is a PCI machine and so there is already a lot of overlap there. However... >> If I go to my Gitlab QEMU fork Settings -> CI/CD -> Variables there is an >> option to set variables that can be used in job scripts. Perhaps this could >> be used so that I can configure my personal QEMU fork to always run >> sparc-softmmu builds when preparing PRs even if they aren't enabled for >> everyone by default? At least this would then allow me to spot any breakage >> before sending a final PR to Peter. > > Separately from this I'm doing some work to make things more configurable > > https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg02102.html > > but not on this level of granularity. > > Rather than globally excluding from all cross builds, I think we ought to > split it up more equitably acrss the different builds in some way. From my perspective as long as I have something in Gitlab that I can push and then get a green CI build that covers both sparc platforms on Linux/Windows then I'm not too concerned about the implementation details. As long as the combination is covered in a job somewhere in your latest set of build changes then that's okay with me. ATB, Mark.