From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3801CC61DA4 for ; Mon, 6 Mar 2023 18:26:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbjCFS0Q (ORCPT ); Mon, 6 Mar 2023 13:26:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbjCFS0K (ORCPT ); Mon, 6 Mar 2023 13:26:10 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6777C65C49 for ; Mon, 6 Mar 2023 10:25:30 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id k10so18625141edk.13 for ; Mon, 06 Mar 2023 10:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678127128; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nQzsrijClWNNzU3MRuhrnrc1rJRiQBgGk6WQ0sbFW3w=; b=hOraMv8H7Cyz5xH6F7BK/KyRTvjXIZqXW9MxDPz7cE2clNcvKPVAVWnMOGnD8OCJYt bbnDcAlBA40qUUqzWql2ZfFMYGK87mnXjnQEzZBq2+FV2TugN15eYHqXRWiV5tJTi0nV 0Iu0OfdTHVYuVav3UMc4jZGk9SRBfCuI4QuE+qTuuRfEmxH4frYRr4qH2QhVDc4KSAXo iV063p5qOo5CAFYkLs5heOtOof1RMogLbiJGS0ePSKgOsgiiLMbBI7mgvgy+5zb0Mj7j rgIZV7el8QgPYEic7w2QZdqobAOpKz8CQloM07aqIjjny0rfbWGGq7tBaVeMpDf9LWiD JfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678127128; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nQzsrijClWNNzU3MRuhrnrc1rJRiQBgGk6WQ0sbFW3w=; b=O11blS4V6hNULnLB9GxpxDr2ethF5lPOzmd4JDsOh2pvioVeiCkSZ850Fr9vTjysr0 ynIJH5FIIPfc+BHM3+UPs8MDuMjIKw7c45Df/RSYL3TyzzZEcv7CVzk5SvL/kIx/uAIj 1fsjJxgM8YgCMiRkcke5dvXCuRaLMDW7S5yxTsvR216MnZKuIUetKIJKr966Ru2DIAcm brXqYyIOgBCGA/WFSRQ429KutpGemkC0DEAmhbDTKrzslnT/jDj4QQyndtN7hKbETDVs SZNTLOcOVZNg28J7zvBdLmOci2QFKP7pCCX2NuNXjZZzOJUURU2StuI6OqGBU9hqYSGM 9xoQ== X-Gm-Message-State: AO0yUKVl9WE6YWdRgyt1UizAojuyf4XLAEG2nQ6E8XUY7l4lvMrvCiYi vyv5rBOTH2bPdhc8P44ciCWTsg== X-Google-Smtp-Source: AK7set9JT2Nj4Pw013wQ3FbV4jgAzrH9Kxatn5KcWt4QQiYFaLHZ4DdRvS6lee8MRRyNPFu8gIV/1A== X-Received: by 2002:aa7:c44e:0:b0:4af:502b:54a8 with SMTP id n14-20020aa7c44e000000b004af502b54a8mr9877761edr.6.1678127128376; Mon, 06 Mar 2023 10:25:28 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:dcb0:1567:5d06:3be8? ([2a02:810d:15c0:828:dcb0:1567:5d06:3be8]) by smtp.gmail.com with ESMTPSA id x20-20020a50d614000000b004aeeb476c5bsm4816005edi.24.2023.03.06.10.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 10:25:28 -0800 (PST) Message-ID: <16bee433-0088-d651-9592-96a2bb827b7f@linaro.org> Date: Mon, 6 Mar 2023 19:25:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules Content-Language: en-US To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org References: <20230224150811.80316-1-nick.alcock@oracle.com> <20230224150811.80316-16-nick.alcock@oracle.com> <87h6ux7qhp.fsf@esperi.org.uk> From: Krzysztof Kozlowski In-Reply-To: <87h6ux7qhp.fsf@esperi.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 06/03/2023 18:13, Nick Alcock wrote: > On 6 Mar 2023, Krzysztof Kozlowski told this: > >> On 06/03/2023 15:30, Krzysztof Kozlowski wrote: >>> On 24/02/2023 16:07, Nick Alcock wrote: >>>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without >>>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations >>>> are used to identify modules. As a consequence, uses of the macro >>>> in non-modules will cause modprobe to misidentify their containing >>>> object file as a module when it is not (false positives), and modprobe >>>> might succeed rather than failing with a suitable error message. >>>> >>>> So remove it in the files in this commit, none of which can be built as >>>> modules. >>> >>> Applied as well. Squashed with next one. Same subject messes with b4, so >>> prefix should be corrected if these were to stay as separate patches. >> >> And all dropped. Run checkpatch before sending patches. > > So... which of the 27 patches n this series is being dropped? It would > also be nice to know what the checkpatch problems were, because all I > can see from checkpatch is one error per patch, an apparent false The ones I responded that I applied - so the memory controller ones. > positive: > > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 8b41fc4454e3 ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf")' > > The commit message says: > >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > > ... which unless I am seeing things is precisely what checkpatch.pl is > asking for. Perhaps it can't handle wrapped lines, but not wrapping a > git commit log line *also* (correctly) elicits a checkpatch error... It's not a false positive, but an error I am asking fix (assuming there are no more ones) There is no problem with wrapping lines - checkpatch handles it. Best regards, Krzysztof