From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42152EB64DA for ; Fri, 7 Jul 2023 08:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232501AbjGGIXI (ORCPT ); Fri, 7 Jul 2023 04:23:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232995AbjGGIW4 (ORCPT ); Fri, 7 Jul 2023 04:22:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614AC2109; Fri, 7 Jul 2023 01:22:44 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6E8056606FCA; Fri, 7 Jul 2023 09:22:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718163; bh=C7CMkxmZPAlHvOPFwq2S9P/9xy5K1sw18FMOfrzXvRs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DvqZkfgqgUMrr+u89G0Qog44SqNJzD2utg2faRY9pl8nXtOZORJywbcWcb01Mh9Mb 9s4d0sCaaD+ZUnS0VafaPJjmCMK14DnM25sDcVuswmSA9GSQhfIIRC52kc4AYW1/9K +TWstsAk3LrBkXhw1mm5WVGQEthuqx/ZHFZ3qVNAycSNV+iFXF99USK+blOhEVVg8M assnECXSq4tIvwZK2XgsrpY7U+u/fVTi0O9wyllf1pPmbWRNctpZ1UB2NaCqby0+zl Ps7wpuPWcV8QI8mB4aocMhj9X6CQY2QrWPlOWsE0XBwWiW0IkoCSjaFOll4k0bPgV0 w/v1Op4BHVtOA== Message-ID: <16c4d5a9-4eeb-6a92-e97e-6e15eaeb913a@collabora.com> Date: Fri, 7 Jul 2023 10:22:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 6/6] thermal/drivers/mediatek/lvts_thermal: Manage threshold between sensors Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-7-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-7-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/07/23 17:37, Nícolas F. R. A. Prado ha scritto: > Each LVTS thermal controller can have up to four sensors, each capable > of triggering its own interrupt when its measured temperature crosses > the configured threshold. The threshold for each sensor is handled > separately by the thermal framework, since each one is registered with > its own thermal zone and trips. However, the temperature thresholds are > configured on the controller, and therefore are shared between all > sensors on that controller. > > When the temperature measured by the sensors is different enough to > cause the thermal framework to configure different thresholds for each > one, interrupts start triggering on sensors outside the last threshold > configured. > > To address the issue, track the thresholds required by each sensor and > only actually set the highest one in the hardware, and disable > interrupts for all sensors outside the current configured range. > > Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") > Signed-off-by: Nícolas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1602EC001B0 for ; Fri, 7 Jul 2023 08:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y5K22SNEcNgDQHPrigVuNzHHrjB6CEHRnYxdpfL5wZ8=; b=vt2AyYuzchYWuo kGby/kc9DoZ9hzBI8nWcf33hZ9KUF4/uf5kTwm75SL7VUk0NTifdXwSl7PfUbx7SfqYdJ7BPcenMY P7xoVcccOOAsSpaasQFr/d3H4IZ24bZwIk93Yp2OQxz1MbAyuFAOurEC0GfCQKJDaSCiJTlP9NbBM X4xZTisvy4/l2JPbxQegAc67K9Vt5GoWKd53FTwWRRMP1ONBQPXXs1OXEwsO4TmjM9E28DYDxojny VI8010YG83M0sjXwa72XY+g6SX7Nr+P/a7irw/MLzD4O4Mp0wioN8H+cFkxOaNvp7Avv9p1fYcLHV LjEvm7JKnxtdgLbBq+zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHgjm-003yvf-1l; Fri, 07 Jul 2023 08:22:46 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHgjk-003yuW-1L; Fri, 07 Jul 2023 08:22:45 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6E8056606FCA; Fri, 7 Jul 2023 09:22:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718163; bh=C7CMkxmZPAlHvOPFwq2S9P/9xy5K1sw18FMOfrzXvRs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DvqZkfgqgUMrr+u89G0Qog44SqNJzD2utg2faRY9pl8nXtOZORJywbcWcb01Mh9Mb 9s4d0sCaaD+ZUnS0VafaPJjmCMK14DnM25sDcVuswmSA9GSQhfIIRC52kc4AYW1/9K +TWstsAk3LrBkXhw1mm5WVGQEthuqx/ZHFZ3qVNAycSNV+iFXF99USK+blOhEVVg8M assnECXSq4tIvwZK2XgsrpY7U+u/fVTi0O9wyllf1pPmbWRNctpZ1UB2NaCqby0+zl Ps7wpuPWcV8QI8mB4aocMhj9X6CQY2QrWPlOWsE0XBwWiW0IkoCSjaFOll4k0bPgV0 w/v1Op4BHVtOA== Message-ID: <16c4d5a9-4eeb-6a92-e97e-6e15eaeb913a@collabora.com> Date: Fri, 7 Jul 2023 10:22:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 6/6] thermal/drivers/mediatek/lvts_thermal: Manage threshold between sensors Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-7-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-7-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_012244_598885_2624023A X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMDYvMDcvMjMgMTc6MzcsIE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIGhhIHNjcml0dG86Cj4g RWFjaCBMVlRTIHRoZXJtYWwgY29udHJvbGxlciBjYW4gaGF2ZSB1cCB0byBmb3VyIHNlbnNvcnMs IGVhY2ggY2FwYWJsZQo+IG9mIHRyaWdnZXJpbmcgaXRzIG93biBpbnRlcnJ1cHQgd2hlbiBpdHMg bWVhc3VyZWQgdGVtcGVyYXR1cmUgY3Jvc3Nlcwo+IHRoZSBjb25maWd1cmVkIHRocmVzaG9sZC4g VGhlIHRocmVzaG9sZCBmb3IgZWFjaCBzZW5zb3IgaXMgaGFuZGxlZAo+IHNlcGFyYXRlbHkgYnkg dGhlIHRoZXJtYWwgZnJhbWV3b3JrLCBzaW5jZSBlYWNoIG9uZSBpcyByZWdpc3RlcmVkIHdpdGgK PiBpdHMgb3duIHRoZXJtYWwgem9uZSBhbmQgdHJpcHMuIEhvd2V2ZXIsIHRoZSB0ZW1wZXJhdHVy ZSB0aHJlc2hvbGRzIGFyZQo+IGNvbmZpZ3VyZWQgb24gdGhlIGNvbnRyb2xsZXIsIGFuZCB0aGVy ZWZvcmUgYXJlIHNoYXJlZCBiZXR3ZWVuIGFsbAo+IHNlbnNvcnMgb24gdGhhdCBjb250cm9sbGVy Lgo+IAo+IFdoZW4gdGhlIHRlbXBlcmF0dXJlIG1lYXN1cmVkIGJ5IHRoZSBzZW5zb3JzIGlzIGRp ZmZlcmVudCBlbm91Z2ggdG8KPiBjYXVzZSB0aGUgdGhlcm1hbCBmcmFtZXdvcmsgdG8gY29uZmln dXJlIGRpZmZlcmVudCB0aHJlc2hvbGRzIGZvciBlYWNoCj4gb25lLCBpbnRlcnJ1cHRzIHN0YXJ0 IHRyaWdnZXJpbmcgb24gc2Vuc29ycyBvdXRzaWRlIHRoZSBsYXN0IHRocmVzaG9sZAo+IGNvbmZp Z3VyZWQuCj4gCj4gVG8gYWRkcmVzcyB0aGUgaXNzdWUsIHRyYWNrIHRoZSB0aHJlc2hvbGRzIHJl cXVpcmVkIGJ5IGVhY2ggc2Vuc29yIGFuZAo+IG9ubHkgYWN0dWFsbHkgc2V0IHRoZSBoaWdoZXN0 IG9uZSBpbiB0aGUgaGFyZHdhcmUsIGFuZCBkaXNhYmxlCj4gaW50ZXJydXB0cyBmb3IgYWxsIHNl bnNvcnMgb3V0c2lkZSB0aGUgY3VycmVudCBjb25maWd1cmVkIHJhbmdlLgo+IAo+IEZpeGVzOiBm NWY2MzNiMTgyMzQgKCJ0aGVybWFsL2RyaXZlcnMvbWVkaWF0ZWs6IEFkZCB0aGUgTG93IFZvbHRh Z2UgVGhlcm1hbCBTZW5zb3IgZHJpdmVyIikKPiBTaWduZWQtb2ZmLWJ5OiBOw61jb2xhcyBGLiBS LiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+Cj4gCgpSZXZpZXdlZC1ieTogQW5n ZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gPGFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29sbGFi b3JhLmNvbT4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==