From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback Date: Sat, 8 Oct 2016 15:20:30 +0800 Message-ID: <16d62eea-19cc-56aa-7b2c-0bf6484ae1bf@linux.intel.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-6-git-send-email-guangrong.xiao@linux.intel.com> <20161003114517.3fd0ab61@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Igor Mammedov Return-path: Received: from mga01.intel.com ([192.55.52.88]:40749 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbcJHH1C (ORCPT ); Sat, 8 Oct 2016 03:27:02 -0400 In-Reply-To: <20161003114517.3fd0ab61@nial.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/03/2016 05:45 PM, Igor Mammedov wrote: > On Fri, 12 Aug 2016 14:54:07 +0800 > Xiao Guangrong wrote: > >> We should let nvdimm acpi know which nvdimm device is being unplugged >> before QEMU interrupts the guest so that nvdimm acpi can update its >> FIT properly >> >> prepare_unplug() callback is introduced exactly for this purpose then >> the being removed device is skipped when guest reads FIT > Hot-unplug for NVDIMMs isn't mentinoned in spec so I'd would drop it for now. Okay. Then i will stop hot-unplug and generate a error message if nvdimm device is being un-plugged: "NVDIMM hot-unplug has not been supported yet." From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsm2G-0005fg-AM for qemu-devel@nongnu.org; Sat, 08 Oct 2016 03:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsm2A-0004jn-9U for qemu-devel@nongnu.org; Sat, 08 Oct 2016 03:27:07 -0400 Received: from mga05.intel.com ([192.55.52.43]:36008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsm2A-0004ii-35 for qemu-devel@nongnu.org; Sat, 08 Oct 2016 03:27:02 -0400 References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-6-git-send-email-guangrong.xiao@linux.intel.com> <20161003114517.3fd0ab61@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <16d62eea-19cc-56aa-7b2c-0bf6484ae1bf@linux.intel.com> Date: Sat, 8 Oct 2016 15:20:30 +0800 MIME-Version: 1.0 In-Reply-To: <20161003114517.3fd0ab61@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On 10/03/2016 05:45 PM, Igor Mammedov wrote: > On Fri, 12 Aug 2016 14:54:07 +0800 > Xiao Guangrong wrote: > >> We should let nvdimm acpi know which nvdimm device is being unplugged >> before QEMU interrupts the guest so that nvdimm acpi can update its >> FIT properly >> >> prepare_unplug() callback is introduced exactly for this purpose then >> the being removed device is skipped when guest reads FIT > Hot-unplug for NVDIMMs isn't mentinoned in spec so I'd would drop it for now. Okay. Then i will stop hot-unplug and generate a error message if nvdimm device is being un-plugged: "NVDIMM hot-unplug has not been supported yet."