All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH v1 04/16] drm/i915: un-inline icl_hdr_plane_mask() to simplify includes
Date: Wed,  2 Nov 2022 12:08:12 +0200	[thread overview]
Message-ID: <16e13b6f207f52f8810a06f71a08e637f6397dc8.1667383630.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1667383630.git.jani.nikula@intel.com>

This lets us drop the heavy intel_display.h include from intel_sprite.h.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_sprite.h        | 9 +--------
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++
 drivers/gpu/drm/i915/display/skl_universal_plane.h | 1 +
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_sprite.h b/drivers/gpu/drm/i915/display/intel_sprite.h
index 4f63e4967731..4635c7ad23f9 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.h
+++ b/drivers/gpu/drm/i915/display/intel_sprite.h
@@ -8,14 +8,13 @@
 
 #include <linux/types.h>
 
-#include "intel_display.h"
-
 struct drm_device;
 struct drm_display_mode;
 struct drm_file;
 struct drm_i915_private;
 struct intel_crtc_state;
 struct intel_plane_state;
+enum pipe;
 
 /*
  * FIXME: We should instead only take spinlocks once for the entire update
@@ -34,12 +33,6 @@ int intel_sprite_set_colorkey_ioctl(struct drm_device *dev, void *data,
 int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state);
 int chv_plane_check_rotation(const struct intel_plane_state *plane_state);
 
-static inline u8 icl_hdr_plane_mask(void)
-{
-	return BIT(PLANE_PRIMARY) |
-		BIT(PLANE_SPRITE0) | BIT(PLANE_SPRITE1);
-}
-
 int ivb_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
 			const struct intel_plane_state *plane_state);
 int hsw_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 7cb713043408..46e10b369a3d 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -246,6 +246,11 @@ bool icl_is_nv12_y_plane(struct drm_i915_private *dev_priv,
 		icl_nv12_y_plane_mask(dev_priv) & BIT(plane_id);
 }
 
+u8 icl_hdr_plane_mask(void)
+{
+	return BIT(PLANE_PRIMARY) | BIT(PLANE_SPRITE0) | BIT(PLANE_SPRITE1);
+}
+
 bool icl_is_hdr_plane(struct drm_i915_private *dev_priv, enum plane_id plane_id)
 {
 	return DISPLAY_VER(dev_priv) >= 11 &&
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.h b/drivers/gpu/drm/i915/display/skl_universal_plane.h
index 351040b64dc7..be64c201f9b3 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.h
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.h
@@ -30,6 +30,7 @@ int skl_calc_main_surface_offset(const struct intel_plane_state *plane_state,
 
 bool icl_is_nv12_y_plane(struct drm_i915_private *dev_priv,
 			 enum plane_id plane_id);
+u8 icl_hdr_plane_mask(void);
 bool icl_is_hdr_plane(struct drm_i915_private *dev_priv, enum plane_id plane_id);
 
 #endif
-- 
2.34.1


  parent reply	other threads:[~2022-11-02 10:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 10:08 [Intel-gfx] [PATCH v1 00/16] drm/i915: header cleanups, again Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 01/16] drm/i915/gmbus: move GPIO enum to gmbus Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 02/16] drm/i915: reduce includes in intel_connector.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 03/16] drm/i915: reduce includes in intel_fifo_underrun.h Jani Nikula
2022-11-02 10:08 ` Jani Nikula [this message]
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 05/16] drm/i915/dpio: un-inline the vlv phy/channel mapping functions Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 06/16] drm/i915/dpio: move dpio_channel and dpio_phy enums to intel_dpio_phy.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 07/16] drm/i915: reduce includes in intel_display_power.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 08/16] drm/i915/display: reduce the includes in intel_dvo_dev.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 09/16] drm/i915/display: reduce includes in intel_hdmi.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 10/16] drm/i915/display: reduce includes in g4x_dp.h includes Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 11/16] drm/i915/irq: make gen2_irq_init()/gen2_irq_reset() static Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 12/16] drm/i915/reg: move masked field helpers to i915_reg_defs.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 13/16] drm/i915/reg: move pick even and pick to reg defs Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 14/16] drm/i915: split out intel_display_reg_defs.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 15/16] drm/i915: stop including i915_irq.h from i915_trace.h Jani Nikula
2022-11-02 10:08 ` [Intel-gfx] [PATCH v1 16/16] drm/i915/display: move struct intel_link_m_n to intel_display_types.h Jani Nikula
2022-11-02 10:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: header cleanups, again Patchwork
2022-11-02 10:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-11-02 10:31 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-11-02 12:18 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-11-02 15:16   ` Jani Nikula
2022-11-02 16:40     ` Vudum, Lakshminarayana
2022-11-02 14:19 ` [Intel-gfx] [PATCH v1 00/16] " Ville Syrjälä
2022-11-02 15:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-02 19:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16e13b6f207f52f8810a06f71a08e637f6397dc8.1667383630.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.