From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A661DC433EF for ; Mon, 14 Feb 2022 12:10:57 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCCC040DDA; Mon, 14 Feb 2022 13:10:56 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7538A4068C for ; Mon, 14 Feb 2022 13:10:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644840655; x=1676376655; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=1sJM8nOUE7wv4SuFwMZx1E3TjLkFgIEpla2fIH1rR3Y=; b=DwjNGJlZSYIBfmbVV063eKKF6V/F3G7F3Sz/k2EQCTkzFoldGx5iPfYC gPJsFDTKV3FaSg9JsOBNgwGTpMDOMTbxoepoeKrzFG0k0UZQUA7Zoff21 s4KXXeR4a3TQl3kCs6j6tST27WEcl6sf8nDl7pk6S26nXEdTngILo+IwS HSVhFJireQrhsVEMgZyKSBUvAo3cL/j4kQ+BBHZA9NDR/oDB/PA8JHHGr kyoB2qPbbvjK/JPnVs+ntXb7wx5VhNPiZ34DvpsUxmRFOV09y1AJVSf4f i0tCIszW1654emX5jRujDGNjMQf5HsbZCgYjsO2/z+jrD63AbqIdphfCk A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="250282348" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="250282348" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 04:10:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="495512718" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 14 Feb 2022 04:10:54 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 04:10:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 04:10:53 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 04:10:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRjPCcpOmWYEailE2YBwM4s667AgUIYGWxQcgSBAsCge8Nht1SAEUPoKraQtjujiIPoYxVW1lApszZGf6U2UiOmSfprt0HpOOIVADejLi2DmxoRS8hDCmZAnXpLy44+g9lFenHRo0swm2/NxvL51CCAehf85jmjP/0XIpw1hdxubz6i9ZHAQdBN4YCMwLaXwX93Hxu5bWbnefgFCCgkDPhkwvLjqFm1CJV61lOxSyErANPgopli8QyTIu/K4T86V7FvihrgzV//6LELl4Dz9ezawwMJGccaEFB+wkW1LYPgWbHIcRck68WZvpkG72F0NhD+RLsmZOYWpFB8An1uaKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8tC1NDOOzWkvRW/1oBXiWZ3X7LSwGwxHYTqTQnznA4=; b=e5OSxKErkZxZKSz9wMg77EeYulWMr5tVPz2xgw1aoTR89khy5GC8+iFgQnPBX+hyBUhvCOT9CHwg1x13VahZ0dtZLH+tAjgdpm3mEEu5qy5Rb8oQKsoGtdHKnW+9djRS1PZWu13nnt5r9D2LBCKqKF8206XltdJSakLIEvxCbUMpCdLeuRZDe0esjo74a26TeNk1XPgMZq5SLrrnq0lrvo+HX9ywEcVEkMR3TuGX5dd0S/ZDEhGNSGwVFCJ4siYCfF8jLdHyNKpSeFxHn/oKOM4ibXkptEKbwcWRZ/Z4Bi7b7mm8XslUWfMZiqxB/2LK7Z2lq60iCWoUCns4RN7A7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB4029.namprd11.prod.outlook.com (2603:10b6:208:155::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb 2022 12:10:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 12:10:40 +0000 Message-ID: <16e34ea8-64e9-8bbd-377a-2c3c2bb08546@intel.com> Date: Mon, 14 Feb 2022 12:10:34 +0000 Content-Language: en-US To: Gowrishankar Muthukrishnan , CC: Thomas Monjalon , Andrew Rybchenko , References: <20220212123621.3394272-1-gmuthukrishn@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH] ethdev: remove dead code in telemetry handler X-User: ferruhy In-Reply-To: <20220212123621.3394272-1-gmuthukrishn@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0412.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74671ba3-7779-4dcd-1131-08d9efb3049a X-MS-TrafficTypeDiagnostic: MN2PR11MB4029:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Sglt/RDIQw+EE/x8c16TFoOYumAhPeKto4Od0c6ay+DHwFKUuM+8d9E90VF0wyk/wxWCdwIAadRRYdYVHgd2EFwhPXn2ZQb7aeRYvkg5T20alY29cvX7wUMsGpJQrw7p1OClkbAmKyu7bf7iwJ4wiV2gW5WaA86r5uzX1+V39uJ2lORvtuxz7u7uLyFNcvWa/EUs91i1atTtivXf9kTxLNiPkCk14ryfs5/oG+6FxsND8IDEsIpQmBmhVAFnF5sDCmRRTdT3peYkmd985LL87lm8gL+ARtV55cioCslytE82Ro8akOCrJ7ma6zknTvurI1gfyEQ3dbBiYE0bFfN73kS8Rmp34J1kuvoEFm/nvvUu2/+VwBUrpaOreazwUeko48SMddu929XUqZQfQ+LoDQftSAod41L42NQfFeh0y2Ib3gsG7DC4RymxgUP6x/AaQ+7boKqtHJ68tJd7J7X5V5NIkMp5iCGytE0MJK+2Y3o8qWcJzSeOSWEk/fnL0AR1ssOyV+c3nVyzFLP4WqHLJIQNbmgdyLSDOUoZ3QIZ5RpetYETcL/H5cDd1w3lLMB+uYtpg0KAi/RggPt9P6WO5XboUKaRrrdCUksuAojIJ2TqsvO9WROqY4HZijYwBfgA+Ha1weOovApX65D68jkxq6u1WlXlij+Ler/E4SFnBpt92BEvh2Ck5nAxrv6Q2gM/m51xXvqP6s3snAKkjMG/nMFkwGSXRw5oKOhpran1rnp+eyM/pxeNtU5bkaVc8fzJMsk3V9x/OCFnsGlj4T/KdN9XpzTg6NE7W3QQhlVVV10YYAbOUo1+gAL8P40moSbuskWfQXwqAOuAHpiLr2smA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(186003)(8936002)(4326008)(66946007)(66556008)(66476007)(2906002)(5660300002)(8676002)(36756003)(86362001)(31696002)(82960400001)(38100700002)(83380400001)(508600001)(6512007)(2616005)(26005)(31686004)(6486002)(966005)(316002)(54906003)(6666004)(53546011)(6506007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czlMTnBzb0Z6SzNqNGxydDVrOWFhb0poUVVVdTRCaDYwQWZPM0gwMGl2TWRH?= =?utf-8?B?WFNaMjNhbVJkM2hrMkZMTnhUUnROSXllWHJoSXcxYUw2YjNVS2R1SlFtSHZE?= =?utf-8?B?UjIvbkpTNjBicjhGVTVTRmw0dXczOTNtb0xWQUxvTDVscVJvdkU1VUhWNUth?= =?utf-8?B?cEZLV3ZQd1FJV09ac1NoUEpsRWRFb2ljSlJsRXo5NGFWeWthRHBCLzRTWjVD?= =?utf-8?B?ZTYzdjNSSFd2eVVtREpERnkwdFFrUXBaL1g4TFVxRm42WC9Vdy9Na3Z6dUFB?= =?utf-8?B?L3ZhVVdJMUNqVEs5NkZ6ZTJDNXNoZzFrZW5LcThmNFdkQ1ZBK1NORWVzVEdU?= =?utf-8?B?OFl6cERaUy9EeXk3Wm8rc3JYbHJmekdhcHROUG95dWF1QWFPWU1DengrdVNo?= =?utf-8?B?RmxJOUFFcDBBRkFFUEhGU2xvS2ltN3NpNzBUVURoL3BObk01WFN3Q3Nadk4y?= =?utf-8?B?T21Fd1RGemMvY0ZENXNUK2dYN2x5UE1qYzUyLzJUSThzdnQvOExsVEpmdmN4?= =?utf-8?B?ei9IKzhRSnRaQ0JpczV1eEI4Ymd2WUpsVUtraGIzUHdMWDRYOVloSU5ZT2dW?= =?utf-8?B?Ty82RWF3NlVMSXFlOWhpMFgzYitkVEVmNmNGdFdZaURRejV3TUM4U040OHpv?= =?utf-8?B?ejllT3Z3aTNaMHZNdXBza1lvWDhvK3IzQVoxc25mUS9XQ2g2UTdLb0RrZ2xQ?= =?utf-8?B?MUpEY0tNVTg3WEJzakpKZVJIQm5kd2Q0dVF4cDFyUDdFbENDYXJYK1dMY2sy?= =?utf-8?B?R2dOd2ljVFZ6UVZ1cmRhRmVBTGdMeUw2c3dPZUNEbkUyTmhtSEh1RlVLcXJL?= =?utf-8?B?UXpudUswUjVsdEdPVGdiSzF0OFlmcTNPQ2tNRWRRZndnL0dYV3owbWdsRTdq?= =?utf-8?B?c0hUU0Y4N1E5SG11ajNFSGdCdXRlSVVMdjJ2OWl4MzhQTDk3clBwODFWSjdO?= =?utf-8?B?OWVudWJYdVBTK0JGcVBscjFEWFVDd2NndTEwUmgvdFVTWXZHeC9aVG9vTnpT?= =?utf-8?B?a1d1OTBkSHVNVWxGSTkwek92ekV3aXdZVjNaek41WFVkbkF2a2tUZ2xKcDBJ?= =?utf-8?B?bHQ0d1Boa1ArczJyTGl6MkZNRjhpWGdCQjJaRVFXaUxyN1AyR2dpbTd5aUtZ?= =?utf-8?B?QWdOVDZ5ZkN2VnV1azQ3Q1dYVUVqMVhDYjBPQUg0NktackVOSW05ZkJFVWg5?= =?utf-8?B?OVpYV20xSGdabEhrZWpsZ3lRRVdNbnd4Q0VvMXN3N2gzUHh1UnFKWldsQkdM?= =?utf-8?B?bUJhckxkWXdid1FSZGdhTXFkMC84eEcrWU5KRmhFajJjUGExYjd6MXF5d1Z2?= =?utf-8?B?cWdldTUvbkh2UHg1VUFLeUVhVk5ncjRtZVlsWlNtYWRHZUFJUTdJQnlVbEcy?= =?utf-8?B?c2VDeDk0M2tYWVV2OXVOczhTVzFaVHFHWk5jNjF3d1V2YzBoTnREVlNpc3dD?= =?utf-8?B?QlQ0VzZ5VmhvWDVqNGMzbTZmQzV4U3JlN3dyNXBPOW05MjdlaDEzRHlMUm45?= =?utf-8?B?TmQwN0VaU29MRHpVUWJxVVMxc3p5V0FIZ3RqMDFKeGhKMGpRejVyQjhsY3Bz?= =?utf-8?B?K1htc2c3NDV3UEZKSG8vVXdwajlERERmSlVOeFFSbG1CQWxNOUtkUHI0cG1F?= =?utf-8?B?SG9EckJXTkg3SEZEM29XTkFsNVNRZzlVNTJGK1ZycFdWOHlDS1g1VEwxeFJn?= =?utf-8?B?Yyt4MitVZitOa0lDSGFWN3JlcmMzbStqbUNUNUgzRnVzSVlUaW9DRFc4TjNL?= =?utf-8?B?WFpVYXl3Q1R5eFA1Q0xORTI1QW9sb24yazZ1c3hMZGFGRGxtSDhubmsvNGFy?= =?utf-8?B?V3EwOU9yaUozTTZEd251dnpvK01HZkJjTUZmd2JjMzJhbkxWT25yUElnazJR?= =?utf-8?B?TGZ3SmZvUENiWjd0bVFmUFJISXcrbVJtK21adGs4NXViOEc0NGljS2Z1Tm5h?= =?utf-8?B?L0tNNjNNRXZuRmhGVWpwTHRxWGw0OUdlSXpDMHUrVHA5YlBITmVKRlJEVXNM?= =?utf-8?B?Yi9sRWlEV0J3TENicnVXdW5hak9IVWdOcnlXS3VOMHFyUFUvWjJObmxvdU9z?= =?utf-8?B?S0pVMGVxNDV2MDV4SkdtWnVHQVFJSjlOWU9VaDhxOXcwcjFIVDFHVHVyRGZo?= =?utf-8?B?eFRhRnVGOUo4dmIwYmZxazQ3dnZpZFo3aHRIeVRjOExHT2wySWx3WUkxSHkv?= =?utf-8?Q?kINo3qmFGt9itaG9Z1t8zVc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 74671ba3-7779-4dcd-1131-08d9efb3049a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 12:10:40.8150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6/IYtTY4N4YBfCgkqyUHemhdy37Ljt4qW9bDGnoLOunEhj2YwkY/vW3EcWXHg3FO23i8uxFFRHDXEp2DTcI6yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4029 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/12/2022 12:36 PM, Gowrishankar Muthukrishnan wrote: > In telemetry handler for port info, there is no need to check if > eth_dev object of a port id is not null, as it had already been > evaluated once in rte_eth_dev_is_valid_port function. > > Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") > Coverity issue: 373635 > > Signed-off-by: Gowrishankar Muthukrishnan > --- > lib/ethdev/rte_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index e03e669c31..3484aa2b32 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -6465,8 +6465,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, > return -EINVAL; > > eth_dev = &rte_eth_devices[port_id]; > - if (!eth_dev) > - return -EINVAL; > > rxq_state = rte_tel_data_alloc(); > if (!rxq_state) Hi Gowrishankar, Thanks for the patch. There was already a patch for it [1] and it is merged already [2]. Updating this patch status in patchwork as rejected. [1] https://patches.dpdk.org/project/dpdk/patch/86e8c92e29214673983f4387dfc6a24338eae714.1644409051.git.wangyunjian@huawei.com/ [2] https://git.dpdk.org/dpdk/commit/?id=8b8dd4451da45ce0419521d7e29fe246a5278251