From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0DD6392 for ; Fri, 10 Jun 2022 16:38:35 +0000 (UTC) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net [192.222.136.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 08E4D660172B; Fri, 10 Jun 2022 17:38:32 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654879114; bh=hp2gpcoxc1L1t8wOVnHFtGzaBF7lMMf2WNxZjV6zYgM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=F41jVeJokGk1hhiSW1+tW6PCI1j3GAOJWAJfYoahkz5x45dk4JR4jJ+qXu5P8wNHT 3IAfU69kP4ohOwsn45pMzXodDXDNuQH61UOqQ+hJifk9GWe/uN9au8uiHfqrE/VLMM c0U21ESFIzCPrFJT9m5Iyqbd5NFQECUKGNm+oMj53FZzHwnWqA9t1tkLs3IWfklACm ZbP5ujWXI35j9SimuIbhj6pXU1a8WrJFBUgJWTDRcrd3LMP2znB4DYHnjyGuROro6M uDpBSNg3V40ET4zsMLpP7bVi2FVBJPORORz+RUsV47Ost1ChlF9nc7Sv9H/IKGLAqF YVEL81r24tCDg== Message-ID: <16e50526255d585bcd5c863755ebb423466d53ff.camel@collabora.com> Subject: Re: [PATCH v1 4/5] media: rkvdec: Re-enable H.264 error detection From: Nicolas Dufresne To: Ezequiel Garcia Cc: linux-media , Mauro Carvalho Chehab , Greg Kroah-Hartman , Collabora Kernel ML , "open list:ARM/Rockchip SoC..." , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List Date: Fri, 10 Jun 2022 12:38:24 -0400 In-Reply-To: References: <20220610125215.240539-1-nicolas.dufresne@collabora.com> <20220610125215.240539-5-nicolas.dufresne@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Le vendredi 10 juin 2022 =C3=A0 12:01 -0300, Ezequiel Garcia a =C3=A9crit= =C2=A0: > Hi Nicolas, >=20 > Great stuff! See below for some ideas how to expose errors. >=20 > On Fri, Jun 10, 2022 at 9:52 AM Nicolas Dufresne > wrote: > >=20 > > This re-enables H.264 error detection, but using the other error mode. > > In that mode, the decoder will skip over the error macro-block or > > slices and complete the decoding. As a side effect, the error status > > is not set in the interrupt status register, and instead errors are > > detected per format. Using this mode workaround the issue that the > > HW get stuck in error stated and allow reporting that some corruption > > may be present in the buffer returned to userland. > >=20 > > Signed-off-by: Nicolas Dufresne > > --- > > drivers/staging/media/rkvdec/rkvdec-h264.c | 23 +++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/staging/media/rkvdec/rkvdec-h264.c b/drivers/stagi= ng/media/rkvdec/rkvdec-h264.c > > index 55596ce6bb6e..60a89918e2c1 100644 > > --- a/drivers/staging/media/rkvdec/rkvdec-h264.c > > +++ b/drivers/staging/media/rkvdec/rkvdec-h264.c > > @@ -1175,14 +1175,15 @@ static int rkvdec_h264_run(struct rkvdec_ctx *c= tx) > >=20 > > schedule_delayed_work(&rkvdec->watchdog_work, msecs_to_jiffies(= 2000)); > >=20 > > - writel(0, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN); > > - writel(0, rkvdec->regs + RKVDEC_REG_H264_ERR_E); > > + writel(0xffffffff, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN); > > + writel(0xffffffff, rkvdec->regs + RKVDEC_REG_H264_ERR_E); > > writel(1, rkvdec->regs + RKVDEC_REG_PREF_LUMA_CACHE_COMMAND); > > writel(1, rkvdec->regs + RKVDEC_REG_PREF_CHR_CACHE_COMMAND); > >=20 > > /* Start decoding! */ > > writel(RKVDEC_INTERRUPT_DEC_E | RKVDEC_CONFIG_DEC_CLK_GATE_E | > > - RKVDEC_TIMEOUT_E | RKVDEC_BUF_EMPTY_E, > > + RKVDEC_TIMEOUT_E | RKVDEC_BUF_EMPTY_E | > > + RKVDEC_H264ORVP9_ERR_MODE, > > rkvdec->regs + RKVDEC_REG_INTERRUPT); > >=20 > > return 0; > > @@ -1196,10 +1197,26 @@ static int rkvdec_h264_try_ctrl(struct rkvdec_c= tx *ctx, struct v4l2_ctrl *ctrl) > > return 0; > > } > >=20 > > +static int rkvdec_h264_check_error_info(struct rkvdec_ctx *ctx) > > +{ > > + struct rkvdec_dev *rkvdec =3D ctx->dev; > > + int err; > > + > > + err =3D readl(rkvdec->regs + RKVDEC_REG_H264_ERRINFO_NUM); > > + if (err & RKVDEC_STRMD_DECT_ERR_FLAG) { > > + pr_debug("Decoded picture have %i/%i slices with errors= .\n", > > + RKVDEC_ERR_PKT_NUM(err), RKVDEC_SLICEDEC_NUM(e= rr)); >=20 > It's more useful friendly to just keep a counter somewhere. In the past, > we've created a user control, which has the advantage of leveraging > an existing mechanism, and already being per-fd. >=20 > See: >=20 > commit b2d3bef1aa7858b2ae5e0d01adb214121ba00b9f > "media: coda: Add a V4L2 user for control error macroblocks count". >=20 > I would drop the pr_debug, or if you think it's really useful for users > and developers, go with v4l2_dbg. In which case, how do you ensure > a corrupted stream won't flood the logs? There is no use case to make this a control, but yes, a corrupted stream ca= n flood, but isn't the point of pr_debug() that it won't show if you don't en= abled it ? As for v4l2_dbg I'm not familiar with that and its not used in this driver = for traces. I've use pr_debug for reference list tracing previously and floodin= g was not considered a problem despite being a per-frame trace. You can even out- compile these if you need to. Let me know if you have further rationale in the suggestion direction. The rationale in my coding for such trace is that if I read 1 bit of a register= , and trace the surrounding value, I can validate (as a human) that the rest of t= he register isn't complete garbage, and that I'm not basically reading a rando= m bit. Leaving the trace there, allow other developer on other variant of the= se SoC to also notice if that register becomes garbage. This is in contrast of= just telling others "trust me, I tested it". Nicolas >=20 > Thanks, > Ezequiel >=20 >=20 > > + return VB2_BUF_STATE_ERROR; > > + } > > + > > + return VB2_BUF_STATE_DONE; > > +} > > + > > const struct rkvdec_coded_fmt_ops rkvdec_h264_fmt_ops =3D { > > .adjust_fmt =3D rkvdec_h264_adjust_fmt, > > .start =3D rkvdec_h264_start, > > .stop =3D rkvdec_h264_stop, > > .run =3D rkvdec_h264_run, > > .try_ctrl =3D rkvdec_h264_try_ctrl, > > + .check_error_info =3D rkvdec_h264_check_error_info, > > }; > > -- > > 2.36.1 > >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DEAEC43334 for ; Fri, 10 Jun 2022 16:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BpwTaYffIvBlK+CM9HJ+MkjaO7m4OBavYHrquwE2OTg=; b=lzmnXROn4dCglA I0YxPzXcpzEc0k240wXKPFzok5z4xfmaG4yElQeSKapjuBTA0zYygHwh3UtavkrCb28aDzB4joVUd qx3k0hCA9Ai8oyHAjH55BW8UvTBHQnxe3evoADvLkyuLENB8fcv/7xuG1YhAdz+IoBXzZNX62eZjQ Ug93nVAw18ua9PzJ2YBFEnQotjzV6BQsW+IzM/9Kqaebh3JZMrZN01J5yegfR3UApjL3/2oUFzjyD ZEMucyNc/zCKNeaiR3LsOlv8BX1ulu8+460YpkiuNjsMKnOO8C2I0a6uoOuESOT69t5M47S8t4P2i wIFwnBSRo6Gh74ERsQLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzheg-008xlN-O0; Fri, 10 Jun 2022 16:38:38 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzhed-008xkF-Eg for linux-rockchip@lists.infradead.org; Fri, 10 Jun 2022 16:38:37 +0000 Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net [192.222.136.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 08E4D660172B; Fri, 10 Jun 2022 17:38:32 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654879114; bh=hp2gpcoxc1L1t8wOVnHFtGzaBF7lMMf2WNxZjV6zYgM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=F41jVeJokGk1hhiSW1+tW6PCI1j3GAOJWAJfYoahkz5x45dk4JR4jJ+qXu5P8wNHT 3IAfU69kP4ohOwsn45pMzXodDXDNuQH61UOqQ+hJifk9GWe/uN9au8uiHfqrE/VLMM c0U21ESFIzCPrFJT9m5Iyqbd5NFQECUKGNm+oMj53FZzHwnWqA9t1tkLs3IWfklACm ZbP5ujWXI35j9SimuIbhj6pXU1a8WrJFBUgJWTDRcrd3LMP2znB4DYHnjyGuROro6M uDpBSNg3V40ET4zsMLpP7bVi2FVBJPORORz+RUsV47Ost1ChlF9nc7Sv9H/IKGLAqF YVEL81r24tCDg== Message-ID: <16e50526255d585bcd5c863755ebb423466d53ff.camel@collabora.com> Subject: Re: [PATCH v1 4/5] media: rkvdec: Re-enable H.264 error detection From: Nicolas Dufresne To: Ezequiel Garcia Cc: linux-media , Mauro Carvalho Chehab , Greg Kroah-Hartman , Collabora Kernel ML , "open list:ARM/Rockchip SoC..." , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List Date: Fri, 10 Jun 2022 12:38:24 -0400 In-Reply-To: References: <20220610125215.240539-1-nicolas.dufresne@collabora.com> <20220610125215.240539-5-nicolas.dufresne@collabora.com> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_093835_788447_98A1449C X-CRM114-Status: GOOD ( 33.51 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org TGUgdmVuZHJlZGkgMTAganVpbiAyMDIyIMOgIDEyOjAxIC0wMzAwLCBFemVxdWllbCBHYXJjaWEg YSDDqWNyaXTCoDoKPiBIaSBOaWNvbGFzLAo+IAo+IEdyZWF0IHN0dWZmISBTZWUgYmVsb3cgZm9y IHNvbWUgaWRlYXMgaG93IHRvIGV4cG9zZSBlcnJvcnMuCj4gCj4gT24gRnJpLCBKdW4gMTAsIDIw MjIgYXQgOTo1MiBBTSBOaWNvbGFzIER1ZnJlc25lCj4gPG5pY29sYXMuZHVmcmVzbmVAY29sbGFi b3JhLmNvbT4gd3JvdGU6Cj4gPiAKPiA+IFRoaXMgcmUtZW5hYmxlcyBILjI2NCBlcnJvciBkZXRl Y3Rpb24sIGJ1dCB1c2luZyB0aGUgb3RoZXIgZXJyb3IgbW9kZS4KPiA+IEluIHRoYXQgbW9kZSwg dGhlIGRlY29kZXIgd2lsbCBza2lwIG92ZXIgdGhlIGVycm9yIG1hY3JvLWJsb2NrIG9yCj4gPiBz bGljZXMgYW5kIGNvbXBsZXRlIHRoZSBkZWNvZGluZy4gQXMgYSBzaWRlIGVmZmVjdCwgdGhlIGVy cm9yIHN0YXR1cwo+ID4gaXMgbm90IHNldCBpbiB0aGUgaW50ZXJydXB0IHN0YXR1cyByZWdpc3Rl ciwgYW5kIGluc3RlYWQgZXJyb3JzIGFyZQo+ID4gZGV0ZWN0ZWQgcGVyIGZvcm1hdC4gVXNpbmcg dGhpcyBtb2RlIHdvcmthcm91bmQgdGhlIGlzc3VlIHRoYXQgdGhlCj4gPiBIVyBnZXQgc3R1Y2sg aW4gZXJyb3Igc3RhdGVkIGFuZCBhbGxvdyByZXBvcnRpbmcgdGhhdCBzb21lIGNvcnJ1cHRpb24K PiA+IG1heSBiZSBwcmVzZW50IGluIHRoZSBidWZmZXIgcmV0dXJuZWQgdG8gdXNlcmxhbmQuCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IE5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVA Y29sbGFib3JhLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMv cmt2ZGVjLWgyNjQuYyB8IDIzICsrKysrKysrKysrKysrKysrKystLS0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMvcmt2ZGVjLWgyNjQuYyBiL2RyaXZlcnMv c3RhZ2luZy9tZWRpYS9ya3ZkZWMvcmt2ZGVjLWgyNjQuYwo+ID4gaW5kZXggNTU1OTZjZTZiYjZl Li42MGE4OTkxOGUyYzEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2 ZGVjL3JrdmRlYy1oMjY0LmMKPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMv cmt2ZGVjLWgyNjQuYwo+ID4gQEAgLTExNzUsMTQgKzExNzUsMTUgQEAgc3RhdGljIGludCBya3Zk ZWNfaDI2NF9ydW4oc3RydWN0IHJrdmRlY19jdHggKmN0eCkKPiA+IAo+ID4gICAgICAgICBzY2hl ZHVsZV9kZWxheWVkX3dvcmsoJnJrdmRlYy0+d2F0Y2hkb2dfd29yaywgbXNlY3NfdG9famlmZmll cygyMDAwKSk7Cj4gPiAKPiA+IC0gICAgICAgd3JpdGVsKDAsIHJrdmRlYy0+cmVncyArIFJLVkRF Q19SRUdfU1RSTURfRVJSX0VOKTsKPiA+IC0gICAgICAgd3JpdGVsKDAsIHJrdmRlYy0+cmVncyAr IFJLVkRFQ19SRUdfSDI2NF9FUlJfRSk7Cj4gPiArICAgICAgIHdyaXRlbCgweGZmZmZmZmZmLCBy a3ZkZWMtPnJlZ3MgKyBSS1ZERUNfUkVHX1NUUk1EX0VSUl9FTik7Cj4gPiArICAgICAgIHdyaXRl bCgweGZmZmZmZmZmLCBya3ZkZWMtPnJlZ3MgKyBSS1ZERUNfUkVHX0gyNjRfRVJSX0UpOwo+ID4g ICAgICAgICB3cml0ZWwoMSwgcmt2ZGVjLT5yZWdzICsgUktWREVDX1JFR19QUkVGX0xVTUFfQ0FD SEVfQ09NTUFORCk7Cj4gPiAgICAgICAgIHdyaXRlbCgxLCBya3ZkZWMtPnJlZ3MgKyBSS1ZERUNf UkVHX1BSRUZfQ0hSX0NBQ0hFX0NPTU1BTkQpOwo+ID4gCj4gPiAgICAgICAgIC8qIFN0YXJ0IGRl Y29kaW5nISAqLwo+ID4gICAgICAgICB3cml0ZWwoUktWREVDX0lOVEVSUlVQVF9ERUNfRSB8IFJL VkRFQ19DT05GSUdfREVDX0NMS19HQVRFX0UgfAo+ID4gLSAgICAgICAgICAgICAgUktWREVDX1RJ TUVPVVRfRSB8IFJLVkRFQ19CVUZfRU1QVFlfRSwKPiA+ICsgICAgICAgICAgICAgIFJLVkRFQ19U SU1FT1VUX0UgfCBSS1ZERUNfQlVGX0VNUFRZX0UgfAo+ID4gKyAgICAgICAgICAgICAgUktWREVD X0gyNjRPUlZQOV9FUlJfTU9ERSwKPiA+ICAgICAgICAgICAgICAgIHJrdmRlYy0+cmVncyArIFJL VkRFQ19SRUdfSU5URVJSVVBUKTsKPiA+IAo+ID4gICAgICAgICByZXR1cm4gMDsKPiA+IEBAIC0x MTk2LDEwICsxMTk3LDI2IEBAIHN0YXRpYyBpbnQgcmt2ZGVjX2gyNjRfdHJ5X2N0cmwoc3RydWN0 IHJrdmRlY19jdHggKmN0eCwgc3RydWN0IHY0bDJfY3RybCAqY3RybCkKPiA+ICAgICAgICAgcmV0 dXJuIDA7Cj4gPiAgfQo+ID4gCj4gPiArc3RhdGljIGludCBya3ZkZWNfaDI2NF9jaGVja19lcnJv cl9pbmZvKHN0cnVjdCBya3ZkZWNfY3R4ICpjdHgpCj4gPiArewo+ID4gKyAgICAgICBzdHJ1Y3Qg cmt2ZGVjX2RldiAqcmt2ZGVjID0gY3R4LT5kZXY7Cj4gPiArICAgICAgIGludCBlcnI7Cj4gPiAr Cj4gPiArICAgICAgIGVyciA9IHJlYWRsKHJrdmRlYy0+cmVncyArIFJLVkRFQ19SRUdfSDI2NF9F UlJJTkZPX05VTSk7Cj4gPiArICAgICAgIGlmIChlcnIgJiBSS1ZERUNfU1RSTURfREVDVF9FUlJf RkxBRykgewo+ID4gKyAgICAgICAgICAgICAgIHByX2RlYnVnKCJEZWNvZGVkIHBpY3R1cmUgaGF2 ZSAlaS8laSBzbGljZXMgd2l0aCBlcnJvcnMuXG4iLAo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgIFJLVkRFQ19FUlJfUEtUX05VTShlcnIpLCBSS1ZERUNfU0xJQ0VERUNfTlVNKGVycikpOwo+ IAo+IEl0J3MgbW9yZSB1c2VmdWwgZnJpZW5kbHkgdG8ganVzdCBrZWVwIGEgY291bnRlciBzb21l d2hlcmUuIEluIHRoZSBwYXN0LAo+IHdlJ3ZlIGNyZWF0ZWQgYSB1c2VyIGNvbnRyb2wsIHdoaWNo IGhhcyB0aGUgYWR2YW50YWdlIG9mIGxldmVyYWdpbmcKPiBhbiBleGlzdGluZyBtZWNoYW5pc20s IGFuZCBhbHJlYWR5IGJlaW5nIHBlci1mZC4KPiAKPiBTZWU6Cj4gCj4gY29tbWl0IGIyZDNiZWYx YWE3ODU4YjJhZTVlMGQwMWFkYjIxNDEyMWJhMDBiOWYKPiAibWVkaWE6IGNvZGE6IEFkZCBhIFY0 TDIgdXNlciBmb3IgY29udHJvbCBlcnJvciBtYWNyb2Jsb2NrcyBjb3VudCIuCj4gCj4gSSB3b3Vs ZCBkcm9wIHRoZSBwcl9kZWJ1Zywgb3IgaWYgeW91IHRoaW5rIGl0J3MgcmVhbGx5IHVzZWZ1bCBm b3IgdXNlcnMKPiBhbmQgZGV2ZWxvcGVycywgZ28gd2l0aCB2NGwyX2RiZy4gSW4gd2hpY2ggY2Fz ZSwgaG93IGRvIHlvdSBlbnN1cmUKPiBhIGNvcnJ1cHRlZCBzdHJlYW0gd29uJ3QgZmxvb2QgdGhl IGxvZ3M/CgpUaGVyZSBpcyBubyB1c2UgY2FzZSB0byBtYWtlIHRoaXMgYSBjb250cm9sLCBidXQg eWVzLCBhIGNvcnJ1cHRlZCBzdHJlYW0gY2FuCmZsb29kLCBidXQgaXNuJ3QgdGhlIHBvaW50IG9m IHByX2RlYnVnKCkgdGhhdCBpdCB3b24ndCBzaG93IGlmIHlvdSBkb24ndCBlbmFibGVkCml0ID8K CkFzIGZvciB2NGwyX2RiZyBJJ20gbm90IGZhbWlsaWFyIHdpdGggdGhhdCBhbmQgaXRzIG5vdCB1 c2VkIGluIHRoaXMgZHJpdmVyIGZvcgp0cmFjZXMuIEkndmUgdXNlIHByX2RlYnVnIGZvciByZWZl cmVuY2UgbGlzdCB0cmFjaW5nIHByZXZpb3VzbHkgYW5kIGZsb29kaW5nIHdhcwpub3QgY29uc2lk ZXJlZCBhIHByb2JsZW0gZGVzcGl0ZSBiZWluZyBhIHBlci1mcmFtZSB0cmFjZS4gWW91IGNhbiBl dmVuIG91dC0KY29tcGlsZSB0aGVzZSBpZiB5b3UgbmVlZCB0by4KCkxldCBtZSBrbm93IGlmIHlv dSBoYXZlIGZ1cnRoZXIgcmF0aW9uYWxlIGluIHRoZSBzdWdnZXN0aW9uIGRpcmVjdGlvbi4gVGhl CnJhdGlvbmFsZSBpbiBteSBjb2RpbmcgZm9yIHN1Y2ggdHJhY2UgaXMgdGhhdCBpZiBJIHJlYWQg MSBiaXQgb2YgYSByZWdpc3RlciwgYW5kCnRyYWNlIHRoZSBzdXJyb3VuZGluZyB2YWx1ZSwgSSBj YW4gdmFsaWRhdGUgKGFzIGEgaHVtYW4pIHRoYXQgdGhlIHJlc3Qgb2YgdGhlCnJlZ2lzdGVyIGlz bid0IGNvbXBsZXRlIGdhcmJhZ2UsIGFuZCB0aGF0IEknbSBub3QgYmFzaWNhbGx5IHJlYWRpbmcg YSByYW5kb20KYml0LiBMZWF2aW5nIHRoZSB0cmFjZSB0aGVyZSwgYWxsb3cgb3RoZXIgZGV2ZWxv cGVyIG9uIG90aGVyIHZhcmlhbnQgb2YgdGhlc2UKU29DIHRvIGFsc28gbm90aWNlIGlmIHRoYXQg cmVnaXN0ZXIgYmVjb21lcyBnYXJiYWdlLiBUaGlzIGlzIGluIGNvbnRyYXN0IG9mIGp1c3QKdGVs bGluZyBvdGhlcnMgInRydXN0IG1lLCBJIHRlc3RlZCBpdCIuCgpOaWNvbGFzCgo+IAo+IFRoYW5r cywKPiBFemVxdWllbAo+IAo+IAo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBWQjJfQlVGX1NU QVRFX0VSUk9SOwo+ID4gKyAgICAgICB9Cj4gPiArCj4gPiArICAgICAgIHJldHVybiBWQjJfQlVG X1NUQVRFX0RPTkU7Cj4gPiArfQo+ID4gKwo+ID4gIGNvbnN0IHN0cnVjdCBya3ZkZWNfY29kZWRf Zm10X29wcyBya3ZkZWNfaDI2NF9mbXRfb3BzID0gewo+ID4gICAgICAgICAuYWRqdXN0X2ZtdCA9 IHJrdmRlY19oMjY0X2FkanVzdF9mbXQsCj4gPiAgICAgICAgIC5zdGFydCA9IHJrdmRlY19oMjY0 X3N0YXJ0LAo+ID4gICAgICAgICAuc3RvcCA9IHJrdmRlY19oMjY0X3N0b3AsCj4gPiAgICAgICAg IC5ydW4gPSBya3ZkZWNfaDI2NF9ydW4sCj4gPiAgICAgICAgIC50cnlfY3RybCA9IHJrdmRlY19o MjY0X3RyeV9jdHJsLAo+ID4gKyAgICAgICAuY2hlY2tfZXJyb3JfaW5mbyA9IHJrdmRlY19oMjY0 X2NoZWNrX2Vycm9yX2luZm8sCj4gPiAgfTsKPiA+IC0tCj4gPiAyLjM2LjEKPiA+IAoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlw IG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK