From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 0/9] tests, python: prepare to expand usage of test venv
Date: Wed, 1 Jun 2022 12:06:32 +0200 [thread overview]
Message-ID: <16e6c284-949f-d778-8829-e6c50e533272@redhat.com> (raw)
In-Reply-To: <CAFn=p-bdvwdJY=cKZk9Q_N6CYj+Suetworw2Xa+3kc4bf_4Fug@mail.gmail.com>
On 5/26/22 16:34, John Snow wrote:
> (1) If check is engaged without running check-venv first and iotests
> creates its own venv, the python binary it uses will be whichever one is
> your system default, not necessarily the one you configured your build with.
>
> This is reasonable behavior IMO, but if you later run "make check",
> there's no guarantee that Make will re-make the venv with the correct
> python binary That's a subtle landmine.
Yup, that's also a reason to make initial venv creation part of
configure. I consider that on the same level as running Meson and
setting up git submodules.
> (2) Similarly, if the venv requirements.txt (or python/setup.cfg)
> change, iotests doesn't have the logic to notice it ought to re-make the
> venv. Only the makefile does. However, at least in this case, the
> makefile is guaranteed to notice if/when we run "check block" again. The
> odds of these files changing for most people who aren't *me* are pretty
> low, so it may not really come up much. Still, it's not bullet-proof.
Yeah, this is fine. Compare it with e.g. running clang-query: it needs
a "make" first to rebuild compile_commands.json.
Paolo
> (Bonus not-at-all-subtle problem) I need to remove iotest 297, otherwise
> iotests under a venv that doesn't install mypy/pylint will never run. I
> discussed this upstream recently w/ Kevin, but my series to address it
> isn't ready yet. (Just pre-emptively pointing it out to say I'm aware of
> it!)
next prev parent reply other threads:[~2022-06-01 10:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 0:09 [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-05-26 0:09 ` [PATCH 1/9] python: update for mypy 0.950 John Snow
2022-05-26 0:09 ` [PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile John Snow
2022-05-26 0:09 ` [PATCH 3/9] tests: use python3 as the python executable name John Snow
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 4/9] tests: silence pip upgrade warnings during venv creation John Snow
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 5/9] tests: add quiet-venv-pip macro John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 14:17 ` John Snow
2022-05-26 19:54 ` Paolo Bonzini
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 6/9] tests: install "qemu" namespace package into venv John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 7/9] tests: use tests/venv to run basevm.py-based scripts John Snow
2022-05-26 0:09 ` [PATCH 8/9] tests: add python3-venv to debian10.docker John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-30 7:33 ` Thomas Huth
2022-05-31 18:28 ` John Snow
2022-06-01 7:29 ` Thomas Huth
2022-06-02 17:44 ` John Snow
2022-05-26 0:09 ` [PATCH 9/9] tests: run 'device-crash-test' from tests/venv John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-26 14:14 ` John Snow
2022-05-26 14:34 ` [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-06-01 10:06 ` Paolo Bonzini [this message]
2022-05-27 14:27 ` John Snow
2022-06-01 10:06 ` Paolo Bonzini
2022-06-02 17:43 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e6c284-949f-d778-8829-e6c50e533272@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.