From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3BFC2D0DA for ; Thu, 26 Dec 2019 09:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1338D2075E for ; Thu, 26 Dec 2019 09:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="T49Hwalm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbfLZJr1 (ORCPT ); Thu, 26 Dec 2019 04:47:27 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52382 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbfLZJrZ (ORCPT ); Thu, 26 Dec 2019 04:47:25 -0500 Received: by mail-wm1-f65.google.com with SMTP id p9so5548721wmc.2 for ; Thu, 26 Dec 2019 01:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=fes1e17DjoybcHkZ3ppriXwbGN3pvc12W7QvoiRRzVg=; b=T49Hwalmr/bx7Mup/eAfMwH7e+v3fLjLMmlU1pyvn8yuLfBoCvz4ja2Vynu23NVorU L4vnwr+FmuwKarExYkms1yh4mRUBT1M09SVJgtiDCxOuuVC/h8a/T/ESNa09oo03e4vi 1oJaGadD1zadC7UsOTyTkznFyj+Vu7bsTrUK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=fes1e17DjoybcHkZ3ppriXwbGN3pvc12W7QvoiRRzVg=; b=OtMPqdIPJbDeoT99Zo4Az+4pBE2URhl3RLqIzIZ1T6vlbkgrJ1cyWWQ44RTh8x7NSh jTJ1tjkbgd3hPKBpPMntTV+aoeKrIiqRhh5TqQQKo1TVIiGNYgDrmKn2o7Vc+Kz/zb2M IV44H9LTgGSd7veJNIrnppWJ2X0wnnVF3o+mmGjTYpO07m0X4IpHcCjoMDlY29EIeGgt /LuJ25/wPGnEfDb4U0ihw8gIXr2eKTj5K/wKVWj3JYGwDiNsw3RmeTzo9y4iKnOWEwwM aRFDkEJNMuwCvkteSDEaeI0H7Gr2vi7rTZWUmDXi8kdAr/Owb7nfiQIFknucpkcTtLU+ SR6g== X-Gm-Message-State: APjAAAVprv9zS/3mMqSpEHyNPkhpB4pJLFasrQ2P1hpSKLgpC9gTCfO1 2PHXPMNB8pujqW4YKOJfWDd9Nw== X-Google-Smtp-Source: APXvYqyc7OhIVZzeNAMoAEb/5fAFhzjgh+m1mZdckHnOmlU+mWH/dr+prELI2ptTmuJrzKZR8soZbg== X-Received: by 2002:a7b:c957:: with SMTP id i23mr13388410wml.49.1577353642157; Thu, 26 Dec 2019 01:47:22 -0800 (PST) Received: from [192.168.178.38] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id a14sm32456308wrx.81.2019.12.26.01.47.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Dec 2019 01:47:21 -0800 (PST) From: Arend Van Spriel To: "Jean-Philippe Brucker" , , , , , CC: , , , , , , , Date: Thu, 26 Dec 2019 10:47:18 +0100 Message-ID: <16f419a7070.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20191226092033.12600-1-jean-philippe@linaro.org> References: <20191226092033.12600-1-jean-philippe@linaro.org> User-Agent: AquaMail/1.22.0-1511 (build: 102200004) Subject: Re: [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On December 26, 2019 10:23:41 AM Jean-Philippe Brucker wrote: > Commit 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling > brcmf_bus_started()") changed the initialization order of the brcmfmac > SDIO driver. Unfortunately since brcmf_sdiod_intr_register() is now > called before the sdiodev->bus_if initialization, it reads the wrong > chip ID and fails to initialize the GPIO on brcm43362. Thus the chip > cannot send interrupts and fails to probe: > > [ 12.517023] brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout > [ 12.531214] ieee80211 phy0: brcmf_bus_started: failed: -110 > [ 12.536976] ieee80211 phy0: brcmf_attach: dongle is not responding: err=-110 > [ 12.566467] brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed > > Initialize the bus interface earlier to ensure that > brcmf_sdiod_intr_register() properly sets up the OOB interrupt. > > BugLink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908438 > Fixes: 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling > brcmf_bus_started()") Reviewed-by: Arend van Spriel > Signed-off-by: Jean-Philippe Brucker > --- > A workaround [1] disabling the OOB interrupt is being discussed. It > works for me, but this patch fixes the wifi problem on my cubietruck. I missed that one. Too bad it was not sent to linux-wireless as well. Good find here. I did see another patch dealing with the OOB interrupt on Nvidia Tegra. Now I wonder if this is the same issue. Regards, Arend > [1] > https://lore.kernel.org/linux-arm-kernel/20180930150927.12076-1-hdegoede@redhat.com/ > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-)