From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbdHJNC6 (ORCPT ); Thu, 10 Aug 2017 09:02:58 -0400 Received: from mout.web.de ([212.227.17.12]:60197 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091AbdHJNCx (ORCPT ); Thu, 10 Aug 2017 09:02:53 -0400 Subject: [PATCH 2/5] ASoC: dapm: Improve a size determination in two functions From: SF Markus Elfring To: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <16fbe262-3b6b-2395-be43-285dc2ff5420@users.sourceforge.net> Date: Thu, 10 Aug 2017 15:02:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:EzQ8bvd6hunNlGm0CNjZjVgQOt0O9lZrR5Wiy85JcSkho+c9lF+ csKVUqXujFOrehaDXjJVHSrEYNbXqnshc0vqr7evYTLKu/EjBUIrWvKIqyG7iOrh43YVK+y XsoYmONkwlSWHmHAL/P27oEJMIisSs62IS7vruIPxlhLDhx7pbbt3U442DoBcv2XKxjWl2c QOUwjzR5FPUHtmlRwVRYw== X-UI-Out-Filterresults: notjunk:1;V01:K0:yDBfDdhczgc=:N4wS7o34eKvl495pmXk2IK +gPz7yNap5hJDozOxI0MtwISajE9x0iUP/H09/3AFs6nsRbiLsVEG//dQy9t+Tn8nMxUBnWll L92e8ncp/9qNbs+9ZDBE6Xr99hmxqT1V2/2fBVlvPZ9cERW4rdkqJPniv0A8Bcma/Gt5OUg+K wXJX9Vj2qbYNdR/Fj3Rp1B0d+vXPxSdesjBt8K81hrVhHuaxPMab92IuJ9m6p98J1+0OaG3Bz xwRlV/NbULt1jqyfiyEfd2EvvL9ir2ktTv3eubQj+5Wl6TU0qJSm1yXiohlA2r93siTsUvlUS VFMY3OHMoPf97noAXj+QAc61o5PULaOM1NdNA7xOyY0oBHTIc1GvK4040eDfffbUC67MoPVFq 4BuDf6pOlvXS4LiQ+YAp+arDG0RtPa5cOuzsS9tuG9xvZqahCsgoBiL0Thsla6MuXcDOx0+Mj /plR95weZQj0gdl5OvUJI0vsJX4wCG/NW3024wuH1YVoxRrlze4wXq22i3AaO3JwBWdJdkB6O uwPdF1oXoyKbRmYh9QJ37tXfnx1ubfjMiwwJZTBFtJ7EoFbEen/tMGClWtDmcyOuDwboNYhLa 5GfJBnyx35SQAarUlNblcW3czt7WV3BUJMbZJ0qa7AzVjDsDvnVXza2/Fyb851E6mNmDyA8nm hmRw/aqWAbUI5gGXU561WM0Z2vH9v7BRXtukWUacIL9Gz4o/AXDZBoanSTbCHpehcoT7dVlng 8CzJ/JKT2IRRWMPMFCGNR3+EvcbHlgv396rC/MtCvH7ppYu7RB7yLPsdiP2xnzFsQq9jqz0wK oNWaeKqH5kdf6k99xXzRbIhLmil26asQv0UQY1X72A2WEX6Nw0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 10 Aug 2017 14:15:47 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- sound/soc/soc-dapm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 3adb914bc009..e673961210e6 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2651,7 +2651,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm, if (ret) return ret; - path = kzalloc(sizeof(struct snd_soc_dapm_path), GFP_KERNEL); + path = kzalloc(sizeof(*path), GFP_KERNEL); if (!path) return -ENOMEM; @@ -3859,10 +3859,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, } kcontrol_dai_link[0].private_value = private_value; /* duplicate kcontrol_dai_link on heap so that memory persists */ - template.kcontrol_news = - devm_kmemdup(card->dev, &kcontrol_dai_link[0], - sizeof(struct snd_kcontrol_new), - GFP_KERNEL); + template.kcontrol_news = devm_kmemdup(card->dev, &kcontrol_dai_link[0], + sizeof(*template.kcontrol_news), + GFP_KERNEL); if (!template.kcontrol_news) { ret = -ENOMEM; goto outfree_private_value; -- 2.14.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 10 Aug 2017 13:02:35 +0000 Subject: [PATCH 2/5] ASoC: dapm: Improve a size determination in two functions Message-Id: <16fbe262-3b6b-2395-be43-285dc2ff5420@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Thu, 10 Aug 2017 14:15:47 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- sound/soc/soc-dapm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 3adb914bc009..e673961210e6 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2651,7 +2651,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm, if (ret) return ret; - path = kzalloc(sizeof(struct snd_soc_dapm_path), GFP_KERNEL); + path = kzalloc(sizeof(*path), GFP_KERNEL); if (!path) return -ENOMEM; @@ -3859,10 +3859,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, } kcontrol_dai_link[0].private_value = private_value; /* duplicate kcontrol_dai_link on heap so that memory persists */ - template.kcontrol_news - devm_kmemdup(card->dev, &kcontrol_dai_link[0], - sizeof(struct snd_kcontrol_new), - GFP_KERNEL); + template.kcontrol_news = devm_kmemdup(card->dev, &kcontrol_dai_link[0], + sizeof(*template.kcontrol_news), + GFP_KERNEL); if (!template.kcontrol_news) { ret = -ENOMEM; goto outfree_private_value; -- 2.14.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 2/5] ASoC: dapm: Improve a size determination in two functions Date: Thu, 10 Aug 2017 15:02:35 +0200 Message-ID: <16fbe262-3b6b-2395-be43-285dc2ff5420@users.sourceforge.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de (mout.web.de [212.227.17.12]) by alsa0.perex.cz (Postfix) with ESMTP id DCEE5267572 for ; Thu, 10 Aug 2017 15:02:42 +0200 (CEST) In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: kernel-janitors@vger.kernel.org, LKML List-Id: alsa-devel@alsa-project.org From: Markus Elfring Date: Thu, 10 Aug 2017 14:15:47 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- sound/soc/soc-dapm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 3adb914bc009..e673961210e6 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2651,7 +2651,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm, if (ret) return ret; - path = kzalloc(sizeof(struct snd_soc_dapm_path), GFP_KERNEL); + path = kzalloc(sizeof(*path), GFP_KERNEL); if (!path) return -ENOMEM; @@ -3859,10 +3859,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, } kcontrol_dai_link[0].private_value = private_value; /* duplicate kcontrol_dai_link on heap so that memory persists */ - template.kcontrol_news = - devm_kmemdup(card->dev, &kcontrol_dai_link[0], - sizeof(struct snd_kcontrol_new), - GFP_KERNEL); + template.kcontrol_news = devm_kmemdup(card->dev, &kcontrol_dai_link[0], + sizeof(*template.kcontrol_news), + GFP_KERNEL); if (!template.kcontrol_news) { ret = -ENOMEM; goto outfree_private_value; -- 2.14.0