From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: Dave Chinner <dchinner@redhat.com>, linux-xfs@vger.kernel.org
Subject: [PATCHSET v28.0 0/5] xfs: online repair of AG btrees
Date: Fri, 24 Nov 2023 15:45:35 -0800 [thread overview]
Message-ID: <170086926983.2770967.13303859275299344660.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <20231124233940.GK36190@frogsfrogsfrogs>
Hi all,
Now that we've spent a lot of time reworking common code in online fsck,
we're ready to start rebuilding the AG space btrees. This series
implements repair functions for the free space, inode, and refcount
btrees. Rebuilding the reverse mapping btree is much more intense and
is left for a subsequent patchset. The fstests counterpart of this
patchset implements stress testing of repair.
If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.
This has been running on the djcloud for months with no problems. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-ag-btrees
xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=repair-ag-btrees
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=repair-ag-btrees
---
fs/xfs/Makefile | 3
fs/xfs/libxfs/xfs_ag.h | 10
fs/xfs/libxfs/xfs_ag_resv.c | 2
fs/xfs/libxfs/xfs_alloc.c | 18 -
fs/xfs/libxfs/xfs_alloc.h | 2
fs/xfs/libxfs/xfs_alloc_btree.c | 13 -
fs/xfs/libxfs/xfs_btree.c | 26 +
fs/xfs/libxfs/xfs_btree.h | 2
fs/xfs/libxfs/xfs_ialloc.c | 41 +-
fs/xfs/libxfs/xfs_ialloc.h | 3
fs/xfs/libxfs/xfs_refcount.c | 18 -
fs/xfs/libxfs/xfs_refcount.h | 2
fs/xfs/libxfs/xfs_refcount_btree.c | 13 -
fs/xfs/libxfs/xfs_types.h | 7
fs/xfs/scrub/agheader_repair.c | 18 -
fs/xfs/scrub/alloc.c | 16 +
fs/xfs/scrub/alloc_repair.c | 914 ++++++++++++++++++++++++++++++++++++
fs/xfs/scrub/bitmap.c | 404 +++++++++++++---
fs/xfs/scrub/bitmap.h | 70 ++-
fs/xfs/scrub/common.c | 1
fs/xfs/scrub/common.h | 19 +
fs/xfs/scrub/ialloc_repair.c | 874 ++++++++++++++++++++++++++++++++++
fs/xfs/scrub/newbt.c | 48 ++
fs/xfs/scrub/newbt.h | 6
fs/xfs/scrub/reap.c | 5
fs/xfs/scrub/refcount_repair.c | 793 +++++++++++++++++++++++++++++++
fs/xfs/scrub/repair.c | 128 +++++
fs/xfs/scrub/repair.h | 43 ++
fs/xfs/scrub/scrub.c | 22 +
fs/xfs/scrub/scrub.h | 9
fs/xfs/scrub/trace.h | 112 +++-
fs/xfs/scrub/xfarray.h | 22 +
fs/xfs/xfs_extent_busy.c | 13 +
fs/xfs/xfs_extent_busy.h | 2
34 files changed, 3493 insertions(+), 186 deletions(-)
create mode 100644 fs/xfs/scrub/alloc_repair.c
create mode 100644 fs/xfs/scrub/ialloc_repair.c
create mode 100644 fs/xfs/scrub/refcount_repair.c
next prev parent reply other threads:[~2023-11-24 23:45 UTC|newest]
Thread overview: 151+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 23:39 [MEGAPATCHSET v28] xfs: online repair, second part of part 1 Darrick J. Wong
2023-11-24 23:44 ` [PATCHSET v28.0 0/1] xfs: prevent livelocks in xchk_iget Darrick J. Wong
2023-11-24 23:46 ` [PATCH 1/1] xfs: make xchk_iget safer in the presence of corrupt inode btrees Darrick J. Wong
2023-11-25 4:57 ` Christoph Hellwig
2023-11-27 21:55 ` Darrick J. Wong
2023-11-24 23:45 ` [PATCHSET v28.0 0/7] xfs: reserve disk space for online repairs Darrick J. Wong
2023-11-24 23:47 ` [PATCH 1/7] xfs: don't append work items to logged xfs_defer_pending objects Darrick J. Wong
2023-11-25 5:04 ` Christoph Hellwig
2023-11-24 23:47 ` [PATCH 2/7] xfs: allow pausing of pending deferred work items Darrick J. Wong
2023-11-25 5:05 ` Christoph Hellwig
2023-11-24 23:47 ` [PATCH 3/7] xfs: remove __xfs_free_extent_later Darrick J. Wong
2023-11-25 5:05 ` Christoph Hellwig
2023-11-24 23:47 ` [PATCH 4/7] xfs: automatic freeing of freshly allocated unwritten space Darrick J. Wong
2023-11-25 5:06 ` Christoph Hellwig
2023-11-24 23:48 ` [PATCH 5/7] xfs: implement block reservation accounting for btrees we're staging Darrick J. Wong
2023-11-26 13:14 ` Christoph Hellwig
2023-11-27 22:34 ` Darrick J. Wong
2023-11-28 5:41 ` Christoph Hellwig
2023-11-28 17:02 ` Darrick J. Wong
2023-11-24 23:48 ` [PATCH 6/7] xfs: log EFIs for all btree blocks being used to stage a btree Darrick J. Wong
2023-11-26 13:15 ` Christoph Hellwig
2023-11-24 23:48 ` [PATCH 7/7] xfs: force small EFIs for reaping btree extents Darrick J. Wong
2023-11-25 5:13 ` Christoph Hellwig
2023-11-27 22:46 ` Darrick J. Wong
2023-11-24 23:45 ` [PATCHSET v28.0 0/4] xfs: prepare repair for bulk loading Darrick J. Wong
2023-11-24 23:48 ` [PATCH 1/4] xfs: force all buffers to be written during btree bulk load Darrick J. Wong
2023-11-25 5:49 ` Christoph Hellwig
2023-11-28 1:50 ` Darrick J. Wong
2023-11-28 7:13 ` Christoph Hellwig
2023-11-28 15:18 ` Christoph Hellwig
2023-11-28 17:07 ` Darrick J. Wong
2023-11-30 4:33 ` Christoph Hellwig
2023-11-24 23:49 ` [PATCH 2/4] xfs: add debug knobs to control btree bulk load slack factors Darrick J. Wong
2023-11-25 5:50 ` Christoph Hellwig
2023-11-28 1:44 ` Darrick J. Wong
2023-11-28 5:42 ` Christoph Hellwig
2023-11-28 17:07 ` Darrick J. Wong
2023-11-24 23:49 ` [PATCH 3/4] xfs: move btree bulkload record initialization to ->get_record implementations Darrick J. Wong
2023-11-25 5:51 ` Christoph Hellwig
2023-11-24 23:49 ` [PATCH 4/4] xfs: constrain dirty buffers while formatting a staged btree Darrick J. Wong
2023-11-25 5:53 ` Christoph Hellwig
2023-11-27 22:56 ` Darrick J. Wong
2023-11-28 20:11 ` Darrick J. Wong
2023-11-29 5:50 ` Christoph Hellwig
2023-11-29 5:57 ` Darrick J. Wong
2023-11-24 23:45 ` Darrick J. Wong [this message]
2023-11-24 23:50 ` [PATCH 1/5] xfs: create separate structures and code for u32 bitmaps Darrick J. Wong
2023-11-25 5:57 ` Christoph Hellwig
2023-11-28 1:34 ` Darrick J. Wong
2023-11-28 5:43 ` Christoph Hellwig
2023-11-24 23:50 ` [PATCH 2/5] xfs: roll the scrub transaction after completing a repair Darrick J. Wong
2023-11-25 6:05 ` Christoph Hellwig
2023-11-28 1:29 ` Darrick J. Wong
2023-11-24 23:50 ` [PATCH 3/5] xfs: repair free space btrees Darrick J. Wong
2023-11-25 6:11 ` Christoph Hellwig
2023-11-28 1:05 ` Darrick J. Wong
2023-11-28 15:10 ` Christoph Hellwig
2023-11-28 21:13 ` Darrick J. Wong
2023-11-29 5:56 ` Christoph Hellwig
2023-11-29 6:18 ` Darrick J. Wong
2023-11-29 6:24 ` Christoph Hellwig
2023-11-29 6:26 ` Darrick J. Wong
2023-11-24 23:50 ` [PATCH 4/5] xfs: repair inode btrees Darrick J. Wong
2023-11-25 6:12 ` Christoph Hellwig
2023-11-28 1:09 ` Darrick J. Wong
2023-11-28 15:57 ` Christoph Hellwig
2023-11-28 21:37 ` Darrick J. Wong
2023-11-24 23:51 ` [PATCH 5/5] xfs: repair refcount btrees Darrick J. Wong
2023-11-28 16:07 ` Christoph Hellwig
2023-11-24 23:45 ` [PATCHSET v28.0 0/7] xfs: online repair of inodes and forks Darrick J. Wong
2023-11-24 23:51 ` [PATCH 1/7] xfs: disable online repair quota helpers when quota not enabled Darrick J. Wong
2023-11-25 6:13 ` Christoph Hellwig
2023-11-24 23:51 ` [PATCH 2/7] xfs: try to attach dquots to files before repairing them Darrick J. Wong
2023-11-25 6:14 ` Christoph Hellwig
2023-11-24 23:51 ` [PATCH 3/7] xfs: repair inode records Darrick J. Wong
2023-11-28 17:08 ` Christoph Hellwig
2023-11-28 23:08 ` Darrick J. Wong
2023-11-29 6:02 ` Christoph Hellwig
2023-12-05 23:08 ` Darrick J. Wong
2023-12-06 5:16 ` Christoph Hellwig
2023-11-24 23:52 ` [PATCH 4/7] xfs: zap broken inode forks Darrick J. Wong
2023-11-30 4:44 ` Christoph Hellwig
2023-11-30 21:08 ` Darrick J. Wong
2023-12-04 4:39 ` Christoph Hellwig
2023-12-04 20:43 ` Darrick J. Wong
2023-12-05 4:28 ` Christoph Hellwig
2023-11-24 23:52 ` [PATCH 5/7] xfs: abort directory parent scrub scans if we encounter a zapped directory Darrick J. Wong
2023-11-30 4:47 ` Christoph Hellwig
2023-11-30 21:37 ` Darrick J. Wong
2023-12-04 4:41 ` Christoph Hellwig
2023-12-04 20:44 ` Darrick J. Wong
2023-11-24 23:52 ` [PATCH 6/7] xfs: skip the rmapbt search on an empty attr fork unless we know it was zapped Darrick J. Wong
2023-11-24 23:52 ` [PATCH 7/7] xfs: repair obviously broken inode modes Darrick J. Wong
2023-11-30 4:49 ` Christoph Hellwig
2023-11-30 21:18 ` Darrick J. Wong
2023-12-04 4:42 ` Christoph Hellwig
2023-11-24 23:46 ` [PATCHSET v28.0 0/5] xfs: online repair of file fork mappings Darrick J. Wong
2023-11-24 23:53 ` [PATCH 1/5] xfs: reintroduce reaping of file metadata blocks to xrep_reap_extents Darrick J. Wong
2023-11-30 4:53 ` Christoph Hellwig
2023-11-30 21:48 ` Darrick J. Wong
2023-12-04 4:42 ` Christoph Hellwig
2023-11-24 23:53 ` [PATCH 2/5] xfs: repair inode fork block mapping data structures Darrick J. Wong
2023-11-30 5:07 ` Christoph Hellwig
2023-12-01 1:38 ` Darrick J. Wong
2023-11-24 23:53 ` [PATCH 3/5] xfs: refactor repair forcing tests into a repair.c helper Darrick J. Wong
2023-11-28 14:20 ` Christoph Hellwig
2023-11-29 5:42 ` Darrick J. Wong
2023-11-29 6:03 ` Christoph Hellwig
2023-11-24 23:53 ` [PATCH 4/5] xfs: create a ranged query function for refcount btrees Darrick J. Wong
2023-11-28 13:59 ` Christoph Hellwig
2023-11-24 23:54 ` [PATCH 5/5] xfs: repair problems in CoW forks Darrick J. Wong
2023-11-30 5:10 ` Christoph Hellwig
2023-11-24 23:46 ` [PATCHSET v28.0 0/6] xfs: online repair of rt bitmap file Darrick J. Wong
2023-11-24 23:54 ` [PATCH 1/6] xfs: check rt bitmap file geometry more thoroughly Darrick J. Wong
2023-11-28 14:04 ` Christoph Hellwig
2023-11-28 23:27 ` Darrick J. Wong
2023-11-29 6:05 ` Christoph Hellwig
2023-11-29 6:20 ` Darrick J. Wong
2023-11-24 23:54 ` [PATCH 2/6] xfs: check rt summary " Darrick J. Wong
2023-11-28 14:05 ` Christoph Hellwig
2023-11-28 23:30 ` Darrick J. Wong
2023-11-29 1:23 ` Darrick J. Wong
2023-11-29 6:05 ` Christoph Hellwig
2023-11-29 6:21 ` Darrick J. Wong
2023-11-29 6:23 ` Christoph Hellwig
2023-11-30 0:10 ` Darrick J. Wong
2023-11-24 23:54 ` [PATCH 3/6] xfs: always check the rtbitmap and rtsummary files Darrick J. Wong
2023-11-28 14:06 ` Christoph Hellwig
2023-11-24 23:55 ` [PATCH 4/6] xfs: repair the inode core and forks of a metadata inode Darrick J. Wong
2023-11-30 5:12 ` Christoph Hellwig
2023-11-24 23:55 ` [PATCH 5/6] xfs: create a new inode fork block unmap helper Darrick J. Wong
2023-11-25 6:17 ` Christoph Hellwig
2023-11-24 23:55 ` [PATCH 6/6] xfs: online repair of realtime bitmaps Darrick J. Wong
2023-11-30 5:16 ` Christoph Hellwig
2023-11-24 23:46 ` [PATCHSET v28.0 0/5] xfs: online repair of quota and rt metadata files Darrick J. Wong
2023-11-24 23:56 ` [PATCH 1/5] xfs: check the ondisk space mapping behind a dquot Darrick J. Wong
2023-11-30 5:17 ` Christoph Hellwig
2023-11-24 23:56 ` [PATCH 2/5] xfs: check dquot resource timers Darrick J. Wong
2023-11-30 5:17 ` Christoph Hellwig
2023-11-24 23:56 ` [PATCH 3/5] xfs: pull xfs_qm_dqiterate back into scrub Darrick J. Wong
2023-11-30 5:22 ` Christoph Hellwig
2023-11-24 23:56 ` [PATCH 4/5] xfs: improve dquot iteration for scrub Darrick J. Wong
2023-11-30 5:25 ` Christoph Hellwig
2023-11-24 23:57 ` [PATCH 5/5] xfs: repair quotas Darrick J. Wong
2023-11-30 5:33 ` Christoph Hellwig
2023-11-30 22:10 ` Darrick J. Wong
2023-12-04 4:48 ` Christoph Hellwig
2023-12-04 20:52 ` Darrick J. Wong
2023-12-05 4:27 ` Christoph Hellwig
2023-12-05 5:20 ` Darrick J. Wong
2023-12-04 4:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170086926983.2770967.13303859275299344660.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.