From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: allow exec-env specific targets
Date: Tue, 06 Jun 2017 11:11:22 +0200
Message-ID: <1701124.bcg6lUXj3m@xps>
References: <20170606063650.31434-1-jerin.jacob@caviumnetworks.com>
 <20170606075042.GA10303@jerin> <20170606090527.GB25773@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5A01C152A
 for <dev@dpdk.org>; Tue,  6 Jun 2017 11:11:24 +0200 (CEST)
In-Reply-To: <20170606090527.GB25773@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/06/2017 11:05, Jerin Jacob:
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/06/2017 09:02, Jerin Jacob:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Please explain how it can help with a real example.
> > > > 
> > > > We are evaluating on running DPDK on a nonstandard execution environment like
> > > > bare metal where I would to keep all my execution environment specific
> > > > change at following location. So that I can easy move around different
> > > > version of DPDK without merge conflict.
> > > > 
> > > > $(RTE_SDK)mk/exec-env/my-exec-env
> > > > $(RTE_SDK)lib/librte_eal/my-exec-env
> > > > 
> > > > I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk,
> > > > solves the same purpose.
> > > 
> > > I do not understand.
> > > If you want to add a new environment, why not just adding it?
> > 
> > I do not understand it either. In exiting makefile infrastructure,
> > How do you add an exec environment specific target(s) with out changing
> > the common code?
> 
> As disucssed in IRC, I will send the v2 with following changes,
> - Change mk/exec-env/$(RTE_EXEC_ENV)/rte.extra.mk to
> mk/exec-env/$(RTE_EXEC_ENV)/rte.custom.mk
> - Remove empty files and include through -include

It will help defining some new local environments.
However, in the general case, it is better to upstream environment changes
and make everybody able to use it.