From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] service: fix parameter type
Date: Wed, 27 Mar 2019 10:52:39 +0100
Message-ID: <1705677.IYcAMfH6DV@xps>
References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com>
 <1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 189EE5B38
 for <dev@dpdk.org>; Wed, 27 Mar 2019 10:52:42 +0100 (CET)
In-Reply-To: <1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/02/2019 11:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>=20
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>=20
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
>  int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
> -		uint32_t *attr_value);
> +		uint64_t *attr_value);

I'm seeing this error:
app/test/test_service_cores.c:265:8: error:
passing argument 3 of =E2=80=98rte_service_attr_get=E2=80=99 from incompati=
ble pointer type

> --- a/doc/guides/rel_notes/release_19_05.rst
> +++ b/doc/guides/rel_notes/release_19_05.rst
> -     librte_eal.so.9
> +    +librte_eal.so.10

A space is missing after the +