From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD227C0651F for ; Thu, 4 Jul 2019 16:52:52 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 59443218A3 for ; Thu, 4 Jul 2019 16:52:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="o6wG35qk"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ib4gRR4H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59443218A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDB652BE3; Thu, 4 Jul 2019 18:52:50 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 140B9F04 for ; Thu, 4 Jul 2019 18:52:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 983E521FB5; Thu, 4 Jul 2019 12:52:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 12:52:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gN5Su3SJXG3ZMEmk/vPPizTZMO7Z7KBBpR46UOnnZPI=; b=o6wG35qkpwDP 120nwV05IU4qBO0Cie5atHub++5wyFXqJ/DD8qQMZ+uC3z7JURHrvUsXjzuRV+Hf dMwivD1uWQGxRzI7Bpg5sQIoYwEI+tR1UI43AFRDCdsjYeXcZZLcM37cvzg0z689 4H4d89eyzVxApgav0cUGP+upQkZexw4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=gN5Su3SJXG3ZMEmk/vPPizTZMO7Z7KBBpR46UOnnZ PI=; b=ib4gRR4HRs4/egUyg4ws9hyiY48qUYudW3RKdh/cQRFHefY2POlHT1xqb 6dAGW/M75EoDiNzKNdYZbvxRw9/pGRhaAaH8xl+f2GkaiOlrSMkLw5ovKkn4AL27 CJ0El1ywpiABBuSminBlhEoMSun+fTrmdJgp70ZphAuE9F+HY/0+O3zTDR5k07h3 1D+sC9cckHOurcIYNeJzKQFX+7rpI9I9WSQVmday1PrJ8rg8Zbkov6P5GPSuHSaC PCCaPkJi8okkgegglkwsJBqgR1x/WOQ14g0+pyhwRGf/4upVj2TqMMKqOuJnn2C1 udoVtM3TPWYbS/m42xwLBx+0Fq7gw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 282958005C; Thu, 4 Jul 2019 12:52:48 -0400 (EDT) From: Thomas Monjalon To: Sunil Kumar Kori Cc: dev@dpdk.org, "Ananyev, Konstantin" , jerinj@marvell.com Date: Thu, 04 Jul 2019 18:52:47 +0200 Message-ID: <1706997.HcbFlGSI5x@xps> In-Reply-To: <1761996.Pc4kcPxEft@xps> References: <1558005895-30340-1-git-send-email-skori@marvell.com> <2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com> <1761996.Pc4kcPxEft@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/06/2019 23:10, Thomas Monjalon: > 18/05/2019 17:18, Ananyev, Konstantin: > > > > Hi, > > > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > > > during fragmentation and reassemble operation implicitly. > > > Because of this, application is forced to use checksum offload > > > whether it is supported by platform or not. > > > > > > Also documentation does not provide any expected value of ol_flags > > > in returned mbuf (reassembled or fragmented) so application will never > > > come to know that which offloads are enabled. So transmission may be failed > > > for the platforms which does not support checksum offload. > > > > > > Also, IPv6 does not contain any checksum field in header so setting > > > mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid. > > > > > > So removing mentioned flag from the library. > > > > As there is a change in public API behavior, I think it deserves update in release notes. > > Apart from that: > > Acked-by: Konstantin Ananyev > > Is it safe to do this behaviour change? > You did not reply about updating the release notes. > Why did you drop this patch in v3? No reply? May I consider this series won't go in 19.08 release?