From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677FAC33CB3 for ; Sat, 1 Feb 2020 19:00:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 311E520661 for ; Sat, 1 Feb 2020 19:00:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HICwM7/F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 311E520661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixy05-0000dn-By for qemu-devel@archiver.kernel.org; Sat, 01 Feb 2020 14:00:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50293) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixxzC-00005K-6H for qemu-devel@nongnu.org; Sat, 01 Feb 2020 13:59:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixxzA-0005nG-Oi for qemu-devel@nongnu.org; Sat, 01 Feb 2020 13:59:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59290 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixxzA-0005lI-Ll for qemu-devel@nongnu.org; Sat, 01 Feb 2020 13:59:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580583554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=SbKXzlxS861qYnKuxhiYXJf7NHJSUbqTw3bvxwjcyfA=; b=HICwM7/FJ6R76idrEPHh20RwLZqlQT22sW/nDRmiO8NDiBtup5JEHBCtK12UjjjBWjeZsR OhFbscy8STAcCt0pvdrCwZlrHRlZcicCBpCKI2zHvYWxjsa6+kLQ6YEkK4xnO+04AIi58s M7l20sImdw4cjMljXosLCnxhifHXHIs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-YjeDTNq5PWiULyeTSo5KxQ-1; Sat, 01 Feb 2020 13:59:13 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E9D5800D41; Sat, 1 Feb 2020 18:59:12 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0105B8BE25; Sat, 1 Feb 2020 18:59:02 +0000 (UTC) Subject: Re: [PATCH for-5.0 3/4] Remove the core bluetooth code To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20191120091014.16883-1-thuth@redhat.com> <20191120091014.16883-4-thuth@redhat.com> <7a775153-f18d-e766-1d8f-33607f5fa05b@amsat.org> <2396dfd4-6c85-d17a-b358-bd058c757f14@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <1707e18a-6505-4efe-a85d-7525267bd72a@redhat.com> Date: Sat, 1 Feb 2020 19:59:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: YjeDTNq5PWiULyeTSo5KxQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , libvir-list@redhat.com, "qemu-devel@nongnu.org Developers" , qemu-arm , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 01/02/2020 19.53, Philippe Mathieu-Daud=C3=A9 wrote: > On Sat, Feb 1, 2020 at 7:51 PM Thomas Huth wrote: >> On 01/02/2020 17.09, Philippe Mathieu-Daud=C3=A9 wrote: >>> On 11/20/19 10:10 AM, Thomas Huth wrote: >>>> It's been deprecated since QEMU v3.1. We've explicitly asked in the >>>> deprecation message that people should speak up on qemu-devel in case >>>> they are still actively using the bluetooth part of QEMU, but nobody >>>> ever replied that they are really still using it. >>>> >>>> I've tried it on my own to use this bluetooth subsystem for one of my >>>> guests, but I was also not able to get it running anymore: When I was >>>> trying to pass-through a real bluetooth device, either the guest did >>>> not see the device at all, or the guest crashed. >>>> >>>> Even worse for the emulated device: When running >>>> >>>> qemu-system-x86_64 -bt device:keyboard >>>> >>>> QEMU crashes once you hit a key. >>>> >>>> So it seems like the bluetooth stack is not only neglected, it is >>>> completely bitrotten, as far as I can tell. The only attention that >>>> this code got during the past years were some CVEs that have been >>>> spotted there. So this code is a burden for the developers, without >>>> any real benefit anymore. Time to remove it. >>>> >>>> Signed-off-by: Thomas Huth >>>> --- >>>> Makefile.objs | 2 - >>>> bt-host.c | 198 ---- >>>> bt-vhci.c | 167 ---- >>>> configure | 31 - >>>> hw/Kconfig | 1 - >>>> hw/Makefile.objs | 1 - >>>> hw/bt/Kconfig | 2 - >>>> hw/bt/Makefile.objs | 3 - >>>> hw/bt/core.c | 143 --- >>>> hw/bt/hci-csr.c | 512 ---------- >>>> hw/bt/hci.c | 2263 -----------------------------------------= - >>>> hw/bt/hid.c | 553 ----------- >>>> hw/bt/l2cap.c | 1367 ------------------------- >>>> hw/bt/sdp.c | 989 ------------------ >>>> include/hw/bt.h | 2177 ---------------------------------------- >>>> include/sysemu/bt.h | 20 - >>>> qemu-deprecated.texi | 7 - >>>> qemu-options.hx | 79 -- >>>> vl.c | 136 --- >>>> 19 files changed, 8651 deletions(-) >>>> delete mode 100644 bt-host.c >>>> delete mode 100644 bt-vhci.c >>>> delete mode 100644 hw/bt/Kconfig >>>> delete mode 100644 hw/bt/Makefile.objs >>>> delete mode 100644 hw/bt/core.c >>>> delete mode 100644 hw/bt/hci-csr.c >>>> delete mode 100644 hw/bt/hci.c >>>> delete mode 100644 hw/bt/hid.c >>>> delete mode 100644 hw/bt/l2cap.c >>>> delete mode 100644 hw/bt/sdp.c >>>> delete mode 100644 include/hw/bt.h >>>> delete mode 100644 include/sysemu/bt.h >>>> >>> [...]> diff --git a/configure b/configure >>>> index 6099be1d84..ecce4ada2d 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -349,7 +349,6 @@ unset target_list_exclude >>>> # Distributions want to ensure that several features are compiled in,= and it >>>> # is impossible without a --enable-foo that exits if a feature is not= found. >>>> >>>> -bluez=3D"" >>>> brlapi=3D"" >>>> curl=3D"" >>>> curses=3D"" >>>> @@ -1151,10 +1150,6 @@ for opt do >>>> ;; >>>> --enable-brlapi) brlapi=3D"yes" >>>> ;; >>>> - --disable-bluez) bluez=3D"no" >>>> - ;; >>>> - --enable-bluez) bluez=3D"yes" >>>> - ;; >>> >>> Now than I'm bisecting over this commit, I realize removing this >>> option was not a good idea, we should have done like commit >>> cb6414dfec8 or 315d3184525: >>> >>> @@ -886,10 +885,6 @@ for opt do >>> - --disable-uuid) uuid=3D"no" >>> - ;; >>> - --enable-uuid) uuid=3D"yes" >>> - ;; >>> ... >>> + --enable-uuid|--disable-uuid) >>> + echo "$0: $opt is obsolete, UUID support is always built" >&2 >>> + ;; >> >> Looks trivial ... so if it bugs you, just send a patch? >=20 > I thought about it but this won't fix much, it is too late now. >=20 > I simply wanted to share this bugged me so we try to avoid doing the > same mistake again. Makes sense. I'll try to remember it for the future. Thomas