All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: linux-leds@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Alexander Dahl <post@lespocky.de>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	linux-omap@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Fri, 02 Oct 2020 12:07:38 +0200	[thread overview]
Message-ID: <1708987.KbI9FDK2aH@ada> (raw)
In-Reply-To: <CAJKOXPewAhZU1Enz9HrdrG5RF==y6Mna=E_vfpD4u2747CVo8A@mail.gmail.com>

Hello Krzysztof,

Am Freitag, 2. Oktober 2020, 11:21:10 CEST schrieb Krzysztof Kozlowski:
> On Thu, 1 Oct 2020 at 01:51, Alexander Dahl <post@lespocky.de> wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now).
> 
> What warning? Please post them here and in every DTS patch.

ack

> Your schema does not enforce pwmleds node naming (the main node, not
> children), or at least I could not see it. You change multiple files
> in your patchset so are you sure that all these are justified by
> warnings pointed out by schema?

The rename was suggested by Rob [1], and I think you're right, those names are 
not (yet) enforced by schema?  So at least the commit message is misleading 
for now.  I'll have to see if I rather reword or update the schema again.

Greets
Alex

[1] https://lore.kernel.org/linux-leds/20200922155747.GA2734659@bogus/



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Dahl <ada@thorsis.com>
To: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-mips@vger.kernel.org,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alexander Dahl <post@lespocky.de>, Dan Murphy <dmurphy@ti.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Fri, 02 Oct 2020 12:07:38 +0200	[thread overview]
Message-ID: <1708987.KbI9FDK2aH@ada> (raw)
In-Reply-To: <CAJKOXPewAhZU1Enz9HrdrG5RF==y6Mna=E_vfpD4u2747CVo8A@mail.gmail.com>

Hello Krzysztof,

Am Freitag, 2. Oktober 2020, 11:21:10 CEST schrieb Krzysztof Kozlowski:
> On Thu, 1 Oct 2020 at 01:51, Alexander Dahl <post@lespocky.de> wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now).
> 
> What warning? Please post them here and in every DTS patch.

ack

> Your schema does not enforce pwmleds node naming (the main node, not
> children), or at least I could not see it. You change multiple files
> in your patchset so are you sure that all these are justified by
> warnings pointed out by schema?

The rename was suggested by Rob [1], and I think you're right, those names are 
not (yet) enforced by schema?  So at least the commit message is misleading 
for now.  I'll have to see if I rather reword or update the schema again.

Greets
Alex

[1] https://lore.kernel.org/linux-leds/20200922155747.GA2734659@bogus/



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Dahl <ada@thorsis.com>
To: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-mips@vger.kernel.org,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alexander Dahl <post@lespocky.de>, Dan Murphy <dmurphy@ti.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Fri, 02 Oct 2020 12:07:38 +0200	[thread overview]
Message-ID: <1708987.KbI9FDK2aH@ada> (raw)
In-Reply-To: <CAJKOXPewAhZU1Enz9HrdrG5RF==y6Mna=E_vfpD4u2747CVo8A@mail.gmail.com>

Hello Krzysztof,

Am Freitag, 2. Oktober 2020, 11:21:10 CEST schrieb Krzysztof Kozlowski:
> On Thu, 1 Oct 2020 at 01:51, Alexander Dahl <post@lespocky.de> wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now).
> 
> What warning? Please post them here and in every DTS patch.

ack

> Your schema does not enforce pwmleds node naming (the main node, not
> children), or at least I could not see it. You change multiple files
> in your patchset so are you sure that all these are justified by
> warnings pointed out by schema?

The rename was suggested by Rob [1], and I think you're right, those names are 
not (yet) enforced by schema?  So at least the commit message is misleading 
for now.  I'll have to see if I rather reword or update the schema again.

Greets
Alex

[1] https://lore.kernel.org/linux-leds/20200922155747.GA2734659@bogus/



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2020-10-02 10:07 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 23:46 [PATCH v6 0/7] leds: pwm: Make automatic labels work Alexander Dahl
2020-09-30 23:46 ` Alexander Dahl
2020-09-30 23:46 ` Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 1/7] leds: pwm: Remove platform_data support Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 2/7] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-10-02  9:31   ` Krzysztof Kozlowski
2020-10-02  9:31     ` Krzysztof Kozlowski
2020-10-02  9:31     ` Krzysztof Kozlowski
2020-10-02 10:46     ` Alexander Dahl
2020-10-02 10:46       ` Alexander Dahl
2020-10-02 10:46       ` Alexander Dahl
2020-10-02 10:52       ` Krzysztof Kozlowski
2020-10-02 10:52         ` Krzysztof Kozlowski
2020-10-02 10:52         ` Krzysztof Kozlowski
2020-10-05 13:51   ` Rob Herring
2020-10-05 13:51     ` Rob Herring
2020-10-05 13:51     ` Rob Herring
2020-10-05 13:54   ` Rob Herring
2020-10-05 13:54     ` Rob Herring
2020-10-05 13:54     ` Rob Herring
2020-09-30 23:46 ` [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-10-02  9:21   ` Krzysztof Kozlowski
2020-10-02  9:21     ` Krzysztof Kozlowski
2020-10-02  9:21     ` Krzysztof Kozlowski
2020-10-02 10:07     ` Alexander Dahl [this message]
2020-10-02 10:07       ` Alexander Dahl
2020-10-02 10:07       ` Alexander Dahl
2020-10-02 10:12       ` Krzysztof Kozlowski
2020-10-02 10:12         ` Krzysztof Kozlowski
2020-10-02 10:12         ` Krzysztof Kozlowski
2020-09-30 23:46 ` [PATCH v6 4/7] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 5/7] ARM: dts: Fix schema warnings for pwm-leds Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-10-02  9:12   ` Krzysztof Kozlowski
2020-10-02  9:12     ` Krzysztof Kozlowski
2020-10-02  9:12     ` Krzysztof Kozlowski
2020-10-02  9:27     ` Alexander Dahl
2020-10-02  9:27       ` Alexander Dahl
2020-10-02  9:27       ` Alexander Dahl
2020-10-02 10:06       ` Krzysztof Kozlowski
2020-10-02 10:06         ` Krzysztof Kozlowski
2020-10-02 10:06         ` Krzysztof Kozlowski
2020-09-30 23:46 ` [PATCH v6 6/7] arm64: dts: meson: " Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-10-02  9:23   ` Neil Armstrong
2020-10-02  9:23     ` Neil Armstrong
2020-10-02  9:23     ` Neil Armstrong
2020-09-30 23:46 ` [PATCH v6 7/7] MIPS: DTS: img: " Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl
2020-09-30 23:46   ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1708987.KbI9FDK2aH@ada \
    --to=ada@thorsis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=pavel@ucw.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=post@lespocky.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.