From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09840C77B73 for ; Wed, 31 May 2023 05:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234161AbjEaFab (ORCPT ); Wed, 31 May 2023 01:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231833AbjEaFa3 (ORCPT ); Wed, 31 May 2023 01:30:29 -0400 Received: from out0-197.mail.aliyun.com (out0-197.mail.aliyun.com [140.205.0.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 573D911B; Tue, 30 May 2023 22:30:27 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047204;MF=changxian.cqs@antgroup.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---.THCuFeH_1685511019; Received: from 30.177.18.117(mailfrom:changxian.cqs@antgroup.com fp:SMTPD_---.THCuFeH_1685511019) by smtp.aliyun-inc.com; Wed, 31 May 2023 13:30:20 +0800 Message-ID: <170fa8d4-7851-cc1a-14ba-7213d0a5da0c@antgroup.com> Date: Wed, 31 May 2023 13:30:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests To: Boqun Feng , Greg KH Cc: , "=?UTF-8?B?55Sw5rSq5Lqu?=" , "Miguel Ojeda" , "Alex Gaynor" , "Wedson Almeida Filho" , "Gary Guo" , "=?UTF-8?Q?Bj=c3=b6rn_Roy_Baron?=" , "Benno Lossin" , "Martin Rodriguez Reboredo" , "Asahi Lina" , "Sven Van Asbroeck" , "Viktor Garske" , "Finn Behrens" , References: <20230530064821.1222290-1-changxian.cqs@antgroup.com> <20230530064821.1222290-3-changxian.cqs@antgroup.com> <2023053003-antitoxic-popcorn-b1ab@gregkh> From: "Qingsong Chen" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On 5/31/23 2:33 AM, Boqun Feng wrote: > On Tue, May 30, 2023 at 08:31:26AM +0100, Greg KH wrote: >> On Tue, May 30, 2023 at 02:48:21PM +0800, Qingsong Chen wrote: >>> Add a selftest module to provide a temporary place to put "pure tests" >>> for Rust funtionality and wrappers. >> Is this for in-kernel tests, or userspace tests? If userspace, you >> should follow the proper test reporting protocol the rest of the kernel >> uses. If in-kernel, it should follow the format that the in-kernel test >> currently has to be consistent. From what I could tell here, you aren't >> following either, but I might be totally wrong. >> > It is for in-kernel tests, and you're right, we should follow the other > in-kernel test format. > > Some explanation about the background: when I was working on this little > "test framework", the Github CI of Rust-for-Linux (ab)used sample/rust/ > for testing, that's why it was put there. > > Now my understanding is that Rust KUnit support is coming, so we should > use kunit tests if possible. Maybe I should place those use cases in the doc ( `Examples` section) and remove this commit in next version. Thanks.