From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7E8C433F5 for ; Wed, 22 Sep 2021 17:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5450610D1 for ; Wed, 22 Sep 2021 17:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236716AbhIVR1i (ORCPT ); Wed, 22 Sep 2021 13:27:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23974 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236744AbhIVR1g (ORCPT ); Wed, 22 Sep 2021 13:27:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632331565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25lGIVYtKt3kH1kWTNrr/qFisdmByWs8m8B7PEwB7yQ=; b=abXgpKfHs2mXBli1SkJJRtQ4tSNB6ogaz7n/PGMMJx0gDUBzxhaGo9E7j89AmFokTi0ClL mQWqxeE9ahZ0GfvrKJKDO0OjdzijYsdoNEfPEUgVKYM9KyAey9bBSWGnbizV2CO8zS2onq Lj5jHFpi4ChOOKlJ/EhCR4fnF0hNZ0A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-QM5rgveEOg-MnWOc20chRg-1; Wed, 22 Sep 2021 13:26:02 -0400 X-MC-Unique: QM5rgveEOg-MnWOc20chRg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E6DD814707; Wed, 22 Sep 2021 17:26:00 +0000 (UTC) Received: from x2.localnet (unknown [10.22.9.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 169841972D; Wed, 22 Sep 2021 17:25:31 +0000 (UTC) From: Steve Grubb To: Eugene Syromiatnikov , Paul Cercueil Cc: Cai Huoqing , linux-audit@redhat.com, strace development discussions , linux-api@vger.kernel.org, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Date: Wed, 22 Sep 2021 13:25:29 -0400 Message-ID: <1710508.VLH7GnMWUR@x2> Organization: Red Hat In-Reply-To: References: <20210813120803.101-1-caihuoqing@baidu.com> <20210902160840.GA2220@asgard.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote: > >> IPX is marked obsolete for serveral years. so remove it and the > >> dependency in linux tree. > >> I'm sorry to not thinking about linux-audit and strace. > >> Might you remove the dependency or make the part of the code. > >> Many thanks. > > > > Unfortunately, that is not how UAPI works. That change breaks > > building > > of the existing code; one cannot change already released versions > > of either audit, strace, or any other userspace program that happens > > to unconditionally include without any fallback (like > > provided by glibc). > > Also, the fallback is only provided by glibc (and maybe > uclibc?). With this patch, it is now impossible to compile even the > very latest version of "strace" with a musl toolchain. I've made support for ipx optional in audit user space a couple weeks back. It's no longer a problem for us. -Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC385C433EF for ; Wed, 22 Sep 2021 17:26:27 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E214610D1 for ; Wed, 22 Sep 2021 17:26:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E214610D1 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632331586; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Lt1NeSbMn4Vi4ZebXAZ2A1tSRlD13Oru9Xy3gftBIqA=; b=TtvG+W400HREdJJLd0qZbLohk2qGsRipKuKblqTsOSpNgL0IvtGf3Cy5IzUtQF9USP33Ig 9F6T2k/09JWzXSdfW/XIuQW0Od0gI5vaDPulOLzCIVCWrBNiPUKWy6TsmV8F4SIDjDSRCc c2i4Ig5tY1sEnv5Qjs3gbh2YJV21JFM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-vTyOcFkgPg-Ow3oe7HR31g-1; Wed, 22 Sep 2021 13:26:24 -0400 X-MC-Unique: vTyOcFkgPg-Ow3oe7HR31g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05C17802921; Wed, 22 Sep 2021 17:26:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF1F41972D; Wed, 22 Sep 2021 17:26:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80C494E58F; Wed, 22 Sep 2021 17:26:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18MHQ0J3022126 for ; Wed, 22 Sep 2021 13:26:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1C8E619733; Wed, 22 Sep 2021 17:26:00 +0000 (UTC) Received: from x2.localnet (unknown [10.22.9.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 169841972D; Wed, 22 Sep 2021 17:25:31 +0000 (UTC) From: Steve Grubb To: Eugene Syromiatnikov , Paul Cercueil Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Date: Wed, 22 Sep 2021 13:25:29 -0400 Message-ID: <1710508.VLH7GnMWUR@x2> Organization: Red Hat In-Reply-To: References: <20210813120803.101-1-caihuoqing@baidu.com> <20210902160840.GA2220@asgard.redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: linux-audit@redhat.com Cc: yoshfuji@linux-ipv6.org, linux-api@vger.kernel.org, dsahern@kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io, linux-audit@redhat.com, Cai Huoqing , netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, strace development discussions X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote: > >> IPX is marked obsolete for serveral years. so remove it and the > >> dependency in linux tree. > >> I'm sorry to not thinking about linux-audit and strace. > >> Might you remove the dependency or make the part of the code. > >> Many thanks. > > > > Unfortunately, that is not how UAPI works. That change breaks > > building > > of the existing code; one cannot change already released versions > > of either audit, strace, or any other userspace program that happens > > to unconditionally include without any fallback (like > > provided by glibc). > > Also, the fallback is only provided by glibc (and maybe > uclibc?). With this patch, it is now impossible to compile even the > very latest version of "strace" with a musl toolchain. I've made support for ipx optional in audit user space a couple weeks back. It's no longer a problem for us. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit