All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rob Herring" <robh@kernel.org>,
	"Zhang Jianhua" <chris.zjh@huawei.com>,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] dmaengine: owl: fix register access functions
Date: Thu, 28 Mar 2024 13:09:35 +0530	[thread overview]
Message-ID: <171161157512.113367.10881464487051334801.b4-ty@kernel.org> (raw)
In-Reply-To: <20240322132116.906475-1-arnd@kernel.org>


On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote:
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
> 
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
>   244 |         u32 regval;
>       |             ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
>   268 |         u32 regval;
>       |             ^
> 
> [...]

Applied, thanks!

[1/1] dmaengine: owl: fix register access functions
      commit: 43c633ef93a5d293c96ebcedb40130df13128428

Best regards,
-- 
~Vinod



WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rob Herring" <robh@kernel.org>,
	"Zhang Jianhua" <chris.zjh@huawei.com>,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] dmaengine: owl: fix register access functions
Date: Thu, 28 Mar 2024 13:09:35 +0530	[thread overview]
Message-ID: <171161157512.113367.10881464487051334801.b4-ty@kernel.org> (raw)
In-Reply-To: <20240322132116.906475-1-arnd@kernel.org>


On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote:
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
> 
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
>   244 |         u32 regval;
>       |             ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
>   268 |         u32 regval;
>       |             ^
> 
> [...]

Applied, thanks!

[1/1] dmaengine: owl: fix register access functions
      commit: 43c633ef93a5d293c96ebcedb40130df13128428

Best regards,
-- 
~Vinod



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-03-28  7:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 13:21 [PATCH] dmaengine: owl: fix register access functions Arnd Bergmann
2024-03-22 13:21 ` Arnd Bergmann
2024-03-22 13:36 ` Peter Korsgaard
2024-03-22 13:36   ` Peter Korsgaard
2024-03-22 14:32 ` Manivannan Sadhasivam
2024-03-22 14:32   ` Manivannan Sadhasivam
2024-03-28  7:39 ` Vinod Koul [this message]
2024-03-28  7:39   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171161157512.113367.10881464487051334801.b4-ty@kernel.org \
    --to=vkoul@kernel.org \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=chris.zjh@huawei.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.