From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9089239FC6; Thu, 28 Mar 2024 07:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711611581; cv=none; b=rqebFjur6WY3i1w+4ONm0eFPym8dDM8JEcMkCGh2zJAWPwz4uyliAiwx+xEcifH+yFfmhGPJ0KhBcMSMUCqQ58yeVceckqyn3qakPi3QzudCcIzKieKZZyVODC65WjYmAPXGvVFp2arQWt3DWyPrL0m811hxCPQhZzB9DPlb5Q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711611581; c=relaxed/simple; bh=j2fecunGf2z206NzbuhZVhae6PguWXtF1jN4ko+Qk6A=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=I+EJ+EX/vV3ZwHu/K0+At/DjsAfwX+yZSnu1AgubKZvkM1gIc44lR1rHeUEBsQIGgv1s2WZRa572AjyWJQMSRfg1TzwEWPCV/eL8JTKQjYsGu+SC+BI2XYCkwbPxKbXjQ09YqYyfBBbALMErv2EazJy7W0Ybd5hWGqAt2euJiFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mzXDtiMj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mzXDtiMj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CF47C433C7; Thu, 28 Mar 2024 07:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711611581; bh=j2fecunGf2z206NzbuhZVhae6PguWXtF1jN4ko+Qk6A=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=mzXDtiMjwTUnjifYo0LhCLPcO+1bwT0CitQmJUs/rFiAbkNL6H2YmohGRnS/lSeaf sDrUPbms3pcO6baStESjextCTz7lHVTPPofrdOVek9lOO/feshIw6YkqYWYVI+CJlC sQc6Qs2fMEe/yrog4CthJix+Tftiu6gqmIXlTDIGn6ZPJcTtGC4qaa7+OJ2kb9VKcO lNDBFH70yy/a+NeI9ebAL2HoWdgAbqzpO8MddZiiiELpJVeWPWE58t2ysgMo++e2Ci hyO19+NUTMTr9JW86vEE1aW1wK3APPWHMbyeIP5vPzQL2qYRg+mMI8SMVUJKYXzj89 awTZf6QtkShjw== From: Vinod Koul To: =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Nathan Chancellor , Arnd Bergmann Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Zhang Jianhua , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev In-Reply-To: <20240322132116.906475-1-arnd@kernel.org> References: <20240322132116.906475-1-arnd@kernel.org> Subject: Re: [PATCH] dmaengine: owl: fix register access functions Message-Id: <171161157512.113367.10881464487051334801.b4-ty@kernel.org> Date: Thu, 28 Mar 2024 13:09:35 +0530 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote: > When building with 'make W=1', clang notices that the computed register > values are never actually written back but instead the wrong variable > is set: > > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 244 | u32 regval; > | ^ > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 268 | u32 regval; > | ^ > > [...] Applied, thanks! [1/1] dmaengine: owl: fix register access functions commit: 43c633ef93a5d293c96ebcedb40130df13128428 Best regards, -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69CDAC54E67 for ; Thu, 28 Mar 2024 07:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-Id:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zc7KyY4dWmLIe6TIm8p3CPeVQzs3S88+27MmbrMIeZ8=; b=1/NOdiaWgY1zWV TKVewHO3n1ubY2Bv9/1aXS/Dod75S1OT3/K6Gx1i7aj/xMeU6khxBFo6wO9dJsjlSx+OloGmDt//B NGY1xMkz/a+pI4Pl3MXQOxmleZxvKDzWOwhA1ji6NRBilc8f4VHZS4tHTMMgCkWT+5YBF5ob9/pt+ 44Gazs+ABktkwCBj4d1KjvoUJVOL1P9ZWOD52Ig054FvKDgzJ3lSxaAXuZOtpFWVeKPsCX3y1aPkJ OI/Mn45ZtcQQw9yBUmvmf6dSeKHDgICjRsKwYFjWV7hMX31f24wxt/nSNA8XzMCSfCxg0vXt52qja TdVUiPd0jL9zXMobDoag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpkMU-0000000CuGu-1tOw; Thu, 28 Mar 2024 07:39:46 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpkMR-0000000CuFY-20or; Thu, 28 Mar 2024 07:39:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B72FCCE29AA; Thu, 28 Mar 2024 07:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CF47C433C7; Thu, 28 Mar 2024 07:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711611581; bh=j2fecunGf2z206NzbuhZVhae6PguWXtF1jN4ko+Qk6A=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=mzXDtiMjwTUnjifYo0LhCLPcO+1bwT0CitQmJUs/rFiAbkNL6H2YmohGRnS/lSeaf sDrUPbms3pcO6baStESjextCTz7lHVTPPofrdOVek9lOO/feshIw6YkqYWYVI+CJlC sQc6Qs2fMEe/yrog4CthJix+Tftiu6gqmIXlTDIGn6ZPJcTtGC4qaa7+OJ2kb9VKcO lNDBFH70yy/a+NeI9ebAL2HoWdgAbqzpO8MddZiiiELpJVeWPWE58t2ysgMo++e2Ci hyO19+NUTMTr9JW86vEE1aW1wK3APPWHMbyeIP5vPzQL2qYRg+mMI8SMVUJKYXzj89 awTZf6QtkShjw== From: Vinod Koul To: =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Nathan Chancellor , Arnd Bergmann Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Zhang Jianhua , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev In-Reply-To: <20240322132116.906475-1-arnd@kernel.org> References: <20240322132116.906475-1-arnd@kernel.org> Subject: Re: [PATCH] dmaengine: owl: fix register access functions Message-Id: <171161157512.113367.10881464487051334801.b4-ty@kernel.org> Date: Thu, 28 Mar 2024 13:09:35 +0530 MIME-Version: 1.0 X-Mailer: b4 0.12.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_003943_732553_30FFB1E1 X-CRM114-Status: UNSURE ( 6.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 22 Mar 2024 14:21:07 +0100, Arnd Bergmann wrote: > When building with 'make W=1', clang notices that the computed register > values are never actually written back but instead the wrong variable > is set: > > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 244 | u32 regval; > | ^ > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 268 | u32 regval; > | ^ > > [...] Applied, thanks! [1/1] dmaengine: owl: fix register access functions commit: 43c633ef93a5d293c96ebcedb40130df13128428 Best regards, -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel