From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC1B42061; Thu, 28 Mar 2024 15:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711639555; cv=none; b=hBG+FKNUdJDtAHIbRbkgexfrP4W5qtC6Pcr7CqswpLs4Rjf0JxU/NnzVs5uBhLDQ/xw/U1SjC64PxiyePPw6zqnPj2xCN6ucWOQtqQ5iyCppimnG94SW2VaSxBf8o5BMPWfSh54IUMSLs4Wpbpg2wF+HC14A/F0kICDKKXGpzh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711639555; c=relaxed/simple; bh=eM6eoVS/j9fw7JpCQoWfgH8JFa9jiXdb3VWcSy5HKQs=; h=Date:Content-Type:MIME-Version:From:To:Cc:In-Reply-To:References: Message-Id:Subject; b=I0bq95ErXwCvGn7wu4A1sG1VmTPosUlVVCI9GLmy/i7LoE6cxDCbofZBzBy4Cko3QWhIFSnXXNRH6BpT00v8B0BWA+5eoqxPJNYsvLAME3Y1Grl7elDDPMuAGO55r2ylVIF0jkEK8qMAAvbE8eu9LSUobqUbMGuiqGEi4T7fV4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m7YCPw09; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m7YCPw09" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92053C433F1; Thu, 28 Mar 2024 15:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711639554; bh=eM6eoVS/j9fw7JpCQoWfgH8JFa9jiXdb3VWcSy5HKQs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=m7YCPw09Lnjm3o8eGUlVm1JyS575H5ItmJV66i/715GAh9DvT2s1TqVQsmtMiwFJQ Sdveujo87MYNPaBKsD3/BHH4k/zHid421JUnytdk/Qx+cM34N7hrlSsFXQwcatw1DZ 5M6D2E/gbHUfQU4eaGnAaJ/UjsMdEOGB3gHfBuazOcTB8DNXWBCxN9jsz46CxByMsh UcMgWz6gsNati9StCAyoP4u/GLqZBLWtDaW2P6FlM8ifoD/Mx5WOGjWpCrJvkmeRaz flyIyVt0ALvaDO3JikR1Wpg/2pRCj9odTaHZReKhEwD89WB8YmmhpdueJefBAWofwx cCVaSb07IY8IQ== Date: Thu, 28 Mar 2024 10:25:53 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Herring To: Christophe Roullier Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Mark Brown , Jose Abreu , Eric Dumazet , linux-kernel@vger.kernel.org, Richard Cochran , Jakub Kicinski , Rob Herring , linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org, Liam Girdwood , "David S . Miller" , Maxime Coquelin , Conor Dooley , Krzysztof Kozlowski , Alexandre Torgue , netdev@vger.kernel.org, Paolo Abeni In-Reply-To: <20240328140803.324141-2-christophe.roullier@foss.st.com> References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> Message-Id: <171163955238.3507826.5734001949624773121.robh@kernel.org> Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk On Thu, 28 Mar 2024 15:08:03 +0100, Christophe Roullier wrote: > The Linux kernel dwmac-stm32 driver currently supports three DT > properties used to configure whether PHY clock are generated by > the MAC or supplied to the MAC from the PHY. > > Originally there were two properties, st,eth-clk-sel and > st,eth-ref-clk-sel, each used to configure MAC clocking in > different bus mode and for different MAC clock frequency. > Since it is possible to determine the MAC 'eth-ck' clock > frequency from the clock subsystem and PHY bus mode from > the 'phy-mode' property, two disparate DT properties are > no longer required to configure MAC clocking. > > Linux kernel commit 1bb694e20839 ("net: ethernet: stmmac: simplify phy modes management for stm32") > introduced a third, unified, property st,ext-phyclk. This property > covers both use cases of st,eth-clk-sel and st,eth-ref-clk-sel DT > properties, as well as a new use case for 25 MHz clock generated > by the MAC. > > The third property st,ext-phyclk is so far undocumented, > document it. > > Below table summarizes the clock requirement and clock sources for > supported PHY interface modes. > __________________________________________________________________________ > |PHY_MODE | Normal | PHY wo crystal| PHY wo crystal |No 125Mhz from PHY| > | | | 25MHz | 50MHz | | > > --------------------------------------------------------------------------- > | MII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > > --------------------------------------------------------------------------- > | GMII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > > --------------------------------------------------------------------------- > | RGMII | - | eth-ck | n/a | eth-ck | > | | | st,ext-phyclk | | st,eth-clk-sel or| > | | | | | st,ext-phyclk | > > --------------------------------------------------------------------------- > | RMII | - | eth-ck | eth-ck | n/a | > | | | st,ext-phyclk | st,eth-ref-clk-sel | | > | | | | or st,ext-phyclk | | > > --------------------------------------------------------------------------- > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:86:5: [warning] wrong indentation: expected 2 but found 4 (indentation) ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: [error] syntax error: expected , but found '' (syntax) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/stm32-dwmac.example.dts' Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: did not find expected key make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/stm32-dwmac.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: did not find expected key /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240328140803.324141-2-christophe.roullier@foss.st.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99BCEC54E67 for ; Thu, 28 Mar 2024 15:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=EOWJBDe0kVkN3IWl8mLRrjmFCAUlsaOQgtOTapDHLFI=; b=QiQSDZqXCaXe0mLlnoKiPfKF0P 0Lvt7mSXe7KjciZLBFbb/22wH8Sx31uu++61Fycly9aDvTFaVV+BFb/e2a9LpwTHyIGLlkVMXFIYv 9tE1EzVsJF4hdcCW0r/vUiNA73P3/orWTZInGMi68XYN+6kmBoRNvW19LgOtZzBlxdYSLGMs0rs+D UIkpySdiud+shIQjPvDjnkBL6AVx8cjIUWSMRmhNfvfSG5NG+4LeqenHBdAa5aXmpGzD+kNxeRFol 0joTLCg4DHRyoHPTkT0Yzk78s780jfHV6lTFb9yFvc+fcENTQ4dBfYJEVAqMl6cdbW8JHs/snUySZ gfArCaqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprdf-0000000EVne-0mIn; Thu, 28 Mar 2024 15:25:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprdc-0000000EVmf-12a6 for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 15:25:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2AC2B61220; Thu, 28 Mar 2024 15:25:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92053C433F1; Thu, 28 Mar 2024 15:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711639554; bh=eM6eoVS/j9fw7JpCQoWfgH8JFa9jiXdb3VWcSy5HKQs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=m7YCPw09Lnjm3o8eGUlVm1JyS575H5ItmJV66i/715GAh9DvT2s1TqVQsmtMiwFJQ Sdveujo87MYNPaBKsD3/BHH4k/zHid421JUnytdk/Qx+cM34N7hrlSsFXQwcatw1DZ 5M6D2E/gbHUfQU4eaGnAaJ/UjsMdEOGB3gHfBuazOcTB8DNXWBCxN9jsz46CxByMsh UcMgWz6gsNati9StCAyoP4u/GLqZBLWtDaW2P6FlM8ifoD/Mx5WOGjWpCrJvkmeRaz flyIyVt0ALvaDO3JikR1Wpg/2pRCj9odTaHZReKhEwD89WB8YmmhpdueJefBAWofwx cCVaSb07IY8IQ== Date: Thu, 28 Mar 2024 10:25:53 -0500 MIME-Version: 1.0 From: Rob Herring To: Christophe Roullier Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Mark Brown , Jose Abreu , Eric Dumazet , linux-kernel@vger.kernel.org, Richard Cochran , Jakub Kicinski , Rob Herring , linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org, Liam Girdwood , "David S . Miller" , Maxime Coquelin , Conor Dooley , Krzysztof Kozlowski , Alexandre Torgue , netdev@vger.kernel.org, Paolo Abeni In-Reply-To: <20240328140803.324141-2-christophe.roullier@foss.st.com> References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> Message-Id: <171163955238.3507826.5734001949624773121.robh@kernel.org> Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_082556_550351_EF3B7C34 X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 Mar 2024 15:08:03 +0100, Christophe Roullier wrote: > The Linux kernel dwmac-stm32 driver currently supports three DT > properties used to configure whether PHY clock are generated by > the MAC or supplied to the MAC from the PHY. > > Originally there were two properties, st,eth-clk-sel and > st,eth-ref-clk-sel, each used to configure MAC clocking in > different bus mode and for different MAC clock frequency. > Since it is possible to determine the MAC 'eth-ck' clock > frequency from the clock subsystem and PHY bus mode from > the 'phy-mode' property, two disparate DT properties are > no longer required to configure MAC clocking. > > Linux kernel commit 1bb694e20839 ("net: ethernet: stmmac: simplify phy modes management for stm32") > introduced a third, unified, property st,ext-phyclk. This property > covers both use cases of st,eth-clk-sel and st,eth-ref-clk-sel DT > properties, as well as a new use case for 25 MHz clock generated > by the MAC. > > The third property st,ext-phyclk is so far undocumented, > document it. > > Below table summarizes the clock requirement and clock sources for > supported PHY interface modes. > __________________________________________________________________________ > |PHY_MODE | Normal | PHY wo crystal| PHY wo crystal |No 125Mhz from PHY| > | | | 25MHz | 50MHz | | > > --------------------------------------------------------------------------- > | MII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > > --------------------------------------------------------------------------- > | GMII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > > --------------------------------------------------------------------------- > | RGMII | - | eth-ck | n/a | eth-ck | > | | | st,ext-phyclk | | st,eth-clk-sel or| > | | | | | st,ext-phyclk | > > --------------------------------------------------------------------------- > | RMII | - | eth-ck | eth-ck | n/a | > | | | st,ext-phyclk | st,eth-ref-clk-sel | | > | | | | or st,ext-phyclk | | > > --------------------------------------------------------------------------- > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:86:5: [warning] wrong indentation: expected 2 but found 4 (indentation) ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: [error] syntax error: expected , but found '' (syntax) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/stm32-dwmac.example.dts' Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: did not find expected key make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/stm32-dwmac.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/net/stm32-dwmac.yaml:92:3: did not find expected key /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240328140803.324141-2-christophe.roullier@foss.st.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel