From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 1/2] ethdev: add supported hash function
	check
Date: Tue, 17 Apr 2018 00:56:36 +0200
Message-ID: <1713016.yCs8GSPTMd@xps>
References: <20180318073720.84176-1-xuemingl@mellanox.com>
 <20180409121035.148813-1-xuemingl@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <notifications@github.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, arybchenko@solarflare.com,
 ferruh.yigit@intel.com
To: Xueming Li <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E78FFAABE
 for <dev@dpdk.org>; Tue, 17 Apr 2018 00:56:39 +0200 (CEST)
In-Reply-To: <20180409121035.148813-1-xuemingl@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/04/2018 14:10, Xueming Li:
> Add supported RSS hash function check in device configuration to
> have better error verbosity for application developers.

In other words, you check whether the requested RSS type is supported.

I don't see any reason to not accept it.
Any other comment?