From: Arnd Bergmann <arnd@arndb.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, nicolas.ferre@atmel.com,
boris.brezillon@free-electrons.com, marex@denx.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date: Mon, 18 Jul 2016 21:59:56 +0200 [thread overview]
Message-ID: <1715321.52KD2CMTqu@wuerfel> (raw)
In-Reply-To: <20160718195511.GA137880@google.com>
On Monday, July 18, 2016 12:55:11 PM CEST Brian Norris wrote:
> On Mon, Jul 18, 2016 at 09:35:39PM +0200, Arnd Bergmann wrote:
> > On Friday, July 15, 2016 5:45:07 PM CEST Brian Norris wrote:
> > > Applied to l2-mtd.git with that fixup.
> >
> > I'm getting this build error now on a randconfig build:
> >
> > drivers/mtd/built-in.o: In function `atmel_qspi_run_command':
> > :(.text+0x1ee3c): undefined reference to `_memcpy_toio'
> > :(.text+0x1ee48): undefined reference to `_memcpy_fromio'
>
> Whoops, I noticed those during review, but I don't know why I forgot to
> mention them nor fix them up before applying.
>
> > On ARCH_EBSA, which doesn't build the file that contains the two
> > functions. I don't see any other driver on ARM using those two
> > functions directly. What is the specific reason for using them
> > here? Do you require byte-wise accesses, or could you use
> > the normal memcpy_toio/memcpy_fromio that turn into aligned
> > 32-bit word accesses instead?
>
> Good questions. I would suspect that aligned 32-bit accesses are what
> they're looking for, but I'm not absolutely sure.
Ok, so we should look at that first. If the driver supports 32-bit
access, using the regular accessors will also make the transfers
much faster.
> > If you have to use the non-portable
> > functions, maybe we can just make the driver depend on !ARCH_EBSA?
>
> I don't see an ARCH_EBSA. Did you mean ARCH_EBSA110?
Yes, sorry for the typo.
> Or we could just drop the '|| (ARM && COMPILE_TEST)' clause for now:
>
> depends on ARCH_AT91 || (ARM && COMPILE_TEST)
I'd prefer to keep the COMPILE_TEST option, after all it's how
I found the problem. On a related note, what is the ARM dependency
for? Is that just for the _memcpy_toio/_memcpy_fromio? Maybe we
can drop too if we find the right architecture-independent
replacement for those two calls.
Arnd
next prev parent reply other threads:[~2016-07-18 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 15:10 [PATCH 0/2] mtd: spi-nor: add driver for Atmel QSPI controller Cyrille Pitchen
2016-06-13 15:10 ` [PATCH 1/2] Documentation: atmel-quadspi: add binding file for Atmel QSPI driver Cyrille Pitchen
2016-07-14 1:16 ` Brian Norris
2016-06-13 15:10 ` [PATCH 2/2] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen
2016-07-14 1:32 ` Brian Norris
2016-07-16 0:45 ` Brian Norris
2016-07-18 19:35 ` Arnd Bergmann
2016-07-18 19:55 ` Brian Norris
2016-07-18 19:59 ` Arnd Bergmann [this message]
2016-07-19 10:03 ` Cyrille Pitchen
2016-07-19 10:42 ` Arnd Bergmann
2016-07-19 10:38 ` Cyrille Pitchen
2016-06-22 13:39 ` [PATCH 0/2] mtd: spi-nor: " Cyrille Pitchen
-- strict thread matches above, loose matches on Subject: below --
2016-05-23 16:17 Cyrille Pitchen
2016-05-23 16:17 ` [PATCH 2/2] mtd: atmel-quadspi: " Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715321.52KD2CMTqu@wuerfel \
--to=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.