From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758230AbcBCWw3 (ORCPT ); Wed, 3 Feb 2016 17:52:29 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:57389 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756499AbcBCWwX (ORCPT ); Wed, 3 Feb 2016 17:52:23 -0500 From: Arnd Bergmann To: Laura Abbott Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, Joonsoo Kim , Christoph Lameter , Pekka Enberg , David Rientjes , Jesper Dangaard Brouer , Laura Abbott , linux-mm@kvack.org, "Kirill A. Shutemov" , Michal Hocko , Vlastimil Babka , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled Date: Wed, 03 Feb 2016 23:51:17 +0100 Message-ID: <1715666.B0erB7v9pc@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56B27F71.2000700@redhat.com> References: <1454537757-3760706-1-git-send-email-arnd@arndb.de> <56B27F71.2000700@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:o2izGTyrruXyBLkVc30mm3IDwmUhxqoqr9mFV28RmlxlWaBmeeN w8SZF/jxhB4GLS3b5ne640DnfPZ/WXelQ6K1P+rOvhPaB0YY05nq0rpKLYaL8E62mCfMFQP Vr0QkOpgsCHfocs266lpnU5VvgjwWzFX3u17w1ZCqWxFSePU7plfIdTfNuaDZ1I8o2qCKOC A86KA14QOeFk0L7YOwiHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VgtuS3+PWx0=:L5x5fwOtI1e2PvwP7rZiwP fXG8mSaX4o/AbhJ0qmxp2sCTkBce6K52etxKVNdIBZT2wo/R3mU73iDQGo6kSpoXcDocEic6Z PSlawjIQ+EAMk5qxnCWXK/e3oJ+OUey0xsjAAMhviEILehu387uiI89vE9Yd5oeXHxCeKgbhY y2I9M6BDrCzm7AJUcOgzGVbunbxJaspKkb6feVW3H+s8xqPN8pNqNYTp6/9fE9oYDIyAPN0Q2 EETWaSW9B0Fyuo6NhrHUwFemIfHcR3wieUFL0w9VqyUnDl0siRHN6ExFuO5COqbaNapDm7htB vqTnzi9VR61/oIulXNsYHis5SkNl4g3J6cr2zl4m12Z/a7Tpv6bwmd0zo2kcQuA4nAPYNKSDu NfW7VYd90QIKEWUmYqthZ/jStD2Jy8Me5UB+a8Z47+7kFCm7zONj5MZ7U+p89mhpsSQPPv0Wm JpelFNFYxSAV8x3x1YKRGROmaUWPpgtgFb6Un0quQ85IZe/dOJvJqBr7skJGFpr7+4s6yM7U7 KliIRzb3znQoN++gcxjSOgxjxCWHutGXMCw6YQiFckI9cAcklmbLrczWjmTUg6cJwyaT32hPT FXwi4Vsb8Gas9tT6REj3fjq7GSBxt3ZWkG4/P+ulV1zdbuM2GpGL7TZSBkpxf3YHtt84jnfZW C8QrCHxErIuNQby0IaiS7dGReujrVD6TL15svUxO8xmampDnVhDgaBbefZz7HyVsUWbYwaQZ0 vqARR6ycCAzjVZ/Q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote: > On 02/03/2016 02:15 PM, Arnd Bergmann wrote: > > The change to move the pagealloc logic broke the slab allocator > > check when it's disabled at compile time: > > > > mm/slab.c: In function 'is_debug_pagealloc_cache': > > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration] > > > > This adds an inline helper to get it to work again. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code") > > --- > > include/linux/mm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 5d86eb2e8584..90d600ce56ad 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable) > > extern bool kernel_page_present(struct page *page); > > #endif /* CONFIG_HIBERNATION */ > > #else > > +static inline bool debug_pagealloc_enabled(void) { return 0; } > > static inline void > > kernel_map_pages(struct page *page, int numpages, int enable) {} > > #ifdef CONFIG_HIBERNATION > > > > I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655 Yes, Christian's version looks nicer too (correct return type). Thanks, Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by kanga.kvack.org (Postfix) with ESMTP id 1BF5182963 for ; Wed, 3 Feb 2016 17:58:02 -0500 (EST) Received: by mail-wm0-f48.google.com with SMTP id l66so92687758wml.0 for ; Wed, 03 Feb 2016 14:58:02 -0800 (PST) Received: from mout.kundenserver.de (mout.kundenserver.de. [217.72.192.75]) by mx.google.com with ESMTPS id 201si15982266wml.102.2016.02.03.14.58.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2016 14:58:01 -0800 (PST) From: Arnd Bergmann Subject: Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled Date: Wed, 03 Feb 2016 23:51:17 +0100 Message-ID: <1715666.B0erB7v9pc@wuerfel> In-Reply-To: <56B27F71.2000700@redhat.com> References: <1454537757-3760706-1-git-send-email-arnd@arndb.de> <56B27F71.2000700@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: owner-linux-mm@kvack.org List-ID: To: Laura Abbott Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, Joonsoo Kim , Christoph Lameter , Pekka Enberg , David Rientjes , Jesper Dangaard Brouer , Laura Abbott , linux-mm@kvack.org, "Kirill A. Shutemov" , Michal Hocko , Vlastimil Babka , linux-kernel@vger.kernel.org On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote: > On 02/03/2016 02:15 PM, Arnd Bergmann wrote: > > The change to move the pagealloc logic broke the slab allocator > > check when it's disabled at compile time: > > > > mm/slab.c: In function 'is_debug_pagealloc_cache': > > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration] > > > > This adds an inline helper to get it to work again. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code") > > --- > > include/linux/mm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 5d86eb2e8584..90d600ce56ad 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable) > > extern bool kernel_page_present(struct page *page); > > #endif /* CONFIG_HIBERNATION */ > > #else > > +static inline bool debug_pagealloc_enabled(void) { return 0; } > > static inline void > > kernel_map_pages(struct page *page, int numpages, int enable) {} > > #ifdef CONFIG_HIBERNATION > > > > I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655 Yes, Christian's version looks nicer too (correct return type). Thanks, Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 03 Feb 2016 23:51:17 +0100 Subject: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled In-Reply-To: <56B27F71.2000700@redhat.com> References: <1454537757-3760706-1-git-send-email-arnd@arndb.de> <56B27F71.2000700@redhat.com> Message-ID: <1715666.B0erB7v9pc@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote: > On 02/03/2016 02:15 PM, Arnd Bergmann wrote: > > The change to move the pagealloc logic broke the slab allocator > > check when it's disabled at compile time: > > > > mm/slab.c: In function 'is_debug_pagealloc_cache': > > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration] > > > > This adds an inline helper to get it to work again. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code") > > --- > > include/linux/mm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 5d86eb2e8584..90d600ce56ad 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable) > > extern bool kernel_page_present(struct page *page); > > #endif /* CONFIG_HIBERNATION */ > > #else > > +static inline bool debug_pagealloc_enabled(void) { return 0; } > > static inline void > > kernel_map_pages(struct page *page, int numpages, int enable) {} > > #ifdef CONFIG_HIBERNATION > > > > I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655 Yes, Christian's version looks nicer too (correct return type). Thanks, Arnd