From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Date: Sun, 18 Dec 2011 11:13:25 +0100
Subject: [U-Boot] U-Boot on Nokia RX-51 (aka N900)
In-Reply-To: <20111217192524.CA824138EEA1@gemini.denx.de>
References: <2265056.NfLL5Fdny9@pali-elitebook>
	<2772527.Czs1Sl5aoH@pali-elitebook>
	<20111217192524.CA824138EEA1@gemini.denx.de>
Message-ID: <17199828.H8TsXDWnq5@pali-elitebook>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 17 December 2011 20:25:24 Wolfgang Denk wrote:
> Dear Pali =?ISO-8859-1?Q?Roh=E1r?=,
> 
> In message <2772527.Czs1Sl5aoH@pali-elitebook> you wrote:
> > I'm sending new patch series, which add Nokia RX-51 support to U-Boot.
> > This
> > patches are based on master commit 06e42c6e2ce269667daecd6229d0b7c81383
> > 8203
> > and now U-Boot working on Nokia RX-51.
> 
> This patch series generates a ton of checkpatch warnings.  Please run
> your code through checkpatch, and make sure to read the respective
> hits at http://www.denx.de/wiki/U-Boot/Patches ; then clean up the
> code and resubmit.
> 
> Um, and while doing so, please make sure NOT to send all this stuff
> base64 encoded.  Thanks.
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #130: FILE: arch/arm/lib/bootm.c:128:
> +	s = getenv ("atagaddr");

see file arch/arm/lib/bootm.c - it has this code styling. so this is not error 
unless you want to mix more code styling in one file.

> 
> WARNING: consider using kstrto* in preference to simple_strtoul
> #132: FILE: arch/arm/lib/bootm.c:130:
> +		bd->bi_boot_params = simple_strtoul(s, NULL, 16);

really? I was not able to find kstrtoul function

> 
> WARNING: space prohibited between function name and open parenthesis '('
> #137: FILE: arch/arm/lib/bootm.c:135:
> +			params = tag_next (params);
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #145: FILE: arch/arm/lib/bootm.c:142:
> +		setup_start_tag (bd);
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #162: FILE: arch/arm/lib/bootm.c:167:
> +#if defined (CONFIG_SETUP_MEMORY_TAGS) || \
> 
> WARNING: please, no spaces at the start of a line
> #163: FILE: arch/arm/lib/bootm.c:168:
> +    defined (CONFIG_CMDLINE_TAG) || \$
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #163: FILE: arch/arm/lib/bootm.c:168:
> +    defined (CONFIG_CMDLINE_TAG) || \
> 
> WARNING: please, no spaces at the start of a line
> #164: FILE: arch/arm/lib/bootm.c:169:
> +    defined (CONFIG_INITRD_TAG) || \$
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #164: FILE: arch/arm/lib/bootm.c:169:
> +    defined (CONFIG_INITRD_TAG) || \
> 
> WARNING: please, no spaces at the start of a line
> #165: FILE: arch/arm/lib/bootm.c:170:
> +    defined (CONFIG_SERIAL_TAG) || \$
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #165: FILE: arch/arm/lib/bootm.c:170:
> +    defined (CONFIG_SERIAL_TAG) || \
> 
> WARNING: please, no spaces at the start of a line
> #166: FILE: arch/arm/lib/bootm.c:171:
> +    defined (CONFIG_REVISION_TAG)$
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #166: FILE: arch/arm/lib/bootm.c:171:
> +    defined (CONFIG_REVISION_TAG)
> 
> total: 0 errors, 13 warnings, 53 lines checked
> 
> /home/wd/Mail/U-Boot/12777 has style problems, please review.

same - see my first comment

> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> ERROR: space prohibited after that open parenthesis '('
> #194: FILE: include/twl4030.h:238:
> +	( (devgrp) << 13 | 1 << 12 | (grp) << 9 | (type2) << 7 \
> 
> total: 1 errors, 0 warnings, 110 lines checked
> 
> /home/wd/Mail/U-Boot/12778 has style problems, please review.

see commit message - this patch is from linux upstream and uf u-boot has same 
styling this should be ok too.

> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> total: 0 errors, 0 warnings, 24 lines checked
> 
> /home/wd/Mail/U-Boot/12779 has no obvious style problems and is ready for
> submission. WARNING: line over 80 characters
> #117: FILE: common/main.c:1028:
> +		case '\e':				/* ANSI escape char	*/

again - same formating in file common/main.c

> 
> WARNING: line over 80 characters
> #145: FILE: common/main.c:1056:
> +				/* Ignore ANSI escape sequences generated by keyboard */
> 
> ERROR: space prohibited after that open parenthesis '('
> #147: FILE: common/main.c:1058:
> +				if ( c >= 'A' && c <= 'D' ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #147: FILE: common/main.c:1058:
> +				if ( c >= 'A' && c <= 'D' ) {

Ok, this problem I fix.

> 
> WARNING: line over 80 characters
> #156: FILE: common/main.c:1067:
> +				} else if (esc == 3 && n < CONFIG_SYS_CBSIZE-4) {
> 
> total: 2 errors, 3 warnings, 62 lines checked
> 
> /home/wd/Mail/U-Boot/12780 has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> total: 0 errors, 0 warnings, 8 lines checked
> 
> /home/wd/Mail/U-Boot/12781 has no obvious style problems and is ready for
> submission. WARNING: line over 80 characters
> #129: FILE: drivers/video/cfb_console.c:712:
> +	video_hw_rectfill(VIDEO_PIXEL_SIZE,				/* bytes per pixel */
> 
> WARNING: line over 80 characters
> #130: FILE: drivers/video/cfb_console.c:713:
> +			  VIDEO_FONT_WIDTH * begin,			/* dest pos x */  /* FIXME: 
correct? */
> 
> WARNING: line over 80 characters
> #131: FILE: drivers/video/cfb_console.c:714:
> +			  video_logo_height + CONSOLE_ROW_SIZE * line,	/* dest pos y */  
/*
> FIXME: correct? */
> 
> WARNING: line over 80 characters
> #132: FILE: drivers/video/cfb_console.c:715:
> +			  VIDEO_FONT_WIDTH * ( end - begin ),		/* frame width */ /* 
FIXME:
> correct? */
> 
> ERROR: space prohibited after that open parenthesis '('
> #132: FILE: drivers/video/cfb_console.c:715:
> +			  VIDEO_FONT_WIDTH * ( end - begin ),		/* frame width */ /* 
FIXME:
> correct? */
> 
> ERROR: space prohibited before that close parenthesis ')'
> #132: FILE: drivers/video/cfb_console.c:715:
> +			  VIDEO_FONT_WIDTH * ( end - begin ),		/* frame width */ /* 
FIXME:
> correct? */
> 
> WARNING: line over 80 characters
> #133: FILE: drivers/video/cfb_console.c:716:
> +			  VIDEO_FONT_HEIGHT,				/* frame height */
> 
> WARNING: line over 80 characters
> #134: FILE: drivers/video/cfb_console.c:717:
> +			  bgx						/* fill color */

If you want I remove above comments /* ... */

> 
> ERROR: space prohibited after that open parenthesis '('
> #138: FILE: drivers/video/cfb_console.c:721:
> +	if ( begin == 0 && end == CONSOLE_COLS )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #138: FILE: drivers/video/cfb_console.c:721:
> +	if ( begin == 0 && end == CONSOLE_COLS )

I will fix this.

> 
> WARNING: line over 80 characters
> #139: FILE: drivers/video/cfb_console.c:722:
> +		memsetl(CONSOLE_ROW_FIRST + CONSOLE_ROW_SIZE * line,	/* offset of row 
*/
> 
> WARNING: line over 80 characters
> #140: FILE: drivers/video/cfb_console.c:723:
> +			CONSOLE_ROW_SIZE >> 2,				/* length of row */
> 
> WARNING: line over 80 characters
> #141: FILE: drivers/video/cfb_console.c:724:
> +			bgx						/* fill color */
> 
> ERROR: space prohibited after that open parenthesis '('
> #144: FILE: drivers/video/cfb_console.c:727:
> +		for ( i = 0; i < VIDEO_FONT_HEIGHT; ++i )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #144: FILE: drivers/video/cfb_console.c:727:
> +		for ( i = 0; i < VIDEO_FONT_HEIGHT; ++i )

Also I fix this.

> 
> WARNING: line over 80 characters
> #145: FILE: drivers/video/cfb_console.c:728:
> +			memsetl(CONSOLE_ROW_FIRST + CONSOLE_ROW_SIZE * line +	/* offset of 
row
> */
> 
> WARNING: line over 80 characters
> #146: FILE: drivers/video/cfb_console.c:729:
> +				VIDEO_FONT_WIDTH * VIDEO_PIXEL_SIZE * begin +	/* offset of 
col */
> 
> WARNING: line over 80 characters
> #147: FILE: drivers/video/cfb_console.c:730:
> +				i * VIDEO_LINE_LEN,				/* col offset of i-th line */
> 
> WARNING: line over 80 characters
> #148: FILE: drivers/video/cfb_console.c:731:
> +				(VIDEO_FONT_WIDTH * VIDEO_PIXEL_SIZE * ( end - begin + 1)) >> 
2, /*
> length to end of line */
> 
> ERROR: space prohibited after that open parenthesis '('
> #148: FILE: drivers/video/cfb_console.c:731:
> +				(VIDEO_FONT_WIDTH * VIDEO_PIXEL_SIZE * ( end - begin + 1)) >> 
2, /*
> length to end of line */
> 
> WARNING: line over 80 characters
> #149: FILE: drivers/video/cfb_console.c:732:
> +				bgx						/* fill color */
> 
> total: 7 errors, 14 warnings, 68 lines checked
> 
> /home/wd/Mail/U-Boot/12782 has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> total: 0 errors, 0 warnings, 98 lines checked
> 
> /home/wd/Mail/U-Boot/12783 has no obvious style problems and is ready for
> submission. ERROR: do not initialise statics to 0 or NULL
> #112: FILE: drivers/video/cfb_console.c:381:
> +static int ansi_buf_size = 0;
> 
> ERROR: do not initialise statics to 0 or NULL
> #113: FILE: drivers/video/cfb_console.c:382:
> +static int ansi_colors_need_revert = 0;

what is problem with initialising to 0?

> 
> WARNING: space prohibited between function name and open parenthesis '('
> #166: FILE: drivers/video/cfb_console.c:930:
> +		if (ansi_buf_size >= sizeof (ansi_buf))
> 
> WARNING: line over 80 characters
> #236: FILE: drivers/video/cfb_console.c:1000:
> +				if ((ansi_buf[i] >= 'A' && ansi_buf[i] <= 'H') || ansi_buf[i] 
== 'J' ||
> ansi_buf[i] == 'K' || ansi_buf[i] == 'm') {
> 
> ERROR: that open brace { should be on the previous line
> #245: FILE: drivers/video/cfb_console.c:1009:
> +		if (fail)
> +		{
> 
> ERROR: that open brace { should be on the previous line
> #253: FILE: drivers/video/cfb_console.c:1017:
> +		if (flush)
> +		{

Also I will fix above problems with braces.

> 
> WARNING: line over 80 characters
> #298: FILE: drivers/video/cfb_console.c:1062:
> +					console_clear_line(console_row, console_col, 
CONSOLE_COLS-1);
> 
> WARNING: line over 80 characters
> #300: FILE: drivers/video/cfb_console.c:1064:
> +					console_clear_line(console_row, 0, console_col);
> 
> WARNING: line over 80 characters
> #302: FILE: drivers/video/cfb_console.c:1066:
> +					console_clear_line(console_row, 0, CONSOLE_COLS-1);
> 
> WARNING: line over 80 characters
> #310: FILE: drivers/video/cfb_console.c:1074:
> +				} else if (num1 == 7) { /* swap colors (only once) */
> 
> ERROR: that open brace { should be on the previous line
> #321: FILE: drivers/video/cfb_console.c:1085:
> +	else
> +	{
> 
> ERROR: else should follow close brace '}'
> #321: FILE: drivers/video/cfb_console.c:1085:
> +	}
> +	else
> 
> total: 6 errors, 6 warnings, 223 lines checked
> 
> /home/wd/Mail/U-Boot/12784 has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> total: 0 errors, 0 warnings, 14 lines checked
> 
> /home/wd/Mail/U-Boot/12785 has no obvious style problems and is ready for
> submission. total: 0 errors, 0 warnings, 52 lines checked
> 
> /home/wd/Mail/U-Boot/12786 has no obvious style problems and is ready for
> submission. WARNING: line over 80 characters
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 )
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 )
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 )
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 ) ^
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 ) ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #113: FILE: common/main.c:85:
> +#if defined (CONFIG_MENUKEY) && ! defined (CONFIG_MENUCMD) && ( !
> defined(CONFIG_BOOTDELAY) || CONFIG_BOOTDELAY < 0 )
> 
> WARNING: line over 80 characters
> #114: FILE: common/main.c:86:
> +#error CONFIG_MENUKEY is defined, but not CONFIG_MENUCMD and/or
> CONFIG_BOOTDELAY >= 0
> 
> ERROR: do not initialise statics to 0 or NULL
> #120: FILE: common/main.c:92:
> +static int menucmd = 0;
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #146: FILE: common/main.c:253:
> +# if defined (CONFIG_MENUCMD) && defined (CONFIG_MENUKEY)
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #146: FILE: common/main.c:253:
> +# if defined (CONFIG_MENUCMD) && defined (CONFIG_MENUKEY)
> 
> WARNING: line over 80 characters
> #147: FILE: common/main.c:254:
> +				if (CONFIG_MENUKEY == 0 || CONFIG_MENUKEY == getc())
> 
> total: 5 errors, 7 warnings, 73 lines checked
> 
> /home/wd/Mail/U-Boot/12787 has style problems, please review.

Ok, I will fix this file.

> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: space prohibited between function name and open parenthesis '('
> #125: FILE: common/main.c:429:
> +	if ((s = getenv ("premonitor")) != NULL) {
> 
> ERROR: do not use assignment in if condition
> #125: FILE: common/main.c:429:
> +	if ((s = getenv ("premonitor")) != NULL) {
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #127: FILE: common/main.c:431:
> +		run_command (s, 0);
> 
> WARNING: line over 80 characters
> #129: FILE: common/main.c:433:
> +		parse_string_outer(s, FLAG_PARSE_SEMICOLON | FLAG_EXIT_FROM_LOOP);
> 
> total: 1 errors, 3 warnings, 25 lines checked
> 
> /home/wd/Mail/U-Boot/12788 has style problems, please review.

I will fix this too.

> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: externs should be avoided in .c files
> #282: FILE: board/nokia/rx51/rx51.c:59:
> +extern u32 rx51_atagaddr; /* atag address */
> 
> WARNING: externs should be avoided in .c files
> #283: FILE: board/nokia/rx51/rx51.c:60:
> +extern u32 rx51_kernaddr; /* attached kernel address */
> 
> WARNING: line over 80 characters
> #297: FILE: board/nokia/rx51/rx51.c:74:
> +"startaddr:\n"				/* address where should be u-boot after 
relocation */
> 
> WARNING: line over 80 characters
> #299: FILE: board/nokia/rx51/rx51.c:76:
> +"relocaddr:\n"				/* address of this relocaddr section after 
relocation */
> 
> WARNING: line over 80 characters
> #300: FILE: board/nokia/rx51/rx51.c:77:
> +"	.word .\n"			/* dot - address of this section (calculated at 
compile
> time, so same as after relocation) */
> 
> WARNING: line over 80 characters
> #307: FILE: board/nokia/rx51/rx51.c:84:
> +"kernaddr:\n"				/* stored attached kernel address (u-boot + 
0x40000) */
> 
> WARNING: line over 80 characters
> #310: FILE: board/nokia/rx51/rx51.c:87:
> +"save_boot_params:\n"			/* function save_boot_params, called after 
reset */
> 
> WARNING: line over 80 characters
> #313: FILE: board/nokia/rx51/rx51.c:90:
> +"	ldr	r1, relocaddr\n"	/* r1 - address where should be this relocaddr
> section after relocation */
> 
> WARNING: line over 80 characters
> #314: FILE: board/nokia/rx51/rx51.c:91:
> +"	sub	r0, r0, r1\n"		/* r1 - calculated offset for relocation */
> 
> WARNING: line over 80 characters
> #315: FILE: board/nokia/rx51/rx51.c:92:
> +"	ldr	r1, startaddr\n"	/* r1 - address where u-boot should be after
> relocation */
> 
> WARNING: line over 80 characters
> #316: FILE: board/nokia/rx51/rx51.c:93:
> +"	add	r0, r0, r1\n"		/* r0 - address where is u-boot (address after
> relocation + offset) */
> 
> WARNING: line over 80 characters
> #319: FILE: board/nokia/rx51/rx51.c:96:
> +"	bne	reloc\n"		/* start relocation if u-boot is not loaded at correct
> address CONFIG_SYS_TEXT_BASE */
> 
> WARNING: line over 80 characters
> #320: FILE: board/nokia/rx51/rx51.c:97:
> +"	bx	lr\n"			/* else return back to reset section (relocation is 
not
> needed) */
> 
> WARNING: line over 80 characters
> #324: FILE: board/nokia/rx51/rx51.c:101:
> +"	add	r2, r0, #0x40000\n"	/* r2 - address where is attached kernel (u-
boot
> address + kernel offset 0x40000) - also end address of u-boot */
> 
> WARNING: line over 80 characters
> #334: FILE: board/nokia/rx51/rx51.c:111:
> +"	ldr	pc, startaddr\n"	/* jump to start section (where should be u-boot
> after relocation) and restart u-boot */
> 
> WARNING: line over 80 characters
> #375: FILE: board/nokia/rx51/rx51.c:152:
> +	twl4030_i2c_write_u8(TWL4030_CHIP_PM_MASTER, msg >> 8,
> TWL4030_PM_MASTER_PB_WORD_MSB);
> 
> WARNING: line over 80 characters
> #376: FILE: board/nokia/rx51/rx51.c:153:
> +	twl4030_i2c_write_u8(TWL4030_CHIP_PM_MASTER, msg & 0xff,
> TWL4030_PM_MASTER_PB_WORD_LSB);
> 
> WARNING: line over 80 characters
> #403: FILE: board/nokia/rx51/rx51.c:180:
> +	twl4030_i2c_write_u8(TWL4030_CHIP_PM_MASTER, 0x02,
> TWL4030_PM_MASTER_PB_CFG);
> 
> ERROR: do not initialise statics to 0 or NULL
> #432: FILE: board/nokia/rx51/rx51.c:209:
> +static unsigned long int twl_wd_time = 0; /* last time of watchdog reset */
> 
> WARNING: Use of volatile is usually wrong: see
> Documentation/volatile-considered-harmful.txt #433: FILE:
> board/nokia/rx51/rx51.c:210:
> +static volatile unsigned long int twl_i2c_lock;
> 
> ERROR: space prohibited after that open parenthesis '('
> #444: FILE: board/nokia/rx51/rx51.c:221:
> +	if ( get_timer(twl_wd_time) < 4 * CONFIG_SYS_HZ )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #444: FILE: board/nokia/rx51/rx51.c:221:
> +	if ( get_timer(twl_wd_time) < 4 * CONFIG_SYS_HZ )
> 
> ERROR: space prohibited after that open parenthesis '('
> #448: FILE: board/nokia/rx51/rx51.c:225:
> +	if ( test_and_set_bit(0, &twl_i2c_lock) )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #448: FILE: board/nokia/rx51/rx51.c:225:
> +	if ( test_and_set_bit(0, &twl_i2c_lock) )
> 
> WARNING: line over 80 characters
> #452: FILE: board/nokia/rx51/rx51.c:229:
> +	twl4030_i2c_read_u8(TWL4030_CHIP_PM_RECEIVER, &timeout,
> TWL4030_PM_RECEIVER_WATCHDOG_CFG);
> 
> ERROR: space prohibited after that open parenthesis '('
> #456: FILE: board/nokia/rx51/rx51.c:233:
> +	if ( timeout != 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #456: FILE: board/nokia/rx51/rx51.c:233:
> +	if ( timeout != 0 )
> 
> WARNING: line over 80 characters
> #457: FILE: board/nokia/rx51/rx51.c:234:
> +		twl4030_i2c_write_u8(TWL4030_CHIP_PM_RECEIVER, 31,
> TWL4030_PM_RECEIVER_WATCHDOG_CFG);
> 
> ERROR: do not initialise statics to 0 or NULL
> #495: FILE: board/nokia/rx51/rx51.c:272:
> +static u8 keybuf_head = 0;
> 
> ERROR: do not initialise statics to 0 or NULL
> #496: FILE: board/nokia/rx51/rx51.c:273:
> +static u8 keybuf_tail = 0;
> 
> WARNING: line over 80 characters
> #532: FILE: board/nokia/rx51/rx51.c:309:
> +	if (!(mods & 2) && (k == 18 || k == 31 || k == 33 || k == 34)) { /* cursor
> keys, without fn */
> 
> ERROR: space prohibited after that open parenthesis '('
> #582: FILE: board/nokia/rx51/rx51.c:359:
> +	if ( test_and_set_bit(0, &twl_i2c_lock) )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #582: FILE: board/nokia/rx51/rx51.c:359:
> +	if ( test_and_set_bit(0, &twl_i2c_lock) )

I will look at rx51.c file

> 
> WARNING: line over 80 characters
> #764: FILE: board/nokia/rx51/rx51.h:108:
> +	MUX_VAL(CP(GPMC_NCS6),		(IEN  | PTD | DIS | M1)) /*SYS_nDMA_REQ2*/\
> 
> WARNING: line over 80 characters
> #765: FILE: board/nokia/rx51/rx51.h:109:
> +	MUX_VAL(CP(GPMC_NCS7),		(IEN  | PTU | EN  | M1)) /*SYS_nDMA_REQ3*/\
> 
> WARNING: line over 80 characters
> #770: FILE: board/nokia/rx51/rx51.h:114:
> +	MUX_VAL(CP(GPMC_NADV_ALE),	(IDIS | PTD | DIS | M0)) /*GPMC_nADV_ALE*/\
> 
> WARNING: line over 80 characters
> #773: FILE: board/nokia/rx51/rx51.h:117:
> +	MUX_VAL(CP(GPMC_NBE0_CLE),	(IDIS | PTD | DIS | M0)) /*GPMC_nBE0_CLE*/\
> 
> WARNING: line over 80 characters
> #833: FILE: board/nokia/rx51/rx51.h:177:
> +	MUX_VAL(CP(MCBSP2_CLKX),	(IEN  | PTD | DIS | M0)) /*McBSP2_CLKX*/\
> 
> WARNING: line over 80 characters
> #872: FILE: board/nokia/rx51/rx51.h:216:
> +	MUX_VAL(CP(MCBSP4_CLKX),	(IEN  | PTD | DIS | M1)) /*SSI1_DAT_RX*/\
> 
> WARNING: line over 80 characters
> #873: FILE: board/nokia/rx51/rx51.h:217:
> +	MUX_VAL(CP(MCBSP4_DR),		(IEN  | PTD | DIS | M1)) /*SSI1_FLAG_RX*/\
> 
> WARNING: line over 80 characters
> #874: FILE: board/nokia/rx51/rx51.h:218:
> +	MUX_VAL(CP(MCBSP4_DX),		(IEN  | PTD | DIS | M1)) /*SSI1_RDY_RX*/\
> 
> WARNING: line over 80 characters
> #884: FILE: board/nokia/rx51/rx51.h:228:
> +	MUX_VAL(CP(UART3_CTS_RCTX),	(IEN  | PTD | EN  | M0)) /*UART3_CTS_RCTX*/\
> 
> WARNING: line over 80 characters
> #885: FILE: board/nokia/rx51/rx51.h:229:
> +	MUX_VAL(CP(UART3_RTS_SD),	(IDIS | PTD | DIS | M0)) /*UART3_RTS_SD */\
> 
> WARNING: line over 80 characters
> #886: FILE: board/nokia/rx51/rx51.h:230:
> +	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX_IRRX*/\
> 
> WARNING: line over 80 characters
> #887: FILE: board/nokia/rx51/rx51.h:231:
> +	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX_IRTX*/\
> 
> WARNING: line over 80 characters
> #892: FILE: board/nokia/rx51/rx51.h:236:
> +	MUX_VAL(CP(HSUSB0_DATA0),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA0*/\
> 
> WARNING: line over 80 characters
> #893: FILE: board/nokia/rx51/rx51.h:237:
> +	MUX_VAL(CP(HSUSB0_DATA1),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA1*/\
> 
> WARNING: line over 80 characters
> #894: FILE: board/nokia/rx51/rx51.h:238:
> +	MUX_VAL(CP(HSUSB0_DATA2),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA2*/\
> 
> WARNING: line over 80 characters
> #895: FILE: board/nokia/rx51/rx51.h:239:
> +	MUX_VAL(CP(HSUSB0_DATA3),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA3*/\
> 
> WARNING: line over 80 characters
> #896: FILE: board/nokia/rx51/rx51.h:240:
> +	MUX_VAL(CP(HSUSB0_DATA4),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA4*/\
> 
> WARNING: line over 80 characters
> #897: FILE: board/nokia/rx51/rx51.h:241:
> +	MUX_VAL(CP(HSUSB0_DATA5),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA5*/\
> 
> WARNING: line over 80 characters
> #898: FILE: board/nokia/rx51/rx51.h:242:
> +	MUX_VAL(CP(HSUSB0_DATA6),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA6*/\
> 
> WARNING: line over 80 characters
> #899: FILE: board/nokia/rx51/rx51.h:243:
> +	MUX_VAL(CP(HSUSB0_DATA7),	(IEN  | PTD | DIS | M0)) /*HSUSB0_DATA7*/\
> 
> WARNING: line over 80 characters
> #911: FILE: board/nokia/rx51/rx51.h:255:
> +	MUX_VAL(CP(MCSPI1_SOMI),	(IEN  | PTD | DIS | M0)) /*McSPI1_SOMI*/\
> 
> WARNING: line over 80 characters
> #916: FILE: board/nokia/rx51/rx51.h:260:
> +	MUX_VAL(CP(MCSPI1_CS3),		(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA2*/\
> 
> WARNING: line over 80 characters
> #917: FILE: board/nokia/rx51/rx51.h:261:
> +	MUX_VAL(CP(MCSPI2_CLK),		(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA7*/\
> 
> WARNING: line over 80 characters
> #918: FILE: board/nokia/rx51/rx51.h:262:
> +	MUX_VAL(CP(MCSPI2_SIMO),	(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA4*/\
> 
> WARNING: line over 80 characters
> #919: FILE: board/nokia/rx51/rx51.h:263:
> +	MUX_VAL(CP(MCSPI2_SOMI),	(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA5*/\
> 
> WARNING: line over 80 characters
> #920: FILE: board/nokia/rx51/rx51.h:264:
> +	MUX_VAL(CP(MCSPI2_CS0),		(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA6*/\
> 
> WARNING: line over 80 characters
> #921: FILE: board/nokia/rx51/rx51.h:265:
> +	MUX_VAL(CP(MCSPI2_CS1),		(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA3*/\
> 
> WARNING: line over 80 characters
> #926: FILE: board/nokia/rx51/rx51.h:270:
> +	MUX_VAL(CP(ETK_D14_ES2),	(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA0*/\
> 
> WARNING: line over 80 characters
> #927: FILE: board/nokia/rx51/rx51.h:271:
> +	MUX_VAL(CP(ETK_D15_ES2),	(IEN  | PTU | DIS | M3)) /*HSUSB2_DATA1*/\
> 
> WARNING: line over 80 characters
> #934: FILE: board/nokia/rx51/rx51.h:278:
> +	MUX_VAL(CP(SYS_BOOT2),		(IEN  | PTD | DIS | M4)) /*GPIO_4 - MMC1_WP*/\
> 
> WARNING: line over 80 characters
> #939: FILE: board/nokia/rx51/rx51.h:283:
> +	MUX_VAL(CP(SYS_OFF_MODE),	(IEN  | PTD | DIS | M0)) /*SYS_OFF_MODE*/\
> 
> WARNING: line over 80 characters
> #940: FILE: board/nokia/rx51/rx51.h:284:
> +	MUX_VAL(CP(SYS_CLKOUT1),	(IEN  | PTD | DIS | M0)) /*SYS_CLKOUT1*/\
> 
> WARNING: line over 80 characters
> #944: FILE: board/nokia/rx51/rx51.h:288:
> +	MUX_VAL(CP(ETK_D0_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA0*/\
> 
> WARNING: line over 80 characters
> #945: FILE: board/nokia/rx51/rx51.h:289:
> +	MUX_VAL(CP(ETK_D1_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA1*/\
> 
> WARNING: line over 80 characters
> #946: FILE: board/nokia/rx51/rx51.h:290:
> +	MUX_VAL(CP(ETK_D2_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA2*/\
> 
> WARNING: line over 80 characters
> #947: FILE: board/nokia/rx51/rx51.h:291:
> +	MUX_VAL(CP(ETK_D3_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA7*/\
> 
> WARNING: line over 80 characters
> #948: FILE: board/nokia/rx51/rx51.h:292:
> +	MUX_VAL(CP(ETK_D4_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA4*/\
> 
> WARNING: line over 80 characters
> #949: FILE: board/nokia/rx51/rx51.h:293:
> +	MUX_VAL(CP(ETK_D5_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA5*/\
> 
> WARNING: line over 80 characters
> #950: FILE: board/nokia/rx51/rx51.h:294:
> +	MUX_VAL(CP(ETK_D6_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA6*/\
> 
> WARNING: line over 80 characters
> #951: FILE: board/nokia/rx51/rx51.h:295:
> +	MUX_VAL(CP(ETK_D7_ES2),		(IEN  | PTU | DIS | M3)) /*HSUSB1_DATA3*/\
> 
> WARNING: line over 80 characters
> #990: FILE: board/nokia/rx51/rx51.h:334:
> +	MUX_VAL(CP(D2D_CLK26MI),	(IEN  | PTD | DIS | M0)) /*d2d_clk26mi*/\
> 
> WARNING: line over 80 characters
> #991: FILE: board/nokia/rx51/rx51.h:335:
> +	MUX_VAL(CP(D2D_NRESPWRON),	(IEN  | PTD | EN  | M0)) /*d2d_nrespwron*/\
> 
> WARNING: line over 80 characters
> #992: FILE: board/nokia/rx51/rx51.h:336:
> +	MUX_VAL(CP(D2D_NRESWARM),	(IEN  | PTU | EN  | M0)) /*d2d_nreswarm */\
> 
> WARNING: line over 80 characters
> #993: FILE: board/nokia/rx51/rx51.h:337:
> +	MUX_VAL(CP(D2D_ARM9NIRQ),	(IEN  | PTD | DIS | M0)) /*d2d_arm9nirq */\
> 
> WARNING: line over 80 characters
> #994: FILE: board/nokia/rx51/rx51.h:338:
> +	MUX_VAL(CP(D2D_UMA2P6FIQ),	(IEN  | PTD | DIS | M0)) /*d2d_uma2p6fiq*/\
> 
> WARNING: line over 80 characters
> #997: FILE: board/nokia/rx51/rx51.h:341:
> +	MUX_VAL(CP(D2D_DMAREQ0),	(IEN  | PTD | DIS | M0)) /*d2d_dmareq0*/\
> 
> WARNING: line over 80 characters
> #998: FILE: board/nokia/rx51/rx51.h:342:
> +	MUX_VAL(CP(D2D_DMAREQ1),	(IEN  | PTD | DIS | M0)) /*d2d_dmareq1*/\
> 
> WARNING: line over 80 characters
> #999: FILE: board/nokia/rx51/rx51.h:343:
> +	MUX_VAL(CP(D2D_DMAREQ2),	(IEN  | PTD | DIS | M0)) /*d2d_dmareq2*/\
> 
> WARNING: line over 80 characters
> #1000: FILE: board/nokia/rx51/rx51.h:344:
> +	MUX_VAL(CP(D2D_DMAREQ3),	(IEN  | PTD | DIS | M0)) /*d2d_dmareq3*/\
> 
> WARNING: line over 80 characters
> #1001: FILE: board/nokia/rx51/rx51.h:345:
> +	MUX_VAL(CP(D2D_N3GTRST),	(IEN  | PTD | DIS | M0)) /*d2d_n3gtrst*/\
> 
> WARNING: line over 80 characters
> #1006: FILE: board/nokia/rx51/rx51.h:350:
> +	MUX_VAL(CP(D2D_N3GRTCK),	(IEN  | PTD | DIS | M0)) /*d2d_n3grtck*/\
> 
> WARNING: line over 80 characters
> #1008: FILE: board/nokia/rx51/rx51.h:352:
> +	MUX_VAL(CP(D2D_SWAKEUP),	(IEN  | PTD | EN  | M0)) /*d2d_swakeup*/\
> 
> WARNING: line over 80 characters
> #1009: FILE: board/nokia/rx51/rx51.h:353:
> +	MUX_VAL(CP(D2D_IDLEREQ),	(IEN  | PTD | DIS | M0)) /*d2d_idlereq*/\
> 
> WARNING: line over 80 characters
> #1010: FILE: board/nokia/rx51/rx51.h:354:
> +	MUX_VAL(CP(D2D_IDLEACK),	(IEN  | PTU | EN  | M0)) /*d2d_idleack*/\
> 
> WARNING: line over 80 characters
> #1015: FILE: board/nokia/rx51/rx51.h:359:
> +	MUX_VAL(CP(D2D_MBUSFLAG),	(IEN  | PTD | DIS | M0)) /*d2d_mbusflag*/\
> 
> WARNING: line over 80 characters
> #1016: FILE: board/nokia/rx51/rx51.h:360:
> +	MUX_VAL(CP(D2D_SBUSFLAG),	(IEN  | PTD | DIS | M0)) /*d2d_sbusflag*/\

This code was copied from beagle board.

> 
> WARNING: line over 80 characters
> #1088: FILE: include/configs/nokia_rx51.h:42:
> +#define CONFIG_ARMV7						/* This is an ARM V7 CPU core */
> 
> WARNING: line over 80 characters
> #1089: FILE: include/configs/nokia_rx51.h:43:
> +#define CONFIG_OMAP						/* in a TI OMAP core */
> 
> WARNING: line over 80 characters
> #1090: FILE: include/configs/nokia_rx51.h:44:
> +#define CONFIG_OMAP34XX						/* which is a 34XX */
> 
> WARNING: line over 80 characters
> #1091: FILE: include/configs/nokia_rx51.h:45:
> +#define CONFIG_OMAP3430						/* which is in a 3430 */
> 
> WARNING: line over 80 characters
> #1092: FILE: include/configs/nokia_rx51.h:46:
> +#define CONFIG_CHAINLOADER					/* Loaded by NOLO */
> 
> WARNING: line over 80 characters
> #1093: FILE: include/configs/nokia_rx51.h:47:
> +#define CONFIG_L2_OFF						/* kernel won't boot if l2 
enabled (old u-boot
> tried but failed to enable it, due to a bug.) */
> 
> WARNING: line over 80 characters
> #1100: FILE: include/configs/nokia_rx51.h:54:
> +#define CONFIG_SDRC						/* The chip has SDRC controller */
> 
> WARNING: line over 80 characters
> #1102: FILE: include/configs/nokia_rx51.h:56:
> +#include <asm/arch/cpu.h>					/* get chip and board defs */
> 
> WARNING: line over 80 characters
> #1112: FILE: include/configs/nokia_rx51.h:66:
> +#define V_OSCK				26000000		/* Clock output from T2 */
> 
> WARNING: line over 80 characters
> #1115: FILE: include/configs/nokia_rx51.h:69:
> +#undef CONFIG_USE_IRQ						/* no support for IRQs */
> 
> WARNING: line over 80 characters
> #1117: FILE: include/configs/nokia_rx51.h:71:
> +#define CONFIG_SKIP_LOWLEVEL_INIT				/* NOLO set everything up */
> 
> WARNING: line over 80 characters
> #1119: FILE: include/configs/nokia_rx51.h:73:
> +#define CONFIG_CMDLINE_TAG					/* enable passing kernel 
command line string
> */
> 
> WARNING: line over 80 characters
> #1120: FILE: include/configs/nokia_rx51.h:74:
> +#define CONFIG_INITRD_TAG					/* enable passing initrd */
> 
> WARNING: line over 80 characters
> #1125: FILE: include/configs/nokia_rx51.h:79:
> +#define CONFIG_ENV_SIZE			(128 << 10)		/* 128 KiB Sector */
> 
> WARNING: line over 80 characters
> #1135: FILE: include/configs/nokia_rx51.h:89:
> +#define V_NS16550_CLK			48000000		/* 48MHz (APLL96/2) */
> 
> WARNING: line over 80 characters
> #1147: FILE: include/configs/nokia_rx51.h:101:
> +#define CONFIG_SERIAL3			3			/* UART3 on RX-51 */
> 
> ERROR: space required after that ',' (ctx:VxV)
> #1152: FILE: include/configs/nokia_rx51.h:106:
> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,115200}
>                                   	                                ^
> 
> WARNING: line over 80 characters
> #1176: FILE: include/configs/nokia_rx51.h:130:
> +#define CONFIG_CMD_EXT2						/* EXT2 Support */
> 
> WARNING: line over 80 characters
> #1177: FILE: include/configs/nokia_rx51.h:131:
> +#define CONFIG_CMD_FAT						/* FAT support */
> 
> WARNING: line over 80 characters
> #1179: FILE: include/configs/nokia_rx51.h:133:
> +#define CONFIG_CMD_I2C						/* I2C serial bus support */
> 
> WARNING: line over 80 characters
> #1180: FILE: include/configs/nokia_rx51.h:134:
> +#define CONFIG_CMD_MMC						/* MMC support */
> 
> WARNING: line over 80 characters
> #1181: FILE: include/configs/nokia_rx51.h:135:
> +#undef CONFIG_CMD_ONENAND					/* NAND support */
> 
> WARNING: line over 80 characters
> #1183: FILE: include/configs/nokia_rx51.h:137:
> +#define CONFIG_CMD_CLR						/* ANSI terminal clear screen 
command */
> 
> WARNING: line over 80 characters
> #1185: FILE: include/configs/nokia_rx51.h:139:
> +#undef CONFIG_CMD_FLASH						/* flinfo, erase, protect */
> 
> WARNING: line over 80 characters
> #1186: FILE: include/configs/nokia_rx51.h:140:
> +#undef CONFIG_CMD_FPGA						/* FPGA configuration Support 
*/
> 
> WARNING: line over 80 characters
> #1188: FILE: include/configs/nokia_rx51.h:142:
> +#undef CONFIG_CMD_IMLS						/* List all found images */
> 
> WARNING: line over 80 characters
> #1189: FILE: include/configs/nokia_rx51.h:143:
> +#undef CONFIG_CMD_NET						/* bootp, tftpboot, rarpboot 
*/
> 
> WARNING: line over 80 characters
> #1190: FILE: include/configs/nokia_rx51.h:144:
> +#undef CONFIG_CMD_NFS						/* NFS support */
> 
> WARNING: line over 80 characters
> #1216: FILE: include/configs/nokia_rx51.h:170:
> +#define CONFIG_CFB_CONSOLE_ANSI					/* Enable ANSI escape codes 
in
> framebuffer */

I think adding these comments are usefull - do you want to remove it?

> 
> WARNING: line over 80 characters
> #1249: FILE: include/configs/nokia_rx51.h:203:
> +	"scriptload=${mmctype}load mmc ${mmcnum}:${mmcpart} ${loadaddr}
> ${mmcfile}\0" \
> 
> WARNING: line over 80 characters
> #1250: FILE: include/configs/nokia_rx51.h:204:
> +	"scriptboot=echo Running ${mmcfile} from mmc ${mmcnum}:${mmcpart} ...;" \
> 
> WARNING: line over 80 characters
> #1252: FILE: include/configs/nokia_rx51.h:206:
> +	"uimageload=${mmctype}load mmc ${mmcnum}:${mmcpart} ${loadaddr}
> ${mmcfile}\0" \
> 
> WARNING: line over 80 characters
> #1253: FILE: include/configs/nokia_rx51.h:207:
> +	"uimageboot=echo Booting ${mmcfile} from mmc ${mmcnum}:${mmcpart} ...;" \
> 
> WARNING: line over 80 characters
> #1306: FILE: include/configs/nokia_rx51.h:260:
> +#define CONFIG_SYS_LONGHELP					/* undef to save memory */
> 
> WARNING: line over 80 characters
> #1307: FILE: include/configs/nokia_rx51.h:261:
> +#define CONFIG_SYS_HUSH_PARSER					/* use "hush" command parser 
*/
> 
> WARNING: line over 80 characters
> #1310: FILE: include/configs/nokia_rx51.h:264:
> +#define CONFIG_SYS_CBSIZE		256			/* Console I/O Buffer Size */
> 
> WARNING: line over 80 characters
> #1312: FILE: include/configs/nokia_rx51.h:266:
> +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + 
sizeof(CONFIG_SYS_PROMPT) +
> 16)
> 
> WARNING: line over 80 characters
> #1313: FILE: include/configs/nokia_rx51.h:267:
> +#define CONFIG_SYS_MAXARGS		16			/* max number of command args 
*/
> 
> WARNING: line over 80 characters
> #1317: FILE: include/configs/nokia_rx51.h:271:
> +#define CONFIG_SYS_MEMTEST_START	(OMAP34XX_SDRC_CS0)	/* memtest works on 
*/
> 
> WARNING: line over 80 characters
> #1318: FILE: include/configs/nokia_rx51.h:272:
> +#define CONFIG_SYS_MEMTEST_END		(OMAP34XX_SDRC_CS0 + 0x01F00000) /* 31MB 
*/
> 
> WARNING: line over 80 characters
> #1320: FILE: include/configs/nokia_rx51.h:274:
> +#define CONFIG_SYS_LOAD_ADDR		(OMAP34XX_SDRC_CS0)	/* default load 
address
> */
> 
> WARNING: line over 80 characters
> #1328: FILE: include/configs/nokia_rx51.h:282:
> +#define CONFIG_SYS_PTV			2			/* Divisor: 2^(PTV+1) => 8 */
> 
> WARNING: line over 80 characters
> #1336: FILE: include/configs/nokia_rx51.h:290:
> +#define CONFIG_STACKSIZE		(128 << 10)		/* regular stack 128 KiB */
> 
> WARNING: line over 80 characters
> #1338: FILE: include/configs/nokia_rx51.h:292:
> +#define CONFIG_STACKSIZE_IRQ		(4 << 10)		/* IRQ stack 4 KiB */
> 
> WARNING: line over 80 characters
> #1339: FILE: include/configs/nokia_rx51.h:293:
> +#define CONFIG_STACKSIZE_FIQ		(4 << 10)		/* FIQ stack 4 KiB */
> 
> WARNING: line over 80 characters
> #1345: FILE: include/configs/nokia_rx51.h:299:
> +#define CONFIG_NR_DRAM_BANKS		2			/* CS1 may or may not be 
populated */
> 
> WARNING: line over 80 characters
> #1361: FILE: include/configs/nokia_rx51.h:315:
> +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_INIT_RAM_ADDR +
> CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
> 
> total: 12 errors, 124 warnings, 1173 lines checked
> 
> /home/wd/Mail/U-Boot/12789 has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> ERROR: "foo * bar" should be "foo *bar"
> #178: FILE: common/cmd_bootmenu.c:32:
> +static char * get_option(int n) {
> 
> ERROR: open brace '{' following function declarations go on the next line
> #178: FILE: common/cmd_bootmenu.c:32:
> +static char * get_option(int n) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #182: FILE: common/cmd_bootmenu.c:36:
> +	if ( n < 0 || n > 99 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #182: FILE: common/cmd_bootmenu.c:36:
> +	if ( n < 0 || n > 99 )
> 
> ERROR: "foo * bar" should be "foo *bar"
> #191: FILE: common/cmd_bootmenu.c:45:
> +static char * get_end_of_title(char * str) {
> 
> ERROR: open brace '{' following function declarations go on the next line
> #191: FILE: common/cmd_bootmenu.c:45:
> +static char * get_end_of_title(char * str) {
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #193: FILE: common/cmd_bootmenu.c:47:
> +	if ( ! str )
>  	     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #193: FILE: common/cmd_bootmenu.c:47:
> +	if ( ! str )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #193: FILE: common/cmd_bootmenu.c:47:
> +	if ( ! str )
> 
> ERROR: "foo * bar" should be "foo *bar"
> #200: FILE: common/cmd_bootmenu.c:54:
> +static int print_title(char * begin, char * end) {
> 
> ERROR: open brace '{' following function declarations go on the next line
> #200: FILE: common/cmd_bootmenu.c:54:
> +static int print_title(char * begin, char * end) {
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #202: FILE: common/cmd_bootmenu.c:56:
> +	if ( ! begin || ! end || end < begin )
>  	     ^
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #202: FILE: common/cmd_bootmenu.c:56:
> +	if ( ! begin || ! end || end < begin )
>  	                ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #202: FILE: common/cmd_bootmenu.c:56:
> +	if ( ! begin || ! end || end < begin )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #202: FILE: common/cmd_bootmenu.c:56:
> +	if ( ! begin || ! end || end < begin )
> 
> ERROR: space prohibited after that open parenthesis '('
> #205: FILE: common/cmd_bootmenu.c:59:
> +	while ( begin != end )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #205: FILE: common/cmd_bootmenu.c:59:
> +	while ( begin != end )
> 
> ERROR: open brace '{' following function declarations go on the next line
> #212: FILE: common/cmd_bootmenu.c:66:
> +static int print_entry(int n, int reverse) {
> 
> ERROR: "foo * bar" should be "foo *bar"
> #214: FILE: common/cmd_bootmenu.c:68:
> +	char * str = get_option(n);
> 
> ERROR: "foo * bar" should be "foo *bar"
> #215: FILE: common/cmd_bootmenu.c:69:
> +	char * end = get_end_of_title(str);
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #217: FILE: common/cmd_bootmenu.c:71:
> +	if ( ! end )
>  	     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #217: FILE: common/cmd_bootmenu.c:71:
> +	if ( ! end )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #217: FILE: common/cmd_bootmenu.c:71:
> +	if ( ! end )
> 
> ERROR: space prohibited after that open parenthesis '('
> #222: FILE: common/cmd_bootmenu.c:76:
> +	if ( reverse )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #222: FILE: common/cmd_bootmenu.c:76:
> +	if ( reverse )
> 
> ERROR: space prohibited after that open parenthesis '('
> #229: FILE: common/cmd_bootmenu.c:83:
> +	if ( reverse )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #229: FILE: common/cmd_bootmenu.c:83:
> +	if ( reverse )
> 
> ERROR: open brace '{' following function declarations go on the next line
> #236: FILE: common/cmd_bootmenu.c:90:
> +static int print_menu(int active) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #248: FILE: common/cmd_bootmenu.c:102:
> +	while ( 1 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #248: FILE: common/cmd_bootmenu.c:102:
> +	while ( 1 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #252: FILE: common/cmd_bootmenu.c:106:
> +		if ( ret == 1 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #252: FILE: common/cmd_bootmenu.c:106:
> +		if ( ret == 1 )
> 
> ERROR: space prohibited after that open parenthesis '('
> #261: FILE: common/cmd_bootmenu.c:115:
> +	if ( n == active )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #261: FILE: common/cmd_bootmenu.c:115:
> +	if ( n == active )
> 
> ERROR: space prohibited after that open parenthesis '('
> #267: FILE: common/cmd_bootmenu.c:121:
> +	if ( n == active )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #267: FILE: common/cmd_bootmenu.c:121:
> +	if ( n == active )
> 
> ERROR: open brace '{' following function declarations go on the next line
> #282: FILE: common/cmd_bootmenu.c:136:
> +int do_bootmenu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> {
> 
> ERROR: "foo * bar" should be "foo *bar"
> #291: FILE: common/cmd_bootmenu.c:145:
> +	char * delay_str = NULL;
> 
> ERROR: space prohibited after that open parenthesis '('
> #293: FILE: common/cmd_bootmenu.c:147:
> +	if ( argc >= 2 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #293: FILE: common/cmd_bootmenu.c:147:
> +	if ( argc >= 2 )
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #296: FILE: common/cmd_bootmenu.c:150:
> +	if ( ! delay_str )
>  	     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #296: FILE: common/cmd_bootmenu.c:150:
> +	if ( ! delay_str )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #296: FILE: common/cmd_bootmenu.c:150:
> +	if ( ! delay_str )
> 
> ERROR: space prohibited after that open parenthesis '('
> #299: FILE: common/cmd_bootmenu.c:153:
> +	if ( delay_str )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #299: FILE: common/cmd_bootmenu.c:153:
> +	if ( delay_str )
> 
> WARNING: consider using kstrto* in preference to simple_strtol
> #300: FILE: common/cmd_bootmenu.c:154:
> +		delay = (int)simple_strtol(delay_str, NULL, 10);
> 
> ERROR: space prohibited after that open parenthesis '('
> #302: FILE: common/cmd_bootmenu.c:156:
> +	if ( delay == 0 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #302: FILE: common/cmd_bootmenu.c:156:
> +	if ( delay == 0 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #305: FILE: common/cmd_bootmenu.c:159:
> +		if ( get_end_of_title(get_option(0)) )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #305: FILE: common/cmd_bootmenu.c:159:
> +		if ( get_end_of_title(get_option(0)) )
> 
> ERROR: space prohibited after that open parenthesis '('
> #312: FILE: common/cmd_bootmenu.c:166:
> +	if ( delay < 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #312: FILE: common/cmd_bootmenu.c:166:
> +	if ( delay < 0 )
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #315: FILE: common/cmd_bootmenu.c:169:
> +	if ( ! instant ) {
>  	     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #315: FILE: common/cmd_bootmenu.c:169:
> +	if ( ! instant ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #315: FILE: common/cmd_bootmenu.c:169:
> +	if ( ! instant ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #322: FILE: common/cmd_bootmenu.c:176:
> +	while ( 1 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #322: FILE: common/cmd_bootmenu.c:176:
> +	while ( 1 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #324: FILE: common/cmd_bootmenu.c:178:
> +		if ( abort || delay > 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #324: FILE: common/cmd_bootmenu.c:178:
> +		if ( abort || delay > 0 )
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #327: FILE: common/cmd_bootmenu.c:181:
> +		if ( ! abort ) {
>  		     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #327: FILE: common/cmd_bootmenu.c:181:
> +		if ( ! abort ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #327: FILE: common/cmd_bootmenu.c:181:
> +		if ( ! abort ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #329: FILE: common/cmd_bootmenu.c:183:
> +			if ( delay > 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #329: FILE: common/cmd_bootmenu.c:183:
> +			if ( delay > 0 )
> 
> WARNING: line over 80 characters
> #330: FILE: common/cmd_bootmenu.c:184:
> +				printf("  Hit any key to stop autoboot: %2d ", delay);
> 
> ERROR: space prohibited after that open parenthesis '('
> #332: FILE: common/cmd_bootmenu.c:186:
> +			while ( delay > 0 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #332: FILE: common/cmd_bootmenu.c:186:
> +			while ( delay > 0 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #336: FILE: common/cmd_bootmenu.c:190:
> +				for ( i = 0; i < 100; ++i ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #336: FILE: common/cmd_bootmenu.c:190:
> +				for ( i = 0; i < 100; ++i ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #338: FILE: common/cmd_bootmenu.c:192:
> +					if ( tstc() ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #338: FILE: common/cmd_bootmenu.c:192:
> +					if ( tstc() ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #343: FILE: common/cmd_bootmenu.c:197:
> +						if ( key == '\e' ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #343: FILE: common/cmd_bootmenu.c:197:
> +						if ( key == '\e' ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #346: FILE: common/cmd_bootmenu.c:200:
> +						} else if ( key == '\r' )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #346: FILE: common/cmd_bootmenu.c:200:
> +						} else if ( key == '\r' )
> 
> ERROR: space prohibited after that open parenthesis '('
> #360: FILE: common/cmd_bootmenu.c:214:
> +				if ( abort )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #360: FILE: common/cmd_bootmenu.c:214:
> +				if ( abort )
> 
> ERROR: space prohibited after that open parenthesis '('
> #368: FILE: common/cmd_bootmenu.c:222:
> +			if ( delay <= 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #368: FILE: common/cmd_bootmenu.c:222:
> +			if ( delay <= 0 )
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #373: FILE: common/cmd_bootmenu.c:227:
> +			while ( ! tstc() ) {
>  			        ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #373: FILE: common/cmd_bootmenu.c:227:
> +			while ( ! tstc() ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #373: FILE: common/cmd_bootmenu.c:227:
> +			while ( ! tstc() ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #382: FILE: common/cmd_bootmenu.c:236:
> +			if ( esc == 0 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #382: FILE: common/cmd_bootmenu.c:236:
> +			if ( esc == 0 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #384: FILE: common/cmd_bootmenu.c:238:
> +				if ( key == '\e' ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #384: FILE: common/cmd_bootmenu.c:238:
> +				if ( key == '\e' ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #389: FILE: common/cmd_bootmenu.c:243:
> +			} else if ( esc == 1 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #389: FILE: common/cmd_bootmenu.c:243:
> +			} else if ( esc == 1 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #391: FILE: common/cmd_bootmenu.c:245:
> +				if ( key == '[' ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #391: FILE: common/cmd_bootmenu.c:245:
> +				if ( key == '[' ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #397: FILE: common/cmd_bootmenu.c:251:
> +			} else if ( esc == 2 || esc == 3 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #397: FILE: common/cmd_bootmenu.c:251:
> +			} else if ( esc == 2 || esc == 3 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #399: FILE: common/cmd_bootmenu.c:253:
> +				if ( esc == 2 && key == '1' ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #399: FILE: common/cmd_bootmenu.c:253:
> +				if ( esc == 2 && key == '1' ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #405: FILE: common/cmd_bootmenu.c:259:
> +				if ( key == 'A' )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #405: FILE: common/cmd_bootmenu.c:259:
> +				if ( key == 'A' )
> 
> ERROR: space prohibited after that open parenthesis '('
> #407: FILE: common/cmd_bootmenu.c:261:
> +				else if ( key == 'B' )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #407: FILE: common/cmd_bootmenu.c:261:
> +				else if ( key == 'B' )
> 
> ERROR: space prohibited after that open parenthesis '('
> #414: FILE: common/cmd_bootmenu.c:268:
> +			if ( key == '\r' )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #414: FILE: common/cmd_bootmenu.c:268:
> +			if ( key == '\r' )
> 
> ERROR: space prohibited after that open parenthesis '('
> #419: FILE: common/cmd_bootmenu.c:273:
> +		if ( key == 1 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #419: FILE: common/cmd_bootmenu.c:273:
> +		if ( key == 1 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #421: FILE: common/cmd_bootmenu.c:275:
> +			if ( active > 0 )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #421: FILE: common/cmd_bootmenu.c:275:
> +			if ( active > 0 )
> 
> ERROR: space prohibited after that open parenthesis '('
> #424: FILE: common/cmd_bootmenu.c:278:
> +		} else if ( key == 2 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #424: FILE: common/cmd_bootmenu.c:278:
> +		} else if ( key == 2 ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #426: FILE: common/cmd_bootmenu.c:280:
> +			if ( active < count )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #426: FILE: common/cmd_bootmenu.c:280:
> +			if ( active < count )
> 
> ERROR: space prohibited after that open parenthesis '('
> #429: FILE: common/cmd_bootmenu.c:283:
> +		} else if ( key == 3 ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #429: FILE: common/cmd_bootmenu.c:283:
> +		} else if ( key == 3 ) {
> 
> ERROR: "foo * bar" should be "foo *bar"
> #431: FILE: common/cmd_bootmenu.c:285:
> +			char * str;
> 
> ERROR: "foo * bar" should be "foo *bar"
> #432: FILE: common/cmd_bootmenu.c:286:
> +			char * end;
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #436: FILE: common/cmd_bootmenu.c:290:
> +			if ( ! instant ) {
>  			     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #436: FILE: common/cmd_bootmenu.c:290:
> +			if ( ! instant ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #436: FILE: common/cmd_bootmenu.c:290:
> +			if ( ! instant ) {
> 
> ERROR: space prohibited after that open parenthesis '('
> #446: FILE: common/cmd_bootmenu.c:300:
> +			if ( active == count ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #446: FILE: common/cmd_bootmenu.c:300:
> +			if ( active == count ) {
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #456: FILE: common/cmd_bootmenu.c:310:
> +			if ( ! end ) {
>  			     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #456: FILE: common/cmd_bootmenu.c:310:
> +			if ( ! end ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #456: FILE: common/cmd_bootmenu.c:310:
> +			if ( ! end ) {
> 
> WARNING: line over 80 characters
> #458: FILE: common/cmd_bootmenu.c:312:
> +				printf("Invalid Boot Menu entry %d\nStarting U-Boot 
console\n\n",
> active);
> 
> ERROR: space prohibited after that '!' (ctx:WxW)
> #463: FILE: common/cmd_bootmenu.c:317:
> +			if ( ! end[1] ) {
>  			     ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #463: FILE: common/cmd_bootmenu.c:317:
> +			if ( ! end[1] ) {
> 
> ERROR: space prohibited before that close parenthesis ')'
> #463: FILE: common/cmd_bootmenu.c:317:
> +			if ( ! end[1] ) {
> 
> WARNING: line over 80 characters
> #479: FILE: common/cmd_bootmenu.c:333:
> +			parse_string_outer(end+1, FLAG_PARSE_SEMICOLON | 
FLAG_EXIT_FROM_LOOP);
> 
> total: 121 errors, 4 warnings, 369 lines checked
> 
> /home/wd/Mail/U-Boot/12790 has style problems, please review.

I will look at this file and try to fix problems.

> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: line over 80 characters
> #111: FILE: include/configs/nokia_rx51.h:137:
> +#define CONFIG_CMD_BOOTMENU					/* ANSI terminal Boot Menu */
> 
> WARNING: line over 80 characters
> #140: FILE: include/configs/nokia_rx51.h:244:
> +		"setenv mmcnum 1; setenv mmcpart 1; setenv mmctype fat; setenv mmcfile
> bootmenu.scr;" \
> 
> total: 0 errors, 2 warnings, 48 lines checked
> 
> /home/wd/Mail/U-Boot/12791 has style problems, please review.
> 
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Best regards,
> 
> Wolfgang Denk

-- 
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111218/3d419837/attachment.pgp>