From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6227DC433DB for ; Wed, 20 Jan 2021 17:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3373122CE3 for ; Wed, 20 Jan 2021 17:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391278AbhATRQf (ORCPT ); Wed, 20 Jan 2021 12:16:35 -0500 Received: from smtp-fw-9103.amazon.com ([207.171.188.200]:48863 "EHLO smtp-fw-9103.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389565AbhATRMr (ORCPT ); Wed, 20 Jan 2021 12:12:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1611162767; x=1642698767; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=cdvhdSc+KJ2muMQJyh5ViJwhF3It4JZRnpRi6+TvWVQ=; b=L8FX8NlLlqtuJJdKd/DnB1v0pK18MN3H799Bp7UxPEDA3l5GA/vLRWLv efU8OUyOdusrqSWwf+HrEccI/pedYYbS1z9Kou9E+m8RAzSFUdtet/6qy InA7R0rYMsrv9Z5RcBTkVRRMgVohx1JOXmILedC78B/m+M7f2+bnLJDhc I=; X-IronPort-AV: E=Sophos;i="5.79,361,1602547200"; d="scan'208";a="912082822" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-c7f73527.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9103.sea19.amazon.com with ESMTP; 20 Jan 2021 17:11:25 +0000 Received: from EX13MTAUWC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1e-c7f73527.us-east-1.amazon.com (Postfix) with ESMTPS id 12F8FA26B9; Wed, 20 Jan 2021 17:11:22 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Jan 2021 17:11:22 +0000 Received: from edge-m1-r3-201.e-iad16.amazon.com (10.43.160.66) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Jan 2021 17:11:20 +0000 Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Mohamed Mediouni , CC: Mark Rutland , Catalin Marinas , Hector Martin , , Marc Zyngier , Will Deacon , Stan Skowronek References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> From: Alexander Graf Message-ID: <171d8c3f-aa0c-4416-b0d7-d35a47c7acc3@amazon.com> Date: Wed, 20 Jan 2021 18:11:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210120132717.395873-5-mohamed.mediouni@caramail.com> Content-Language: en-US X-Originating-IP: [10.43.160.66] X-ClientProxiedBy: EX13D36UWB004.ant.amazon.com (10.43.161.49) To EX13D20UWC001.ant.amazon.com (10.43.162.244) Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.21 14:27, Mohamed Mediouni wrote: > From: Stan Skowronek > = > Apple SoCs use the Apple AIC interrupt controller. > The Arm architectural timers is wired over FIQ on that hardware. > = > Signed-off-by: Stan Skowronek > Signed-off-by: Mohamed Mediouni > --- > .../interrupt-controller/apple,aic.yaml | 49 ++++ > MAINTAINERS | 6 + > drivers/irqchip/Kconfig | 6 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-apple-aic.c | 211 ++++++++++++++++++ > 5 files changed, 273 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controll= er/apple,aic.yaml > create mode 100644 drivers/irqchip/irq-apple-aic.c > = > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple= ,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,ai= c.yaml > new file mode 100644 > index 000000000000..e615eaaca869 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.ya= ml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Advanced Interrupt Controller (AIC) > + > +description: > + Interrupt controller present on Apple processors. AIC > + is used by Apple on their AArch64 SoCs since the Apple A7. > + > +maintainers: > + - Stan Skowronek > + > +properties: > + compatible: > + items: > + - const: apple,aic > + > + reg: > + maxItems: 1 > + > + '#interrupt-cells': > + const: 3 > + > + interrupt-controller: true > + > + fast-ipi: > + description: > + Fast IPI support. > + > +required: > + - compatible > + - '#interrupt-cells' > + - interrupt-controller > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + aic: interrupt-controller@23b100000 { > + compatible =3D "apple,aic"; > + #interrupt-cells =3D <3>; > + interrupt-controller; > + reg =3D <0x2 0x3b100000 0x0 0x8000>; > + fast-ipi; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 00836f6452f0..e609ede99dd4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1218,6 +1218,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/g= it/jj/linux-apparmor > F: Documentation/admin-guide/LSM/apparmor.rst > F: security/apparmor/ > = > +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER > +M: Stan Skowronek Signing someone else up for maintainership is ... unusual :). Do you = have buy in from Stan that he'll be responsive and handle patch reviews? > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/irqchip/irq-apple-aic.c > + Alex Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D460C433DB for ; Wed, 20 Jan 2021 17:13:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7D4422CE3 for ; Wed, 20 Jan 2021 17:13:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7D4422CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nlEDTPwqZ4+9i1BeQ2n3ObYrCgyXkUxcpQLny3cRwjY=; b=s5dkNB0Ql6VKDdnxJvozasx5A Jdw/iRy6yGxSg3Oio0n2vMAB41cKr/OLQQggxRGnEXldFesEkTkfXKJ0ESLUkKhjFi3arjLrThEjl HwiammSk6DYT1vwglhyI9kqWLPUMzMQLBe8MDGkqeNwnK2kp5gq6k4wKjLDmi1Pn1tjOEFb0ki3RF JhdS2ohrsQDh/MYMXl7CcrPCFvYCCT+wxcf1rsJJhBYgQic1TJfUfDpdVUNnT1+eRKelY0f3SU21F AHF5jUGk8UJ/0H5S6vghqLeuKgPOy1VAb72FwB4zvTItdRgoeWEiF+Sdcc4iAy4MU0nlPBl2V+Zbz JrGNqhJIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2H10-00086Y-B1; Wed, 20 Jan 2021 17:11:30 +0000 Received: from smtp-fw-9103.amazon.com ([207.171.188.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2H0x-00085x-BU for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 17:11:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1611162687; x=1642698687; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=cdvhdSc+KJ2muMQJyh5ViJwhF3It4JZRnpRi6+TvWVQ=; b=BqCXu3B1SXV1SfFykVoAGTVZ2v1jmH0XhQPndCQjJ0VUlYfdts1vTHKD SkCEQCyBbbyLRjT5rD7ExMxHtVXR0cHrdfNDAmTuv1naXSWjGrC7ONNF+ 0USIhuHpDYzqnMQuCUm0cSWBLWJDBlXXWb8C7050BK6fxe57xAjy0dynp Y=; X-IronPort-AV: E=Sophos;i="5.79,361,1602547200"; d="scan'208";a="912082822" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-c7f73527.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9103.sea19.amazon.com with ESMTP; 20 Jan 2021 17:11:25 +0000 Received: from EX13MTAUWC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1e-c7f73527.us-east-1.amazon.com (Postfix) with ESMTPS id 12F8FA26B9; Wed, 20 Jan 2021 17:11:22 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Jan 2021 17:11:22 +0000 Received: from edge-m1-r3-201.e-iad16.amazon.com (10.43.160.66) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Jan 2021 17:11:20 +0000 Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Mohamed Mediouni , References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> From: Alexander Graf Message-ID: <171d8c3f-aa0c-4416-b0d7-d35a47c7acc3@amazon.com> Date: Wed, 20 Jan 2021 18:11:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210120132717.395873-5-mohamed.mediouni@caramail.com> Content-Language: en-US X-Originating-IP: [10.43.160.66] X-ClientProxiedBy: EX13D36UWB004.ant.amazon.com (10.43.161.49) To EX13D20UWC001.ant.amazon.com (10.43.162.244) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_121127_560349_25CBC483 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Marc Zyngier , Will Deacon , Stan Skowronek Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20.01.21 14:27, Mohamed Mediouni wrote: > From: Stan Skowronek > > Apple SoCs use the Apple AIC interrupt controller. > The Arm architectural timers is wired over FIQ on that hardware. > > Signed-off-by: Stan Skowronek > Signed-off-by: Mohamed Mediouni > --- > .../interrupt-controller/apple,aic.yaml | 49 ++++ > MAINTAINERS | 6 + > drivers/irqchip/Kconfig | 6 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-apple-aic.c | 211 ++++++++++++++++++ > 5 files changed, 273 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > create mode 100644 drivers/irqchip/irq-apple-aic.c > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > new file mode 100644 > index 000000000000..e615eaaca869 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Advanced Interrupt Controller (AIC) > + > +description: > + Interrupt controller present on Apple processors. AIC > + is used by Apple on their AArch64 SoCs since the Apple A7. > + > +maintainers: > + - Stan Skowronek > + > +properties: > + compatible: > + items: > + - const: apple,aic > + > + reg: > + maxItems: 1 > + > + '#interrupt-cells': > + const: 3 > + > + interrupt-controller: true > + > + fast-ipi: > + description: > + Fast IPI support. > + > +required: > + - compatible > + - '#interrupt-cells' > + - interrupt-controller > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + aic: interrupt-controller@23b100000 { > + compatible = "apple,aic"; > + #interrupt-cells = <3>; > + interrupt-controller; > + reg = <0x2 0x3b100000 0x0 0x8000>; > + fast-ipi; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 00836f6452f0..e609ede99dd4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1218,6 +1218,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor > F: Documentation/admin-guide/LSM/apparmor.rst > F: security/apparmor/ > > +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER > +M: Stan Skowronek Signing someone else up for maintainership is ... unusual :). Do you have buy in from Stan that he'll be responsive and handle patch reviews? > +L: linux-arm-kernel@lists.infradead.org > +S: Maintained > +F: drivers/irqchip/irq-apple-aic.c > + Alex Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel