From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8EAC433EF for ; Wed, 6 Jul 2022 13:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233054AbiGFNln (ORCPT ); Wed, 6 Jul 2022 09:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232712AbiGFNll (ORCPT ); Wed, 6 Jul 2022 09:41:41 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C3324BE4; Wed, 6 Jul 2022 06:41:39 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so9197507wme.0; Wed, 06 Jul 2022 06:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=Jlle0rhzTTAnWZ/MNh25r/iMQIdPg+Nu4CyuUQnEB3+XRfZWe+9CZwdtvObPWmIv6g d913Ju/S7mnMovkMbGewR/EJ+C5hKF2jryill+Reaw1pTWmgv8OAkwAghmrTDutguk4Q SDRosAPaNN+hGVT71HuA/B9Esxx0cYVXiQjFvXDsdTGo7ASRZIONNC4+54ApG9tqpPi8 dAp/BlYJDauy6Cy12yvpidH/bodG8wQQhyC1J0YUuQOVTwNttLSB8AvN8+SX88WjcVbl b+DKOSfFHI1jNA6LLUabbhounPawG5AlMa6HNpwSyCeqBqtN+6gRteWmi1fx+JReOXzf dCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=uj5GSzqN3K6buano1Woj+R6wCARO1hqx5b2NyxD//ZyxP481bZRFakKDAHTAnQnmhb 6bBRnLhAmbBgeQ9Fa6nHk/clrQmugVgO8uf/MrwFfrjVGFKR3mN0GuxV56PvSGX8gPSw BZNEdYpaPKFC+Mc/HxiYYkARltDdIbUBt9f9DETUGtcYXTDpoKqSKJxO+UiFwyG+papd 02yE337vg3EN9N1+MW7CWBWuAMyjpjqIHZzGs+rHWjGQj7p2PAbFLgONukIAe5kOWEMb btwh8QYPx+hY1IJIfsnuINOyEtDfig7bgeb02MmhSV40EpDGjedVPoUnzyjWU7RcW17U eFVg== X-Gm-Message-State: AJIora+zZ7whJxJuCHgN/ihCkdbbMe0li6h1aZCBlWf738jN9CUNsT/J RFKu6zOZPaTXG9ZC3g76zxc= X-Google-Smtp-Source: AGRyM1uzrUL3jgHl7v16xkNIYUGr+iA0aegNeob2FrKF9QFhYl/5MRV7Rool8Fm50IsaKRG6foS/1A== X-Received: by 2002:a05:600c:274b:b0:3a0:47e8:ca85 with SMTP id 11-20020a05600c274b00b003a047e8ca85mr45800324wmw.156.1657114898287; Wed, 06 Jul 2022 06:41:38 -0700 (PDT) Received: from [192.168.0.14] ([37.223.147.254]) by smtp.gmail.com with ESMTPSA id h16-20020a5d4310000000b0021d7b41255esm2225662wrq.98.2022.07.06.06.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 06:41:37 -0700 (PDT) Message-ID: <17203a8a-407e-30cf-79de-352716c3ebce@gmail.com> Date: Wed, 6 Jul 2022 15:41:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller Content-Language: en-US To: Krzysztof Kozlowski , Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Weiyi Lu Cc: iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-9-tinghan.shen@mediatek.com> <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> From: Matthias Brugger In-Reply-To: <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2022 14:38, Krzysztof Kozlowski wrote: > On 04/07/2022 12:00, Tinghan Shen wrote: >> Add power domains controller node for mt8195. >> >> Signed-off-by: Weiyi Lu >> Signed-off-by: Tinghan Shen >> --- >> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 327 +++++++++++++++++++++++ >> 1 file changed, 327 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> index 8d59a7da3271..d52e140d9271 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> compatible = "mediatek,mt8195"; >> @@ -338,6 +339,332 @@ >> #interrupt-cells = <2>; >> }; >> >> + scpsys: syscon@10006000 { >> + compatible = "syscon", "simple-mfd"; > > These compatibles cannot be alone. > You mean we would need something like "mediatek,scpsys" as dummy compatible that's not bound to any driver? >> + reg = <0 0x10006000 0 0x1000>; >> + #power-domain-cells = <1>; > > If it is simple MFD, then probably it is not a power domain provider. > Decide. The SCPSYS IP block of MediaTek SoCs group several functionality, one is the power domain controller. Others are not yet implemented, but defining the scpsys as a MFD will give us the possibility to do so in the future. Regards, Matthias > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73FBEC43334 for ; Wed, 6 Jul 2022 13:41:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1401140B3D; Wed, 6 Jul 2022 13:41:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1401140B3D Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Jlle0rhz X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 85PoR8CL2ORq; Wed, 6 Jul 2022 13:41:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id C140540148; Wed, 6 Jul 2022 13:41:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C140540148 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9C1BDC0035; Wed, 6 Jul 2022 13:41:43 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C5E9BC002D for ; Wed, 6 Jul 2022 13:41:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id ACB4660FEE for ; Wed, 6 Jul 2022 13:41:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org ACB4660FEE Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Jlle0rhz X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6siguBF1pEKO for ; Wed, 6 Jul 2022 13:41:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5824E60FE9 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5824E60FE9 for ; Wed, 6 Jul 2022 13:41:40 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id g39-20020a05600c4ca700b003a03ac7d540so11618926wmp.3 for ; Wed, 06 Jul 2022 06:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=Jlle0rhzTTAnWZ/MNh25r/iMQIdPg+Nu4CyuUQnEB3+XRfZWe+9CZwdtvObPWmIv6g d913Ju/S7mnMovkMbGewR/EJ+C5hKF2jryill+Reaw1pTWmgv8OAkwAghmrTDutguk4Q SDRosAPaNN+hGVT71HuA/B9Esxx0cYVXiQjFvXDsdTGo7ASRZIONNC4+54ApG9tqpPi8 dAp/BlYJDauy6Cy12yvpidH/bodG8wQQhyC1J0YUuQOVTwNttLSB8AvN8+SX88WjcVbl b+DKOSfFHI1jNA6LLUabbhounPawG5AlMa6HNpwSyCeqBqtN+6gRteWmi1fx+JReOXzf dCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=JG29p0UAz2e/MrSsfBkVlR9ogAejkvVzih2gaxol9vl1IiZ3UPjuq926rjqNIb566S qJSrwUKsh2R+RE059uglssZ0pNJp2y4dLQRj5xPnQlcCx24k8Tm0IUM4A6gLSFLTvJWo JmYSUzgY+gWolp8TB7FLfvMkPb0cv/FPrKvL8M016sjb/tXea0+rL4JKzyad6p/Vme0p SNBFPfHAF+WdEgJUm/5yBH8+E2phVyIA5284xZcdcOqWnkIGDYWQOBcU24xqmtRirZ8N 6w5oEKLY+937d9gfB83ieOCoIazFj+tmamiPJ7JfeUhel+gjVgkE8zjnEps8CPhE30RB M2Xg== X-Gm-Message-State: AJIora9+OoTwgSD7oA5osThngg1fkncjDK2pz/pfaQ2eMAH52Pv3iP6d BbXVyBtggS9uCOpuryxELKw= X-Google-Smtp-Source: AGRyM1uzrUL3jgHl7v16xkNIYUGr+iA0aegNeob2FrKF9QFhYl/5MRV7Rool8Fm50IsaKRG6foS/1A== X-Received: by 2002:a05:600c:274b:b0:3a0:47e8:ca85 with SMTP id 11-20020a05600c274b00b003a047e8ca85mr45800324wmw.156.1657114898287; Wed, 06 Jul 2022 06:41:38 -0700 (PDT) Received: from [192.168.0.14] ([37.223.147.254]) by smtp.gmail.com with ESMTPSA id h16-20020a5d4310000000b0021d7b41255esm2225662wrq.98.2022.07.06.06.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 06:41:37 -0700 (PDT) Message-ID: <17203a8a-407e-30cf-79de-352716c3ebce@gmail.com> Date: Wed, 6 Jul 2022 15:41:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller Content-Language: en-US To: Krzysztof Kozlowski , Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Weiyi Lu References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-9-tinghan.shen@mediatek.com> <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> From: Matthias Brugger In-Reply-To: <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 04/07/2022 14:38, Krzysztof Kozlowski wrote: > On 04/07/2022 12:00, Tinghan Shen wrote: >> Add power domains controller node for mt8195. >> >> Signed-off-by: Weiyi Lu >> Signed-off-by: Tinghan Shen >> --- >> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 327 +++++++++++++++++++++++ >> 1 file changed, 327 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> index 8d59a7da3271..d52e140d9271 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> compatible = "mediatek,mt8195"; >> @@ -338,6 +339,332 @@ >> #interrupt-cells = <2>; >> }; >> >> + scpsys: syscon@10006000 { >> + compatible = "syscon", "simple-mfd"; > > These compatibles cannot be alone. > You mean we would need something like "mediatek,scpsys" as dummy compatible that's not bound to any driver? >> + reg = <0 0x10006000 0 0x1000>; >> + #power-domain-cells = <1>; > > If it is simple MFD, then probably it is not a power domain provider. > Decide. The SCPSYS IP block of MediaTek SoCs group several functionality, one is the power domain controller. Others are not yet implemented, but defining the scpsys as a MFD will give us the possibility to do so in the future. Regards, Matthias > > Best regards, > Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A922C43334 for ; Wed, 6 Jul 2022 13:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ln+wqGU7VBMJ6qDQSOm5yHOwdpgBVzq9diV7+TI04F0=; b=sVvVIgpSX7L4UB /4Rv35FAWcLKMN2awdk/cfVRvIycdVOJvE5LcYymx5WNPy7LhlzsERh6tgZFir76HRybW3QUJyuey E35b1ae3dcKsghKKtxTsr3cCJ15eWRTu7zl2PfUnq4/R76EtuX91oQfghH6Yd5ust4TJYCLXMSLd2 3gCVefHbehWBFcR+U1xCT9fu89FpCb+2ZhaWaOMqA86EerraATrY6cxBdD7p/eENZa+LUuss7PgyA wBVVZ1XZiWzjYb+M3AKHjw02GFa5xKRrP2COlRrR1CvLChPI+o6oDdzDj/l1PvDf9u+ftzz8GAIyh 6zQfUGOnxGJnHj38IuIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Hl-00ALVC-Ug; Wed, 06 Jul 2022 13:41:46 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o95Hi-00ALPN-29; Wed, 06 Jul 2022 13:41:43 +0000 Received: by mail-wm1-x32e.google.com with SMTP id l40-20020a05600c1d2800b003a18adff308so9355294wms.5; Wed, 06 Jul 2022 06:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=Jlle0rhzTTAnWZ/MNh25r/iMQIdPg+Nu4CyuUQnEB3+XRfZWe+9CZwdtvObPWmIv6g d913Ju/S7mnMovkMbGewR/EJ+C5hKF2jryill+Reaw1pTWmgv8OAkwAghmrTDutguk4Q SDRosAPaNN+hGVT71HuA/B9Esxx0cYVXiQjFvXDsdTGo7ASRZIONNC4+54ApG9tqpPi8 dAp/BlYJDauy6Cy12yvpidH/bodG8wQQhyC1J0YUuQOVTwNttLSB8AvN8+SX88WjcVbl b+DKOSfFHI1jNA6LLUabbhounPawG5AlMa6HNpwSyCeqBqtN+6gRteWmi1fx+JReOXzf dCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=J37bnxv35AKNMkkxULLkWayVHEaMjv0zIAo9khsK/xs=; b=UA+ok76+l1Rbbm3PS6jcV7glIYkF7s3ZMTrMyS8lrPxH+UlHFhR2EJqgYpGlsYMoVZ VhsPW4HNP3YHwFqswGBM6ggERlzZWHMfjzuGuUKfe4y0U37jjGUTcixlCEW20uj8s+2N 2G8pUExw+2OjAMUqHw7SY0NrkhB5SMqVyMwldf8D1ioN9Y6nkOQjN24hdbVut9Rny0ts 3lybjWNrKjXqFrBq8XkfuvAAQAi/A2xWPP9UVStJmUkZuXz74/f4N6dO9P6Hkrxz9x/r KKjaXmcRiAKSzuy340EbyOsbjOCVY9DO7BuP0d1366+um8WFCRYIcQQJywRbGLgZ2UE2 ZJhg== X-Gm-Message-State: AJIora8RjNQtbmf4TOpncpT9XfJ/6G8vGnyf5zAwE59jXzNfIwTPUVyY M04BrXcPYmMcsUbqQ1UdHto= X-Google-Smtp-Source: AGRyM1uzrUL3jgHl7v16xkNIYUGr+iA0aegNeob2FrKF9QFhYl/5MRV7Rool8Fm50IsaKRG6foS/1A== X-Received: by 2002:a05:600c:274b:b0:3a0:47e8:ca85 with SMTP id 11-20020a05600c274b00b003a047e8ca85mr45800324wmw.156.1657114898287; Wed, 06 Jul 2022 06:41:38 -0700 (PDT) Received: from [192.168.0.14] ([37.223.147.254]) by smtp.gmail.com with ESMTPSA id h16-20020a5d4310000000b0021d7b41255esm2225662wrq.98.2022.07.06.06.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 06:41:37 -0700 (PDT) Message-ID: <17203a8a-407e-30cf-79de-352716c3ebce@gmail.com> Date: Wed, 6 Jul 2022 15:41:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller Content-Language: en-US To: Krzysztof Kozlowski , Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Weiyi Lu Cc: iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-9-tinghan.shen@mediatek.com> <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> From: Matthias Brugger In-Reply-To: <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_064142_156367_195652C1 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/07/2022 14:38, Krzysztof Kozlowski wrote: > On 04/07/2022 12:00, Tinghan Shen wrote: >> Add power domains controller node for mt8195. >> >> Signed-off-by: Weiyi Lu >> Signed-off-by: Tinghan Shen >> --- >> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 327 +++++++++++++++++++++++ >> 1 file changed, 327 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> index 8d59a7da3271..d52e140d9271 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> compatible = "mediatek,mt8195"; >> @@ -338,6 +339,332 @@ >> #interrupt-cells = <2>; >> }; >> >> + scpsys: syscon@10006000 { >> + compatible = "syscon", "simple-mfd"; > > These compatibles cannot be alone. > You mean we would need something like "mediatek,scpsys" as dummy compatible that's not bound to any driver? >> + reg = <0 0x10006000 0 0x1000>; >> + #power-domain-cells = <1>; > > If it is simple MFD, then probably it is not a power domain provider. > Decide. The SCPSYS IP block of MediaTek SoCs group several functionality, one is the power domain controller. Others are not yet implemented, but defining the scpsys as a MFD will give us the possibility to do so in the future. Regards, Matthias > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel