From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mail.openembedded.org (Postfix) with ESMTP id 32DBD6E5D7 for ; Tue, 3 Feb 2015 10:12:20 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 03 Feb 2015 02:12:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,511,1418112000"; d="scan'208";a="660764963" Received: from unknown (HELO peggleto-mobl5.ger.corp.intel.com) ([10.252.17.39]) by fmsmga001.fm.intel.com with ESMTP; 03 Feb 2015 02:12:20 -0800 From: Paul Eggleton To: Chong Lu Date: Tue, 03 Feb 2015 10:12:19 +0000 Message-ID: <1728669.U1IcW4V3Z6@peggleto-mobl5.ger.corp.intel.com> Organization: Intel Corporation User-Agent: KMail/4.14.4 (Linux/3.17.8-200.fc20.x86_64; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1584081.qrVQXzTzW7@peggleto-mobl5.ger.corp.intel.com> References: <1584081.qrVQXzTzW7@peggleto-mobl5.ger.corp.intel.com> MIME-Version: 1.0 Cc: bitbake-devel@lists.openembedded.org Subject: Re: [PATCH V3 0/2] bitbake-layers: add a ability to query layer dependencies from layer index X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 10:12:28 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday 02 February 2015 16:05:52 Paul Eggleton wrote: > Hi Chong, > > On Friday 23 January 2015 13:28:32 Chong Lu wrote: > > Change since V2: > > re-split for IPv6 URL parsing > > > > The following changes since commit 35c9fa0588ed8e88b541a6c80cc1517324616cea: > > maintainers: Update for non-maintained recipes (2015-01-20 21:39:41 > > +0000) > > > > are available in the git repository at: > > git://git.pokylinux.org/poky-contrib chonglu/layerindex > > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/layerindex > > > > Chong Lu (2): > > bitbake.conf: Add two variables for layer index > > bitbake-layers: add a ability to query layer dependencies from layer > > index > > Apologies for the delay in getting back to you. This is definitely > improving, some feedback though: > > * I think the new subcommand would make more sense if it were switched > around so that it was fetching by default (and renamed as appropriate). > Perhaps "layerindex-fetch" (with -n to avoid fetching and just report what > it would fetch). > > * I think the layer index URL specified in the OE variable should be to the > root rather than to /api - instead have that suffix added by the code that > does the API calls. This makes it usable as a URL for the index for > presenting to the user if needed. > > * Can you rename the two variables to BBLAYERS_LAYERINDEX_URL and > BBLAYERS_FETCH_DIR (sorry I didn't think of this earlier). > > * Please mention bitbake-layers in the comment above the settings in > bitbake.conf so it's clear where these variables are used. > > * By using -q with git you lose the status output which can be very useful > given how long it can take to fetch some layers e.g. meta-oe, so can you > drop this? > > * Can you add a check to see if the layer has already been fetched before > fetching it and skip the fetch if it does (but not skip the add)? > > * If I run "bitbake-layers show-layer-deps meta-security" I get an error: > ERROR: Can NOT get meta-security git repo and subdir > (The code currently expects there to be a subdir, but this is an optional > field, not all layers have a subdirectory, meta-security is one example.) > > * I think you may be able to get away with skipping the initial parse by > passing config_only=True to init_bbhandler(). If you can, this will save a > bit of time each time you run the command. I just noticed another issue - dependencies-of-dependencies aren't handled here either; e.g. meta-security's dependencies have just been updated so that it now depends on meta-networking, and meta-networking depends on meta-python but that's not listed when I run bitbake-layers show-layer-deps meta-security. I think maybe this is a deficiency in the layer index API - it would be faster if there was one call we could make to get the entire list of dependencies, URLs and subdirectories for the entire dependency chain. I know this is probably further than you expected to go with this bug, but is that API enhancement something you could look into adding? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre