From: Stephen & Linda Smith <ischis2@cox.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation
Date: Fri, 08 Jan 2016 18:55:21 -0700 [thread overview]
Message-ID: <17299684.zSfrSa31Pt@thunderbird> (raw)
In-Reply-To: loom.20160108T065547-969@post.gmane.org
On Friday, January 08, 2016 10:21:48 AM Junio C Hamano wrote:
> Stephen Smith <ischis2@cox.net> writes:
>
> > Junio C Hamano <gitster <at> pobox.com> writes:
> >> > echo modified >>a-blob &&
> >> > git add -u &&
> >> > git commit -m Modified &&
> >> > + git branch modref &&
> >>
> >> This probably belongs to the previous step, no?
> >>
> > What did you mean by this comment? I looked at the original patch and at
> > Will's response to your comment and am not quite sure what was meant.
>
> Notice that the title is [2/2], so there is [1/2], which turns out
> to be http://article.gmane.org/gmane.comp.version-control.git/270898
>
I had that patch but didn't connect it to your comment.
> That patch updates the preparatory steps of the test script so that
> [2/2] have more commits and refs to work with to perform more tests.
>
> Marking the result of that "Modified" commit so that it can be
> referenced later with a short name 'modref' is something that should
> have done in [1/2], which added that new invocation of "git commit"
> to record that "Modified" commit, not in [2/2] as an afterthought
> "Oh I created Modified commit in 1/2 so that I can use it in the
> test in 2/2, but I forgot to give it a name, so I am adding a new
> invocation of 'git branch' in this step".
Yep makes sense.
>
> >
> >> > +test_expect_success 'ref^{/!-}' '
> >> > + test_must_fail git rev-parse master^{/!-}
> >> > +'
> >>
> > I plan on leaving this in.
> >
> >> > +test_expect_success 'ref^{/!-.}' '
> >> > + test_must_fail git rev-parse master^{/!-.}
> >> > +'
> >>
> > I plan on leaving this in.
next prev parent reply other threads:[~2016-01-09 1:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 0:24 [PATCH v2 0/2] specify commit by negative pattern Will Palmer
2015-06-06 0:24 ` [PATCH v2 1/2] test for '!' handling in rev-parse's named commits Will Palmer
2015-06-06 0:24 ` [PATCH v2 2/2] object name: introduce '^{/!-<negative pattern>}' notation Will Palmer
2015-06-08 16:39 ` Junio C Hamano
2015-06-09 18:14 ` Will Palmer
2015-10-28 17:52 ` Junio C Hamano
2016-01-08 6:04 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Stephen Smith
2016-01-08 18:21 ` Junio C Hamano
2016-01-10 2:20 ` [PATCH V3 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-10 2:22 ` [PATCH V3 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-10 2:23 ` [PATCH V3 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-11 18:10 ` Philip Oakley
2016-01-13 4:51 ` [PATCH V4 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-13 4:51 ` [PATCH V4 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-13 4:52 ` [PATCH V4 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-13 19:15 ` Junio C Hamano
2016-01-31 0:06 ` [PATCH V5 " Stephen P. Smith
2016-02-01 21:42 ` Junio C Hamano
2016-01-10 13:25 ` [PATCH V3 0/2] specify commit by negative pattern Philip Oakley
2016-01-11 0:08 ` Stephen P. Smith
2016-01-11 18:04 ` Philip Oakley
2016-01-10 14:14 ` Stephen & Linda Smith
2016-01-10 23:36 ` Philip Oakley
2016-01-09 1:55 ` Stephen & Linda Smith [this message]
2016-01-09 2:18 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Duy Nguyen
2016-01-11 17:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17299684.zSfrSa31Pt@thunderbird \
--to=ischis2@cox.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.