From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD90FC433F5 for ; Thu, 3 Mar 2022 16:18:42 +0000 (UTC) Received: from localhost ([::1]:56294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPoA5-0007as-U8 for qemu-devel@archiver.kernel.org; Thu, 03 Mar 2022 11:18:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPo2r-0002LJ-1G for qemu-devel@nongnu.org; Thu, 03 Mar 2022 11:11:13 -0500 Received: from [2607:f8b0:4864:20::633] (port=40495 helo=mail-pl1-x633.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPo2o-0000ED-40 for qemu-devel@nongnu.org; Thu, 03 Mar 2022 11:11:12 -0500 Received: by mail-pl1-x633.google.com with SMTP id z11so4945257pla.7 for ; Thu, 03 Mar 2022 08:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=FM2TjJErwdheSh2ZQedrla9XQeExtxgiIX9eoydPkZg=; b=LFnMSehvCpqUIp+rX6o32OrZJjg6TWn08tUcjD6J3dE7E6YxchB4dItK8cOw67Jqek faGSKIL7AVPGXkiFTYhHKojWWslBG0ZqTlq8QKpWe1aOyJ1sXFFMm1SKM4Uin+A4l7da a5du/cXrV56ZMBS5K63x/xenWNR2QV3miEC+ZLy5exHP6EKZ8kpbL9cMWh5yRt8aoTJL zj0J/0xwQkGVIBpGCpbFycKwrKBQGvWDVWq/EqFiYL0AnBqoyJZFezeawXtX90lwRyek /huNhcSdnNl5acE74HoTT/T0unyKBl8aUfxcPL8tMVW4V301PvVDDyi4sZtiOSzNHNKv ImDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=FM2TjJErwdheSh2ZQedrla9XQeExtxgiIX9eoydPkZg=; b=w/VgO8WKwLAnhJuHKYL2k3KFEBR3JathHYT4IGyx/uvrx9tV43s3haq+H8zRl578ZI yWGqfh4Q8aIsorrhtj2Tue7fRWBEOoZQPPUfGhaIFzmkMXuHvByqeud49pbov67LA+7s xM+SPB+dt+u6oMr0yemThv6K8h2K4EHuNTxL42zJ7vDgYaeq7yTlIm0GYT2yla7UvCLE 3NqM9ZmWc8wWZjZhxnZS7Z875UuvCiDG4jatSmCgn3azB8vDnYI/VjBQloScMJbfa3IH 4KaK6ABZsQ6yAN/cR/MYb0WVGSPWbNkwJPgFVBlygV4B3ZsFERU65SRVvMXK1PZcrTFZ FojQ== X-Gm-Message-State: AOAM532CNOYLwtfYk2p1nGtRQkqW7TKNWJzKkMl0vg9X3sdk6T6tSO0y Ru7uzBJ0CwQM3axuwB21S+fvKg== X-Google-Smtp-Source: ABdhPJwHXnL6Rr1Ub6SBryBhSYpbjGBOdQgxmi1MR14qgGPdkjSJzFO7sEOL/KBcBqGQ2MVExkprWw== X-Received: by 2002:a17:90a:5302:b0:1b9:ba0a:27e5 with SMTP id x2-20020a17090a530200b001b9ba0a27e5mr5944556pjh.91.1646323868668; Thu, 03 Mar 2022 08:11:08 -0800 (PST) Received: from ?IPV6:2603:800c:1201:c600:e819:4400:f268:c391? (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id s21-20020a63dc15000000b00378c9e5b37fsm2379559pgg.63.2022.03.03.08.11.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 08:11:08 -0800 (PST) Message-ID: <172ac53f-6e0d-7559-30d8-255c74a5dda1@linaro.org> Date: Thu, 3 Mar 2022 06:11:05 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] target/arm/translate-neon: Simplify align field check for VLD3 Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220303113741.2156877-1-peter.maydell@linaro.org> <20220303113741.2156877-3-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20220303113741.2156877-3-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::633 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/3/22 01:37, Peter Maydell wrote: > For VLD3 (single 3-element structure to one lane), there is no > alignment specification and the alignment bits in the instruction > must be zero. This is bit [4] for the size=0 and size=1 cases, and > bits [5:4] for the size=2 case. We do this check correctly in > VLDST_single(), but we write it a bit oddly: in the 'case 3' code we > check for bit 0 of a->align (bit [4] of the insn), and then we fall > through to the 'case 2' code which checks bit 1 of a->align (bit [5] > of the insn) in the size 2 case. Replace this with just checking "is > a->align non-zero" for VLD3, which lets us drop the fall-through and > put the cases in this switch in numerical order. > > Signed-off-by: Peter Maydell > --- > target/arm/translate-neon.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson Tested-by: Richard Henderson r~