From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 13/23] net/softnic: add connection agent
Date: Wed, 11 Jul 2018 21:58:02 +0200
Message-ID: <1732348.hrkfh3074m@xps>
References: <20180627163123.135686-2-jasvinder.singh@intel.com>
 <20180705154754.147420-1-jasvinder.singh@intel.com>
 <20180705154754.147420-14-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
To: Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id A64BF1B4DD
 for <dev@dpdk.org>; Wed, 11 Jul 2018 21:58:05 +0200 (CEST)
In-Reply-To: <20180705154754.147420-14-jasvinder.singh@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/07/2018 17:47, Jasvinder Singh:
> Add connection agent to enable connectivity with external agen
> (e.g. telnet, netcat, Python script, etc).
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  config/common_base                                 |   2 +-
>  config/common_linuxapp                             |   1 +
>  drivers/net/softnic/Makefile                       |  12 +-
>  drivers/net/softnic/conn.c                         | 332 +++++++++++++++++++++
>  drivers/net/softnic/conn.h                         |  49 +++
>  drivers/net/softnic/rte_eth_softnic.c              |  79 ++++-
>  drivers/net/softnic/rte_eth_softnic.h              |  16 +
>  drivers/net/softnic/rte_eth_softnic_internals.h    |   3 +
>  ...nic_version.map => rte_eth_softnic_version.map} |   6 +
>  9 files changed, 496 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/net/softnic/conn.c
>  create mode 100644 drivers/net/softnic/conn.h
>  rename drivers/net/softnic/{rte_pmd_softnic_version.map => rte_eth_softnic_version.map} (52%)

Why are you renaming this file?

If you test the compilation with devtools/test-meson-builds.sh
you will see this error:
	drivers/meson.build:111:3: ERROR:
	File drivers/net/softnic/rte_pmd_softnic_version.map does not exist.


> +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
> +$(info Softnic PMD can only operate in a linuxapp environment, \

I think it is a really wrong idea to limit softnic to Linux only.