From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Kai Lueke <kailueke@linux.microsoft.com>,
Steffen Klassert <steffen.klassert@secunet.com>
Cc: Paul Chaignon <paul@cilium.io>,
Eyal Birger <eyal.birger@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error"
Date: Wed, 2 Mar 2022 10:27:30 +0100 [thread overview]
Message-ID: <1735bb6b-8708-43ee-949a-428957d7f917@6wind.com> (raw)
In-Reply-To: <f2dc1c09-6e3a-0563-491b-1b8de7a8f5ef@linux.microsoft.com>
Le 01/03/2022 à 17:44, Kai Lueke a écrit :
> Hi,
>> In general I agree that the userspace ABI has to be stable, but
>> this never worked. We changed the behaviour from silently broken to
>> notify userspace about a misconfiguration.
>>
>> It is the question what is more annoying for the users. A bug that
>> we can never fix, or changing a broken behaviour to something that
>> tells you at least why it is not working.
>>
>> In such a case we should gauge what's the better solution. Here
>> I tend to keep it as it is.
>
> alternatives are: docs to ensure the API is used the right way, maybe a
> dmesg log entry if wrong usage is detected, and filing bugs where the
> API is used wrong.
I agree with that proposal (dmesg log). Breaking an existing script, even if it
made something wrong is really painful. And maybe this broken xfrm interface was
unused, so everything worked well before the patch and is now broken.
My two cents,
Nicolas
next prev parent reply other threads:[~2022-03-02 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 13:15 [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error" kailueke
2022-03-01 13:15 ` [PATCH 2/2] Revert "xfrm: state and policy should fail if XFRMA_IF_ID 0" kailueke
2022-03-01 13:28 ` [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error" Eyal Birger
2022-03-01 14:17 ` Kai Lüke
2022-03-01 14:34 ` Eyal Birger
2022-03-01 15:09 ` Paul Chaignon
2022-03-01 15:48 ` Kai Lüke
2022-03-01 16:10 ` Steffen Klassert
2022-03-01 16:44 ` Kai Lueke
2022-03-02 9:27 ` Nicolas Dichtel [this message]
2022-03-02 16:04 ` Jakub Kicinski
2022-03-02 18:11 ` Kai Lueke
2022-03-03 5:33 ` Jakub Kicinski
2022-03-03 7:54 ` Steffen Klassert
-- strict thread matches above, loose matches on Subject: below --
2022-02-28 18:55 Kai Lüke
2022-02-28 18:51 Kai Lüke
2022-02-28 18:49 Kai Lüke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735bb6b-8708-43ee-949a-428957d7f917@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=eyal.birger@gmail.com \
--cc=kailueke@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=paul@cilium.io \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.