All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	"Zheng, Lv" <lv.zheng@intel.com>, Len Brown <lenb@kernel.org>,
	"Brown, Len" <len.brown@intel.com>,
	linux acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package entries
Date: Tue, 18 Jun 2013 23:51:56 +0200	[thread overview]
Message-ID: <1740311.uDCIxlT6hC@vostro.rjw.lan> (raw)
In-Reply-To: <51BF7230.4040805@intel.com>

On Monday, June 17, 2013 10:31:44 PM Rafael J. Wysocki wrote:
> On 6/17/2013 6:41 PM, Moore, Robert wrote:
> > This one is just adding additional checks on the _CST that are obvious errors in the AML. The eventual goal of the "repair" code in ACPICA is to never return a bad package from things like _CST. In other words, an AE_OK guarantees that the return value is usable.
> >
> > So, this is an additional implementation of this longer-range project.
> >
> 
> Thanks Bob!
> 
> Lv, care to add the above explanation from Bob to the changelog of the 
> $subject patch?

Well, I can add it too, I suppose.

Thanks,
Rafael


> >> -----Original Message-----
> >> From: lenb417@gmail.com [mailto:lenb417@gmail.com] On Behalf Of Len Brown
> >> Sent: Wednesday, June 12, 2013 11:00 AM
> >> To: Zheng, Lv
> >> Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi
> >> Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package
> >> entries
> >>
> >> On Fri, Jun 7, 2013 at 9:01 PM, Lv Zheng <lv.zheng@intel.com> wrote:
> >>> Sort package only after null/bad elements have been removed.
> >>> Lv Zheng.
> >>
> >> again, please explain WHY.
> >>
> >> Every line of change to the kernel adds risk.
> >> I see no justification in this commit message why any risk should be added
> >> to the kernel.
> >>
> >> Nacked-by: Len Brown <len.brown@intel.com>
> 
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> z siedziba w Gdansku
> ul. Slowackiego 173
> 80-298 Gdansk
> 
> Sad Rejonowy Gdansk Polnoc w Gdansku, 
> VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
> numer KRS 101882
> 
> NIP 957-07-52-316
> Kapital zakladowy 200.000 zl
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2013-06-18 21:42 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-08  0:57 [PATCH 00/16] ACPICA: 20130517 release Lv Zheng
2013-06-08  0:57 ` [PATCH 01/16] ACPICA: Split buffer dump routines into separate file Lv Zheng
2013-06-12 15:51   ` Len Brown
2013-06-08  0:58 ` [PATCH 02/16] ACPICA: Split internal error msg routines to a " Lv Zheng
2013-06-12 15:52   ` Len Brown
2013-06-08  0:58 ` [PATCH 03/16] ACPICA: Standardize all switch() blocks Lv Zheng
2013-06-12 15:58   ` Len Brown
2013-06-18 18:46     ` Moore, Robert
2013-06-08  0:58 ` [PATCH 04/16] ACPICA: Add option to disable loading of SSDTs from the RSDT/XSDT Lv Zheng
2013-06-08  0:59 ` [PATCH 05/16] ACPICA: Split table print utilities to a new a separate file Lv Zheng
2013-06-12 17:03   ` Len Brown
2013-06-18 18:46     ` Moore, Robert
2013-06-08  0:59 ` [PATCH 06/16] ACPICA: Do not use extended sleep registers unless HW-reduced bit is set Lv Zheng
2013-06-12 17:11   ` Len Brown
2013-06-15 23:08     ` Rafael J. Wysocki
2013-06-08  0:59 ` [PATCH 07/16] ACPICA: New: Portable acpidump utility (get system ACPI tables) Lv Zheng
2013-06-12 17:07   ` Len Brown
2013-06-15 23:09     ` Rafael J. Wysocki
2013-06-18 18:53       ` Moore, Robert
2013-06-18 21:06         ` Rafael J. Wysocki
2013-06-18 21:21           ` Moore, Robert
2013-06-18 21:40             ` Rafael J. Wysocki
2013-06-19  0:48               ` Moore, Robert
2013-06-19 23:10                 ` Rafael J. Wysocki
2013-06-20  4:57                   ` Moore, Robert
2013-06-20 19:42                     ` Rafael J. Wysocki
2013-06-20 19:43                       ` Moore, Robert
2013-06-18 18:48     ` Moore, Robert
2013-06-08  0:59 ` [PATCH 08/16] ACPICA: Update interface to AcpiUtValidAcpiName Lv Zheng
2013-06-12 17:15   ` Len Brown
2013-06-15 23:12     ` Rafael J. Wysocki
2013-06-08  0:59 ` [PATCH 09/16] ACPICA: ACPICA Termination: Delete global lock pending lock Lv Zheng
2013-06-12 17:28   ` Len Brown
2013-06-08  1:00 ` [PATCH 10/16] ACPICA: Fix possible memory leak in GPE init error path Lv Zheng
2013-06-12 17:34   ` Len Brown
2013-06-08  1:00 ` [PATCH 11/16] ACPICA: Clear events initialized flag upon event component termination Lv Zheng
2013-06-12 17:47   ` Len Brown
2013-06-18 18:50     ` Moore, Robert
2013-06-08  1:00 ` [PATCH 12/16] ACPICA: Support Mac OS X in Makefile Lv Zheng
2013-06-12 17:49   ` Len Brown
2013-06-08  1:01 ` [PATCH 13/16] ACPICA: Move _PRT repair into the standard complex repair module Lv Zheng
2013-06-12 17:52   ` Len Brown
2013-06-15 23:17     ` Rafael J. Wysocki
2013-06-18 18:51     ` Moore, Robert
2013-06-18 21:49       ` Rafael J. Wysocki
2013-06-19 23:57         ` Rafael J. Wysocki
2013-06-20  0:41           ` Zheng, Lv
2013-06-20  5:01             ` Moore, Robert
2013-06-08  1:01 ` [PATCH 14/16] ACPICA: Add several repairs for _CST predefined name Lv Zheng
2013-06-12 17:58   ` Len Brown
2013-06-15 23:17     ` Rafael J. Wysocki
2013-06-18 18:51     ` Moore, Robert
2013-06-18 21:48       ` Rafael J. Wysocki
2013-06-19  0:52         ` Moore, Robert
2013-06-19 23:57           ` Rafael J. Wysocki
2013-06-08  1:01 ` [PATCH 15/16] ACPICA: _CST repair: Handle null package entries Lv Zheng
2013-06-12 18:00   ` Len Brown
2013-06-15 23:18     ` Rafael J. Wysocki
2013-06-17 16:41     ` Moore, Robert
2013-06-17 20:31       ` Rafael J. Wysocki
2013-06-18 21:51         ` Rafael J. Wysocki [this message]
2013-06-18 18:52     ` Moore, Robert
2013-06-18 21:50       ` Rafael J. Wysocki
2013-06-19  0:50         ` Moore, Robert
2013-06-19 23:56           ` Rafael J. Wysocki
2013-06-08  1:01 ` [PATCH 16/16] ACPICA: Update version to 20130517 Lv Zheng
2013-06-12 18:01   ` Len Brown
2013-06-15 23:19     ` Rafael J. Wysocki
2013-06-11 22:32 ` [PATCH 00/16] ACPICA: 20130517 release Rafael J. Wysocki
2013-06-12 18:04 ` Len Brown
2013-06-15 23:24   ` Rafael J. Wysocki
2013-06-18  1:39     ` Zheng, Lv
2013-06-18  1:56       ` Zheng, Lv
2013-06-18 10:35       ` Rafael J. Wysocki
2013-06-18 18:55     ` Moore, Robert
2013-06-18 21:04       ` Rafael J. Wysocki
2013-06-19  0:58         ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1740311.uDCIxlT6hC@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.