From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2091CC4338F for ; Tue, 27 Jul 2021 16:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 047A461B6F for ; Tue, 27 Jul 2021 16:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbhG0QDi convert rfc822-to-8bit (ORCPT ); Tue, 27 Jul 2021 12:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhG0QDf (ORCPT ); Tue, 27 Jul 2021 12:03:35 -0400 Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [IPv6:2001:41d0:305:2100::8a0c]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 51098C061757 for ; Tue, 27 Jul 2021 09:03:35 -0700 (PDT) Received: from ursule.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 50E7AC0241; Tue, 27 Jul 2021 19:03:33 +0300 (EEST) Received: from basile.remlab.net ([2001:14ba:a01a:be01:9434:f69e:d553:3be2]) by ursule.remlab.net with ESMTPSA id sRsREVUuAGFWcAAAwZXkwQ (envelope-from ); Tue, 27 Jul 2021 19:03:33 +0300 From: =?ISO-8859-1?Q?R=E9mi?= Denis-Courmont To: netdev@vger.kernel.org, Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Arnd Bergmann , Remi Denis-Courmont Subject: Re: [PATCH net-next v3 06/31] phonet: use siocdevprivate Date: Tue, 27 Jul 2021 19:03:32 +0300 Message-ID: <1745398.PdPXp2ZHHY@basile.remlab.net> Organization: Remlab In-Reply-To: <20210727134517.1384504-7-arnd@kernel.org> References: <20210727134517.1384504-1-arnd@kernel.org> <20210727134517.1384504-7-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le tiistaina 27. heinäkuuta 2021, 16.44.52 EEST Arnd Bergmann a écrit : > From: Arnd Bergmann > > phonet has a single private ioctl that is broken in compat > mode on big-endian machines today because the data returned > from it is never copied back to user space. > > Move it over to the ndo_siocdevprivate callback, which also > fixes the compat issue. > > Cc: Remi Denis-Courmont > Signed-off-by: Arnd Bergmann Acked-by: Rémi Denis-Courmont -- This made me realise that the HSI/SSI device driver lacks the private IOCTL (but that's obivously not a problem of this series). -- Rémi Denis-Courmont http://www.remlab.net/