From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FE8C282CE for ; Tue, 4 Jun 2019 14:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25DAF249D0 for ; Tue, 4 Jun 2019 14:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727537AbfFDOOh (ORCPT ); Tue, 4 Jun 2019 10:14:37 -0400 Received: from gloria.sntech.de ([185.11.138.130]:48126 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727287AbfFDOOh (ORCPT ); Tue, 4 Jun 2019 10:14:37 -0400 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hYACw-0001Zj-Uz; Tue, 04 Jun 2019 16:14:34 +0200 From: Heiko Stuebner To: Douglas Anderson Cc: briannorris@chromium.org, ryandcase@chromium.org, mka@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy Date: Tue, 04 Jun 2019 16:14:34 +0200 Message-ID: <1748246.UnQIR8Fo6l@phil> In-Reply-To: <20190524233309.45420-1-dianders@chromium.org> References: <20190524233309.45420-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, 25. Mai 2019, 01:33:09 CEST schrieb Douglas Anderson: > This is like commit 0ca87bd5baa6 ("ARM: dts: rockchip: Add pin names > for rk3288-veyron-jerry") and commit ca3516b32cd9 ("ARM: dts: > rockchip: Add pin names for rk3288-veyron-minnie") but for 3 more > veyron boards. > > A few notes: > - While there is most certainly duplication between all the veyron > boards, it still feels like it is sane to just have each board have > a full list of its pin names. The format of "gpio-line-names" does > not lend itself to one-off overriding and besides it seems sane to > more fully match schematic names. Also note that the extra > duplication here is only in source code and is unlikely to ever > change (since these boards are shipped). Duplication in the .dtb > files is unavoidable. > - veyron-jaq and veyron-mighty are very closely related and so I have > shared a single list for them both with comments on how they are > different. This is just a typo fix on one of the boards, a possible > missing signal on one of the boards (or perhaps I was never given > the most recent schematics?) and dealing with the fact that one of > the two boards has full sized SD. > > Signed-off-by: Douglas Anderson applied for 5.3 with Matthias Rb. Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFED5C28CC3 for ; Tue, 4 Jun 2019 14:14:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 952BC23BD2 for ; Tue, 4 Jun 2019 14:14:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VuPEsXNw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 952BC23BD2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HXghNu+WgmfQ51wP6SeMo7dPeuzIFSOeGYWKIDFksHc=; b=VuPEsXNwNhL46t Bp28zr+gUwjFJkfxId2lgTBK50bp+ijrRXxbAe7FFws2tGH+RIhvgH7W57s7a6hHLxLQjE1ZnEjBM Td+AA8X/QE2+Fj8F3yZ2XzGYWG5iTy66TSq8BPBzBwX5Y4qi0MoVxYpsN6N6LSzKaCugwqD30zc7c HNKIdmvP/jgELXVAu2l/z9Ky9lQNJWcFScLsi1yQzEsa3iXT2hYSEFG2r5m6Gii46XMlgJ6LLnCJT XRGi0F9PJ4rNDu8Ebzj8WW+/J+7QOo05XmhBreHfykPHs2s9BhOfxuodwcWZKkNk/3dYX4x/KlDZQ v8G5o6vOwE8JLYxON5tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYAD4-0008JB-Gw; Tue, 04 Jun 2019 14:14:42 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYAD1-0008I3-25; Tue, 04 Jun 2019 14:14:40 +0000 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hYACw-0001Zj-Uz; Tue, 04 Jun 2019 16:14:34 +0200 From: Heiko Stuebner To: Douglas Anderson Subject: Re: [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy Date: Tue, 04 Jun 2019 16:14:34 +0200 Message-ID: <1748246.UnQIR8Fo6l@phil> In-Reply-To: <20190524233309.45420-1-dianders@chromium.org> References: <20190524233309.45420-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_071439_254172_C3598F8B X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, Rob Herring , linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 25. Mai 2019, 01:33:09 CEST schrieb Douglas Anderson: > This is like commit 0ca87bd5baa6 ("ARM: dts: rockchip: Add pin names > for rk3288-veyron-jerry") and commit ca3516b32cd9 ("ARM: dts: > rockchip: Add pin names for rk3288-veyron-minnie") but for 3 more > veyron boards. > > A few notes: > - While there is most certainly duplication between all the veyron > boards, it still feels like it is sane to just have each board have > a full list of its pin names. The format of "gpio-line-names" does > not lend itself to one-off overriding and besides it seems sane to > more fully match schematic names. Also note that the extra > duplication here is only in source code and is unlikely to ever > change (since these boards are shipped). Duplication in the .dtb > files is unavoidable. > - veyron-jaq and veyron-mighty are very closely related and so I have > shared a single list for them both with comments on how they are > different. This is just a typo fix on one of the boards, a possible > missing signal on one of the boards (or perhaps I was never given > the most recent schematics?) and dealing with the fact that one of > the two boards has full sized SD. > > Signed-off-by: Douglas Anderson applied for 5.3 with Matthias Rb. Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel