All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [PATCH v2] kni: fix build for Linux kernel 4.19
Date: Fri, 26 Oct 2018 15:29:00 +0200	[thread overview]
Message-ID: <1748383.aenPN5C8uf@xps> (raw)
In-Reply-To: <20181024111010.15568-1-ferruh.yigit@intel.com>

24/10/2018 13:10, Ferruh Yigit:
> The build error observed with Linux kernel 4.19 when KNI ethtool
> support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y)
> 
> .../build/build/kernel/linux/kni/kni_ethtool.c:193:3:
>    error: ‘struct ethtool_ops’ has no member named ‘get_settings’;
>   .get_settings  = kni_get_settings,
>    ^~~~~~~~~~~~
> 
> .../build/build/kernel/linux/kni/kni_ethtool.c:194:3:
>    error: ‘struct ethtool_ops’ has no member named ‘set_settings’;
>   .set_settings  = kni_set_settings,
>    ^~~~~~~~~~~~
> 
> With kernel 4.19 ethtool_ops `get_settings` & `set_settings` are
> replaced with `get_link_ksettings` & `set_link_ksettings`
> Commit 9b3004953503 ("ethtool: drop get_settings and set_settings callbacks")
> 
> This fix practically removes `get_settings` & `set_settings` support
> for the kernel versions that have the new ethtool_ops without
> implementing the new ones.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

      reply	other threads:[~2018-10-26 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 10:54 [PATCH] kni: fix build for Linux kernel 4.19 Ferruh Yigit
2018-10-24 11:10 ` [PATCH v2] " Ferruh Yigit
2018-10-26 13:29   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1748383.aenPN5C8uf@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.