All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h
Date: Thu, 23 May 2019 15:24:09 -0400	[thread overview]
Message-ID: <174ecff7-d5b1-9264-2a37-ffdda292cc0b@linaro.org> (raw)
In-Reply-To: <20190523110736.GD20973@redhat.com>

On 5/23/19 7:07 AM, Daniel P. Berrangé wrote:
> On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote:
>> Since v4.0, capstone.h has moved to <capstone/capstone.h>.
> NB this was a regression bug in capstone pkg-config file which has been
> fixed upstream
> 
>    https://github.com/aquynh/capstone/pull/1276
> 
> In Fedora we pulled in the fix to our v4.0 builds and I'd suggest
> other distros should do the same
> 

It seems this fix is present in the tagged 4.0 release.

This would have only been present if a distro packaged snapshots.
At least one may have done so, based on

https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg00329.html

but there's no further information to go on.

I've checked Fedora 30 and Debian Buster, which are the only two I could
immediately identify that shipped 4.0.1, as opposed to some 3.x version.  Both
have the pkg-config bug fixed.

Since I cannot test any fixup path, I'm going to drop this patch entirely.


r~


  parent reply	other threads:[~2019-05-23 19:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  2:42 [Qemu-devel] [PATCH 0/3] Update capstone module Richard Henderson
2019-05-23  2:42 ` [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h Richard Henderson
2019-05-23  6:23   ` Alex Bennée
2019-05-23  8:28   ` David Hildenbrand
2019-05-23 11:04   ` Philippe Mathieu-Daudé
2019-05-23 11:07   ` Daniel P. Berrangé
2019-05-23 11:17     ` Philippe Mathieu-Daudé
2019-05-23 11:23       ` Daniel P. Berrangé
2019-05-23 11:32     ` Alex Bennée
2019-05-23 13:05     ` Richard Henderson
2019-05-23 19:24     ` Richard Henderson [this message]
2019-05-23  2:42 ` [Qemu-devel] [PATCH 2/3] capstone: Update to master Richard Henderson
2019-05-23  8:28   ` David Hildenbrand
2019-05-23 11:14   ` Philippe Mathieu-Daudé
2019-05-23  2:42 ` [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x Richard Henderson
2019-05-23  8:27   ` David Hildenbrand
2019-05-23 12:34     ` Richard Henderson
2019-05-23 19:26   ` Richard Henderson
2019-05-23 19:27     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174ecff7-d5b1-9264-2a37-ffdda292cc0b@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.