Re: [PATCH] libsolv: add new recipe

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Alejandro,

On Wed, 09 Dec 2015 14:50:03 Alejandro del Castillo wrote:
> Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>

So perhaps it was discussed elsewhere, but in any case if you want this to be 
added to OE-Core there needs to be something mentioned in the commit message 
about why - what needs this? If nothing, is OE-Core the best place for it?

> ---
>  meta/recipes-extended/libsolv/libsolv_0.6.14.bb | 26
> +++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>  create mode 100644 meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> 
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb new file mode 100644
> index 0000000..14955da
> --- /dev/null
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.14.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "Library for solving packages and reading repositories"
> +HOMEPAGE = "https://github.com/openSUSE/libsolv"
> +BUGTRACKER = "https://github.com/openSUSE/libsolv/issues"
> +SECTION = "devel"
> +LICENSE = "BSD"

LICENSE should be more specific - BSD-2-Clause, BSD-3-Clause, etc.

> +LIC_FILES_CHKSUM =
> "file://LICENSE.BSD;md5=62272bd11c97396d4aaf1c41bc11f7d8" +
>
> +SRC_URI = "https://github.com/openSUSE/libsolv/archive/0.6.14.zip"

Please use ${PV} instead of 0.6.14 here to make future upgrades easier.

> +SRC_URI[md5sum] = "171da68f08f672cacd1930643f8d1b4d"
> +SRC_URI[sha256sum] =
> "0263b11372012be9c83f1c01f7d55ea9464dde58c109f5ae4de1e52870034a45" 
> +
> +PACKAGES =+ "${PN}-tools ${PN}ext ${PN}ext-dbg"

The PACKAGES line should move down before the FILES lines since this has to do 
with packaging.

> +
> +S = "${WORKDIR}/libsolv-0.6.14"

As per SRC_URI, please use ${PV} instead of 0.6.14 here.

> +
> +inherit cmake
> +
> +EXTRA_OECMAKE = "-DLIB=${baselib}"
> +
> +DEPENDS = "expat zlib"
> +
> +FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> +FILES_${PN}-tools = "${bindir}/*"
> +FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
> +FILES_${PN}ext-dbg = "${libdir}/.debug/${PN}ext.so.*"

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre