From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B35C433E0 for ; Fri, 19 Feb 2021 21:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9959D64E77 for ; Fri, 19 Feb 2021 21:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbhBSVPs (ORCPT ); Fri, 19 Feb 2021 16:15:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52778 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbhBSVPp (ORCPT ); Fri, 19 Feb 2021 16:15:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613769258; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=UN2tN/wd0iUKbsiYNyVGTRiheC0AamWBU8SxLUscPxtoATU4NDla2g5ZJt34eHjYM2KgtE 6JcVUw6aUw9GLWAnS+vwBNrJLrMyw+exBR66KH3EslDEhXf7uAnCdXjhroXfs5Ulxadzeg wCwFtwZXXKn63P8aETBcoSH/GNuXdYk= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-Nrl0tmxKOmuafxk7N3UjIg-1; Fri, 19 Feb 2021 16:14:16 -0500 X-MC-Unique: Nrl0tmxKOmuafxk7N3UjIg-1 Received: by mail-qk1-f198.google.com with SMTP id k185so4389797qkb.17 for ; Fri, 19 Feb 2021 13:14:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=X1HSMCIQDnSiByf1blebQoUG596Mj+JpARzh51xYRp4Lp2aQP9YoY06MvS3Rlgwe9e K6t2FHVyMxL6VAPf4cz2vYY1iQgPvafYZlR/gcVmmTcLJBDe57+2j43rsRFMniJn0Zdq c5vl/BOiQDJWTW4E59f0iffe3TF+VyWsQuIoOqeVuXcxRP8ieGSWp2XUMov1MOvkq583 BiahbNRPcyRl5b8aEq9d8mXMpMvHy7DySjTZv8mNIR3A+5YHv0lLIQ7k9HBAf4ZDOBqG VpE4riN5KHkiMsoYQc0FL6v72DOhd4CYgE8iirAPYsdo2JO1aXk0CM6VmSNjf8B98vFB d1wQ== X-Gm-Message-State: AOAM532vRBMB5nm1BoX2ZqRMz4FWz2YooGqpWzS+Cd3IfZBTWF+3bEXz 8aogewZiWPe/7zBb1OEHMHNHMKa/x52UTBMaZr0v/yAV0bN44fvQNtxrUKdJoIrhTRfGfS3R5le qa38j80tf93HDhut6Xrj+vLLv X-Received: by 2002:a37:40d2:: with SMTP id n201mr11379967qka.287.1613769256411; Fri, 19 Feb 2021 13:14:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbodzFZyQN8nD+5Bv9iM7n2ksdk2GmMPOXXn65rtO9bRFBynvgjG56MCH9CX8Bne5kBB5QcQ== X-Received: by 2002:a37:40d2:: with SMTP id n201mr11379951qka.287.1613769256237; Fri, 19 Feb 2021 13:14:16 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id g20sm6253331qtq.35.2021.02.19.13.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:14:15 -0800 (PST) Message-ID: <1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com> Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers From: Lyude Paul Reply-To: lyude@redhat.com To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula Cc: Rodrigo Vivi , David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Lucas De Marchi , open list , dri-devel@lists.freedesktop.org, greg.depoire@gmail.com, Sean Paul , Thomas Zimmermann , Dave Airlie Date: Fri, 19 Feb 2021 16:14:14 -0500 In-Reply-To: References: <20210208233902.1289693-1-lyude@redhat.com> <20210208233902.1289693-11-lyude@redhat.com> <20210211041540.GI82362@intel.com> <355ce12ec69a9b5f20b4a856a40c8abf413be5c0.camel@redhat.com> <87mtw1ai4m.fsf@intel.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-02-18 at 17:31 +0200, Ville Syrjälä wrote: > On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote: > > On Fri, 12 Feb 2021, Lyude Paul wrote: > > > I think it wouldn't be a bad idea to just address this with a followup > > > series > > > instead and use the old DRM_DEBUG_* macros in the mean time. > > > > aux->dev is there, could also use dev_dbg et al. in the mean time. They > > handle NULL dev gracefully too if the driver didn't set that. > > Last I looked aux->dev was random. Some drivers point it at the > connector vs. some at the the pci/platform device. > That's correct-for most SoCs the AUX channel is actually a standalone platform device that isn't associated with the DRM device by default. /But/ I went through the tree yesterday and the day before and did a bunch of cleanup around DP aux registration, added a drm_dev field and hooked it up in every driver with an aux channel, and then converted all of the DP helpers (including dual mode and MST) over to using drm_dbg_*() variants. Once I've gotten through reading all my email for today I'm going to do a quick sanity check on it and then post the series to dri-devel. -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855E0C433DB for ; Fri, 19 Feb 2021 21:14:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C3764EC7 for ; Fri, 19 Feb 2021 21:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C3764EC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F105A6EC11; Fri, 19 Feb 2021 21:14:22 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id F38786E0BA for ; Fri, 19 Feb 2021 21:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613769259; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=OvqnasT2Gid4+Jwx1xeQA0/1NzcTPfs9LRWLS0G9IgBnMkDNgna0UegR4UH28lwTFLA9Pn XdOU9wH+aMgfnGkd/OQGGc2IQNsqyA2/+IHkDu7hJv42tYZDMGG0PfYGyQCkLcu+J8sMaQ 4cPT7WaNP8K1D5JqQmi6or4TMgEJBYY= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-5LQHJGFbPsG5iD_-kDPA6w-1; Fri, 19 Feb 2021 16:14:17 -0500 X-MC-Unique: 5LQHJGFbPsG5iD_-kDPA6w-1 Received: by mail-qv1-f72.google.com with SMTP id d26so3988219qve.7 for ; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=DRHSHNq9IK71y9BoyOZJV7EQ+Ak6oU8RAHg5lAUoI7RlgR3Fa9Smy0ru0mvD64E2Kd zt8g5B1B3VV8koUWYzFG3dPnRSvwMNawvRG7lgUR/CB7+dMQWf9digROQemd6qRqIi96 bmd61q9FyBL831WGCUsYBRTkF1Lb7CTZ0jQjgWgpBcOBixSYsDEbkfnC5AV25cIqtyTF EwTLljfQL3Mwd7h/XoJi6Tm69xjLCmyjE8Ymt9iQRxVTdguZkYsHYEaINDtZ/zo2MUDU JZwVvrR5JSqbPPsDpcY/ULZ7ybNOvprXLnocdacflXaVszliB33mYpdnTHeeFIHi1izF ByBw== X-Gm-Message-State: AOAM532mAXzPn3IIt5oDamBtv8EY1yKib9zLuB8418J2QGefw+pXYJBy 6SPIHqVudUcTPbJF+61CMG7s1zRvifrouMNSi2Ix560FVh5y5y8G5TZv1p166Wuo+JGcrsvK8vQ YhLyEJvQXkuFGJx1CKE2FJ3R7PQ== X-Received: by 2002:a37:40d2:: with SMTP id n201mr11380050qka.287.1613769257483; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbodzFZyQN8nD+5Bv9iM7n2ksdk2GmMPOXXn65rtO9bRFBynvgjG56MCH9CX8Bne5kBB5QcQ== X-Received: by 2002:a37:40d2:: with SMTP id n201mr11379951qka.287.1613769256237; Fri, 19 Feb 2021 13:14:16 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id g20sm6253331qtq.35.2021.02.19.13.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:14:15 -0800 (PST) Message-ID: <1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com> From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula Date: Fri, 19 Feb 2021 16:14:14 -0500 In-Reply-To: References: <20210208233902.1289693-1-lyude@redhat.com> <20210208233902.1289693-11-lyude@redhat.com> <20210211041540.GI82362@intel.com> <355ce12ec69a9b5f20b4a856a40c8abf413be5c0.camel@redhat.com> <87mtw1ai4m.fsf@intel.com> Organization: Red Hat User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Nouveau] [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Lucas De Marchi , open list , dri-devel@lists.freedesktop.org, greg.depoire@gmail.com, Sean Paul , Rodrigo Vivi , Dave Airlie Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" T24gVGh1LCAyMDIxLTAyLTE4IGF0IDE3OjMxICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVGh1LCBGZWIgMTgsIDIwMjEgYXQgMTA6MzU6MDVBTSArMDIwMCwgSmFuaSBOaWt1bGEg d3JvdGU6Cj4gPiBPbiBGcmksIDEyIEZlYiAyMDIxLCBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQu Y29tPiB3cm90ZToKPiA+ID4gSSB0aGluayBpdCB3b3VsZG4ndCBiZSBhIGJhZCBpZGVhIHRvIGp1 c3QgYWRkcmVzcyB0aGlzIHdpdGggYSBmb2xsb3d1cAo+ID4gPiBzZXJpZXMKPiA+ID4gaW5zdGVh ZCBhbmQgdXNlIHRoZSBvbGQgRFJNX0RFQlVHXyogbWFjcm9zIGluIHRoZSBtZWFuIHRpbWUuCj4g PiAKPiA+IGF1eC0+ZGV2IGlzIHRoZXJlLCBjb3VsZCBhbHNvIHVzZSBkZXZfZGJnIGV0IGFsLiBp biB0aGUgbWVhbiB0aW1lLiBUaGV5Cj4gPiBoYW5kbGUgTlVMTCBkZXYgZ3JhY2VmdWxseSB0b28g aWYgdGhlIGRyaXZlciBkaWRuJ3Qgc2V0IHRoYXQuCj4gCj4gTGFzdCBJIGxvb2tlZCBhdXgtPmRl diB3YXMgcmFuZG9tLiBTb21lIGRyaXZlcnMgcG9pbnQgaXQgYXQgdGhlCj4gY29ubmVjdG9yIHZz LiBzb21lIGF0IHRoZSB0aGUgcGNpL3BsYXRmb3JtIGRldmljZS4KPiAKClRoYXQncyBjb3JyZWN0 LWZvciBtb3N0IFNvQ3MgdGhlIEFVWCBjaGFubmVsIGlzIGFjdHVhbGx5IGEgc3RhbmRhbG9uZSBw bGF0Zm9ybQpkZXZpY2UgdGhhdCBpc24ndCBhc3NvY2lhdGVkIHdpdGggdGhlIERSTSBkZXZpY2Ug YnkgZGVmYXVsdC4gL0J1dC8gSSB3ZW50CnRocm91Z2ggdGhlIHRyZWUgeWVzdGVyZGF5IGFuZCB0 aGUgZGF5IGJlZm9yZSBhbmQgZGlkIGEgYnVuY2ggb2YgY2xlYW51cCBhcm91bmQKRFAgYXV4IHJl Z2lzdHJhdGlvbiwgYWRkZWQgYSBkcm1fZGV2IGZpZWxkIGFuZCBob29rZWQgaXQgdXAgaW4gZXZl cnkgZHJpdmVyIHdpdGgKYW4gYXV4IGNoYW5uZWwsIGFuZCB0aGVuIGNvbnZlcnRlZCBhbGwgb2Yg dGhlIERQIGhlbHBlcnMgKGluY2x1ZGluZyBkdWFsIG1vZGUKYW5kIE1TVCkgb3ZlciB0byB1c2lu ZyBkcm1fZGJnXyooKSB2YXJpYW50cy4gT25jZSBJJ3ZlIGdvdHRlbiB0aHJvdWdoIHJlYWRpbmcK YWxsIG15IGVtYWlsIGZvciB0b2RheSBJJ20gZ29pbmcgdG8gZG8gYSBxdWljayBzYW5pdHkgY2hl Y2sgb24gaXQgYW5kIHRoZW4gcG9zdAp0aGUgc2VyaWVzIHRvIGRyaS1kZXZlbC4KCi0tIApTaW5j ZXJlbHksCiAgIEx5dWRlIFBhdWwgKHNoZS9oZXIpCiAgIFNvZnR3YXJlIEVuZ2luZWVyIGF0IFJl ZCBIYXQKICAgCk5vdGU6IEkgZGVhbCB3aXRoIGEgbG90IG9mIGVtYWlscyBhbmQgaGF2ZSBhIGxv dCBvZiBidWdzIG9uIG15IHBsYXRlLiBJZiB5b3UndmUKYXNrZWQgbWUgYSBxdWVzdGlvbiwgYXJl IHdhaXRpbmcgZm9yIGEgcmV2aWV3L21lcmdlIG9uIGEgcGF0Y2gsIGV0Yy4gYW5kIEkKaGF2ZW4n dCByZXNwb25kZWQgaW4gYSB3aGlsZSwgcGxlYXNlIGZlZWwgZnJlZSB0byBzZW5kIG1lIGFub3Ro ZXIgZW1haWwgdG8gY2hlY2sKb24gbXkgc3RhdHVzLiBJIGRvbid0IGJpdGUhCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlz dApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702BAC433DB for ; Fri, 19 Feb 2021 21:14:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A6D06148E for ; Fri, 19 Feb 2021 21:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A6D06148E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FFE06E0BA; Fri, 19 Feb 2021 21:14:22 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38F796E0BE for ; Fri, 19 Feb 2021 21:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613769260; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=MXteFaF2s7iQgmIWGVhfVz4hqI4n036ajg+N9PfYhXh5k9TsIdhp+hIqSp+VF6gIXS2AYE SD5CN7+NKUAZ46PWM3mQdSvmupKl6h5PFw5I45rgBapjv5bgenAKSeapmDy82uFFlYUOlN Ik59T4+MteQ+nVH3iD3Pya9f/dWE4w8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-tAAGLmb-Nw2QeXrzzsL3pQ-1; Fri, 19 Feb 2021 16:14:18 -0500 X-MC-Unique: tAAGLmb-Nw2QeXrzzsL3pQ-1 Received: by mail-qv1-f69.google.com with SMTP id cn7so1485033qvb.18 for ; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=sMVSi+KqUueG72+g29RP50Y59mvZAtbW5PjMavDGubU9SBm1XxANyJeYxR8io6xT43 gfeCcaXTtFSJP0ym4pf6+5d7hLnNcmuA9IlKaBCNvTgdqQQH8N7vQ8WcJ3t8FHVfZfhd 01ksAZWaV4oGuEyJx0aoyVOD8/uz8K9xXf+E57gFW7w8EOIxSBo4fO1xjnetN4tCQWaU IRO8eGV1AUeEelNWltiY3+cvkEbnTUWRMoAGImKtVPve395b3lxOVXeUOPexUGAG0uhJ CoTQskADs0COQHG4SaP1sU9NEnNOux4mu0LfryPk7xaxwACGPEQMEM5Z9EpGjT1LFsYD 3jcg== X-Gm-Message-State: AOAM531gj+xHjF4dHueUHcuR/2BJOoSxH9utbYnCRTo6gZ37ld7yDQCL qku3lFnENReUhTsBuyaDMBXlBHtqD4wIdGX1+eGh6VjDZ95mY2GBCUuFTvRV6D0XUtEh2H8yxEp B2P5UV9ywSW/cbzqmlMzGBzKPxLGk X-Received: by 2002:a37:40d2:: with SMTP id n201mr11380048qka.287.1613769257419; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbodzFZyQN8nD+5Bv9iM7n2ksdk2GmMPOXXn65rtO9bRFBynvgjG56MCH9CX8Bne5kBB5QcQ== X-Received: by 2002:a37:40d2:: with SMTP id n201mr11379951qka.287.1613769256237; Fri, 19 Feb 2021 13:14:16 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id g20sm6253331qtq.35.2021.02.19.13.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:14:15 -0800 (PST) Message-ID: <1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com> Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula Date: Fri, 19 Feb 2021 16:14:14 -0500 In-Reply-To: References: <20210208233902.1289693-1-lyude@redhat.com> <20210208233902.1289693-11-lyude@redhat.com> <20210211041540.GI82362@intel.com> <355ce12ec69a9b5f20b4a856a40c8abf413be5c0.camel@redhat.com> <87mtw1ai4m.fsf@intel.com> Organization: Red Hat User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Lucas De Marchi , open list , dri-devel@lists.freedesktop.org, greg.depoire@gmail.com, Sean Paul , Thomas Zimmermann , Rodrigo Vivi , Dave Airlie Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyMDIxLTAyLTE4IGF0IDE3OjMxICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVGh1LCBGZWIgMTgsIDIwMjEgYXQgMTA6MzU6MDVBTSArMDIwMCwgSmFuaSBOaWt1bGEg d3JvdGU6Cj4gPiBPbiBGcmksIDEyIEZlYiAyMDIxLCBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQu Y29tPiB3cm90ZToKPiA+ID4gSSB0aGluayBpdCB3b3VsZG4ndCBiZSBhIGJhZCBpZGVhIHRvIGp1 c3QgYWRkcmVzcyB0aGlzIHdpdGggYSBmb2xsb3d1cAo+ID4gPiBzZXJpZXMKPiA+ID4gaW5zdGVh ZCBhbmQgdXNlIHRoZSBvbGQgRFJNX0RFQlVHXyogbWFjcm9zIGluIHRoZSBtZWFuIHRpbWUuCj4g PiAKPiA+IGF1eC0+ZGV2IGlzIHRoZXJlLCBjb3VsZCBhbHNvIHVzZSBkZXZfZGJnIGV0IGFsLiBp biB0aGUgbWVhbiB0aW1lLiBUaGV5Cj4gPiBoYW5kbGUgTlVMTCBkZXYgZ3JhY2VmdWxseSB0b28g aWYgdGhlIGRyaXZlciBkaWRuJ3Qgc2V0IHRoYXQuCj4gCj4gTGFzdCBJIGxvb2tlZCBhdXgtPmRl diB3YXMgcmFuZG9tLiBTb21lIGRyaXZlcnMgcG9pbnQgaXQgYXQgdGhlCj4gY29ubmVjdG9yIHZz LiBzb21lIGF0IHRoZSB0aGUgcGNpL3BsYXRmb3JtIGRldmljZS4KPiAKClRoYXQncyBjb3JyZWN0 LWZvciBtb3N0IFNvQ3MgdGhlIEFVWCBjaGFubmVsIGlzIGFjdHVhbGx5IGEgc3RhbmRhbG9uZSBw bGF0Zm9ybQpkZXZpY2UgdGhhdCBpc24ndCBhc3NvY2lhdGVkIHdpdGggdGhlIERSTSBkZXZpY2Ug YnkgZGVmYXVsdC4gL0J1dC8gSSB3ZW50CnRocm91Z2ggdGhlIHRyZWUgeWVzdGVyZGF5IGFuZCB0 aGUgZGF5IGJlZm9yZSBhbmQgZGlkIGEgYnVuY2ggb2YgY2xlYW51cCBhcm91bmQKRFAgYXV4IHJl Z2lzdHJhdGlvbiwgYWRkZWQgYSBkcm1fZGV2IGZpZWxkIGFuZCBob29rZWQgaXQgdXAgaW4gZXZl cnkgZHJpdmVyIHdpdGgKYW4gYXV4IGNoYW5uZWwsIGFuZCB0aGVuIGNvbnZlcnRlZCBhbGwgb2Yg dGhlIERQIGhlbHBlcnMgKGluY2x1ZGluZyBkdWFsIG1vZGUKYW5kIE1TVCkgb3ZlciB0byB1c2lu ZyBkcm1fZGJnXyooKSB2YXJpYW50cy4gT25jZSBJJ3ZlIGdvdHRlbiB0aHJvdWdoIHJlYWRpbmcK YWxsIG15IGVtYWlsIGZvciB0b2RheSBJJ20gZ29pbmcgdG8gZG8gYSBxdWljayBzYW5pdHkgY2hl Y2sgb24gaXQgYW5kIHRoZW4gcG9zdAp0aGUgc2VyaWVzIHRvIGRyaS1kZXZlbC4KCi0tIApTaW5j ZXJlbHksCiAgIEx5dWRlIFBhdWwgKHNoZS9oZXIpCiAgIFNvZnR3YXJlIEVuZ2luZWVyIGF0IFJl ZCBIYXQKICAgCk5vdGU6IEkgZGVhbCB3aXRoIGEgbG90IG9mIGVtYWlscyBhbmQgaGF2ZSBhIGxv dCBvZiBidWdzIG9uIG15IHBsYXRlLiBJZiB5b3UndmUKYXNrZWQgbWUgYSBxdWVzdGlvbiwgYXJl IHdhaXRpbmcgZm9yIGEgcmV2aWV3L21lcmdlIG9uIGEgcGF0Y2gsIGV0Yy4gYW5kIEkKaGF2ZW4n dCByZXNwb25kZWQgaW4gYSB3aGlsZSwgcGxlYXNlIGZlZWwgZnJlZSB0byBzZW5kIG1lIGFub3Ro ZXIgZW1haWwgdG8gY2hlY2sKb24gbXkgc3RhdHVzLiBJIGRvbid0IGJpdGUhCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E70C433E0 for ; Fri, 19 Feb 2021 21:21:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 700BE614A7 for ; Fri, 19 Feb 2021 21:21:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 700BE614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA18C6EC12; Fri, 19 Feb 2021 21:21:07 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D3696EC12 for ; Fri, 19 Feb 2021 21:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613769665; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=LyGX3THI8Syhv2zXBkeDGl8zzOriiLBuzMP9thgugv8xHHTr5zRSZk2xpXPiyhVbTaN6SO aV93b6y8sO++Lf+uxtzytceG27Y2mSUqsMbkoWsz9W5vPsf4RPaTy0YN/020xsMiVebhV6 y0U4Wzex+u8weDA5AgoF1kaJoD6i1Dw= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-LL80LsHOMmamlN4v9-3JeQ-1; Fri, 19 Feb 2021 16:14:17 -0500 X-MC-Unique: LL80LsHOMmamlN4v9-3JeQ-1 Received: by mail-qk1-f200.google.com with SMTP id d66so4425774qke.9 for ; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=C5YOWjYKKEPw7ARjbo3Y9O1C3wAwe1ANRaLyLA4Al9c=; b=Klz1ddm8BaCR6v7P8OrdBEsk0sOOWfZwDUKendRR6mvP2kOlZdVOJjtlOXa5jrRNQf HoZZj3pfhMW5/1F8BoEUuXSYTVUlw5doLDLaNt22KcMb8WUAtfCpFYfg3NMovK8XKKQq g44IXt1p7KpBL5lvlpQ6+sVtzfTku3hKM5ii75P5HvpZlN7nyEk2/okGTMaAE/gyI3UO HiJIqaD79AlNeRwOA7y95gBCFumcOkxjou5jcYzZClksc3LbiYQh4t9j7f2p0e9XUkIr hAZr3IQMuBC5LWAzcrZjyX8j/2YHeInSMsk6QYnenhqemeyrjdMV04t34WZhXAF6+EPF Ri3A== X-Gm-Message-State: AOAM530jy7MlQvGDavc+q6wGmXknkGJ0gIHdORVEkmlSd3lfXX1URWsV Wam3FlPVMoXxL18tZdXDxKqMaWk94gWS7u4MqTw3eGdf4vbfOUqJL9x7QWg/aFSVY4bkQ/EYbVk gn4Se7hAwC0sAqjwkx0fnvzu9vJaq X-Received: by 2002:a37:40d2:: with SMTP id n201mr11380054qka.287.1613769257495; Fri, 19 Feb 2021 13:14:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbodzFZyQN8nD+5Bv9iM7n2ksdk2GmMPOXXn65rtO9bRFBynvgjG56MCH9CX8Bne5kBB5QcQ== X-Received: by 2002:a37:40d2:: with SMTP id n201mr11379951qka.287.1613769256237; Fri, 19 Feb 2021 13:14:16 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id g20sm6253331qtq.35.2021.02.19.13.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:14:15 -0800 (PST) Message-ID: <1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com> From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula Date: Fri, 19 Feb 2021 16:14:14 -0500 In-Reply-To: References: <20210208233902.1289693-1-lyude@redhat.com> <20210208233902.1289693-11-lyude@redhat.com> <20210211041540.GI82362@intel.com> <355ce12ec69a9b5f20b4a856a40c8abf413be5c0.camel@redhat.com> <87mtw1ai4m.fsf@intel.com> Organization: Red Hat User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Lucas De Marchi , open list , dri-devel@lists.freedesktop.org, greg.depoire@gmail.com, Sean Paul , Thomas Zimmermann , Dave Airlie Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVGh1LCAyMDIxLTAyLTE4IGF0IDE3OjMxICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVGh1LCBGZWIgMTgsIDIwMjEgYXQgMTA6MzU6MDVBTSArMDIwMCwgSmFuaSBOaWt1bGEg d3JvdGU6Cj4gPiBPbiBGcmksIDEyIEZlYiAyMDIxLCBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQu Y29tPiB3cm90ZToKPiA+ID4gSSB0aGluayBpdCB3b3VsZG4ndCBiZSBhIGJhZCBpZGVhIHRvIGp1 c3QgYWRkcmVzcyB0aGlzIHdpdGggYSBmb2xsb3d1cAo+ID4gPiBzZXJpZXMKPiA+ID4gaW5zdGVh ZCBhbmQgdXNlIHRoZSBvbGQgRFJNX0RFQlVHXyogbWFjcm9zIGluIHRoZSBtZWFuIHRpbWUuCj4g PiAKPiA+IGF1eC0+ZGV2IGlzIHRoZXJlLCBjb3VsZCBhbHNvIHVzZSBkZXZfZGJnIGV0IGFsLiBp biB0aGUgbWVhbiB0aW1lLiBUaGV5Cj4gPiBoYW5kbGUgTlVMTCBkZXYgZ3JhY2VmdWxseSB0b28g aWYgdGhlIGRyaXZlciBkaWRuJ3Qgc2V0IHRoYXQuCj4gCj4gTGFzdCBJIGxvb2tlZCBhdXgtPmRl diB3YXMgcmFuZG9tLiBTb21lIGRyaXZlcnMgcG9pbnQgaXQgYXQgdGhlCj4gY29ubmVjdG9yIHZz LiBzb21lIGF0IHRoZSB0aGUgcGNpL3BsYXRmb3JtIGRldmljZS4KPiAKClRoYXQncyBjb3JyZWN0 LWZvciBtb3N0IFNvQ3MgdGhlIEFVWCBjaGFubmVsIGlzIGFjdHVhbGx5IGEgc3RhbmRhbG9uZSBw bGF0Zm9ybQpkZXZpY2UgdGhhdCBpc24ndCBhc3NvY2lhdGVkIHdpdGggdGhlIERSTSBkZXZpY2Ug YnkgZGVmYXVsdC4gL0J1dC8gSSB3ZW50CnRocm91Z2ggdGhlIHRyZWUgeWVzdGVyZGF5IGFuZCB0 aGUgZGF5IGJlZm9yZSBhbmQgZGlkIGEgYnVuY2ggb2YgY2xlYW51cCBhcm91bmQKRFAgYXV4IHJl Z2lzdHJhdGlvbiwgYWRkZWQgYSBkcm1fZGV2IGZpZWxkIGFuZCBob29rZWQgaXQgdXAgaW4gZXZl cnkgZHJpdmVyIHdpdGgKYW4gYXV4IGNoYW5uZWwsIGFuZCB0aGVuIGNvbnZlcnRlZCBhbGwgb2Yg dGhlIERQIGhlbHBlcnMgKGluY2x1ZGluZyBkdWFsIG1vZGUKYW5kIE1TVCkgb3ZlciB0byB1c2lu ZyBkcm1fZGJnXyooKSB2YXJpYW50cy4gT25jZSBJJ3ZlIGdvdHRlbiB0aHJvdWdoIHJlYWRpbmcK YWxsIG15IGVtYWlsIGZvciB0b2RheSBJJ20gZ29pbmcgdG8gZG8gYSBxdWljayBzYW5pdHkgY2hl Y2sgb24gaXQgYW5kIHRoZW4gcG9zdAp0aGUgc2VyaWVzIHRvIGRyaS1kZXZlbC4KCi0tIApTaW5j ZXJlbHksCiAgIEx5dWRlIFBhdWwgKHNoZS9oZXIpCiAgIFNvZnR3YXJlIEVuZ2luZWVyIGF0IFJl ZCBIYXQKICAgCk5vdGU6IEkgZGVhbCB3aXRoIGEgbG90IG9mIGVtYWlscyBhbmQgaGF2ZSBhIGxv dCBvZiBidWdzIG9uIG15IHBsYXRlLiBJZiB5b3UndmUKYXNrZWQgbWUgYSBxdWVzdGlvbiwgYXJl IHdhaXRpbmcgZm9yIGEgcmV2aWV3L21lcmdlIG9uIGEgcGF0Y2gsIGV0Yy4gYW5kIEkKaGF2ZW4n dCByZXNwb25kZWQgaW4gYSB3aGlsZSwgcGxlYXNlIGZlZWwgZnJlZSB0byBzZW5kIG1lIGFub3Ro ZXIgZW1haWwgdG8gY2hlY2sKb24gbXkgc3RhdHVzLiBJIGRvbid0IGJpdGUhCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK