From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5FFC48BD3 for ; Wed, 26 Jun 2019 21:10:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C29332085A for ; Wed, 26 Jun 2019 21:10:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="cBwSjqQz"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vr1OmOA9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C29332085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF9EDF04; Wed, 26 Jun 2019 23:10:32 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C3E023DC for ; Wed, 26 Jun 2019 23:10:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 568152215D; Wed, 26 Jun 2019 17:10:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 26 Jun 2019 17:10:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=JxhNwiX0Pfl6iMvSK4enyHGPjGm/PeDRQPBlb7RH7Ko=; b=cBwSjqQzwRQF 3HHKe5PKyLaxfMNVNpRU+CpwFDlaMy4D+FZHSCDf3QaO51SQ2q0gKHOr1KGscJva N8hluRVeP5wh9ug1J4ii5rQ1SLNxd1pu/IDHjvRym4oO8COjAPjDa7MRXKDcPqxn yLR+vx8ZXgbjvmVO8lYxHwLbix9kPZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=JxhNwiX0Pfl6iMvSK4enyHGPjGm/PeDRQPBlb7RH7 Ko=; b=vr1OmOA9Y8+NuJ9Va4SR+onNErVBshfwAjdOLLecbcYcNziU1eKEcE0qm ICBe1VC8cUISoBLVgsMfFQBkZGs3ttyqmGP8o4YbC3p5x+IyZk7Ywl7MRwFDm9UW Yn1pJDbVbNEBZSJKGyt46twMZ+CMyGG0cx/qA87mQfAOPbob6o9PNpnQlPB9X6Tj 3waXZflYsXKIXhFqL0nymoOlUySLN3Ppl+eKFZ/XoVXq5OmwHr7zAh8TxqUud8Ca qvJmJJZ13zZqfYWER4xFntwCHfb80Dd0orwMesxoHDb/nKYPfb/lzeX1u1EvgvrV cOlJgcOkrwSPKNkEv0YaLwlQBQFjQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeigdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 00249380075; Wed, 26 Jun 2019 17:10:28 -0400 (EDT) From: Thomas Monjalon To: Sunil Kumar Kori Cc: dev@dpdk.org, "Ananyev, Konstantin" Date: Wed, 26 Jun 2019 23:10:26 +0200 Message-ID: <1761996.Pc4kcPxEft@xps> In-Reply-To: <2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com> References: <1558005895-30340-1-git-send-email-skori@marvell.com> <1558006933-32247-2-git-send-email-skori@marvell.com> <2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/05/2019 17:18, Ananyev, Konstantin: > > Hi, > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > > during fragmentation and reassemble operation implicitly. > > Because of this, application is forced to use checksum offload > > whether it is supported by platform or not. > > > > Also documentation does not provide any expected value of ol_flags > > in returned mbuf (reassembled or fragmented) so application will never > > come to know that which offloads are enabled. So transmission may be failed > > for the platforms which does not support checksum offload. > > > > Also, IPv6 does not contain any checksum field in header so setting > > mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid. > > > > So removing mentioned flag from the library. > > As there is a change in public API behavior, I think it deserves update in release notes. > Apart from that: > Acked-by: Konstantin Ananyev Is it safe to do this behaviour change? You did not reply about updating the release notes. Why did you drop this patch in v3?