From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD Date: Fri, 22 Sep 2017 08:33:12 +0200 Message-ID: <1763158.2HtYV5lIQ9@xps> References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <25531756.sobbYYJFMz@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, hemant.agrawal@nxp.com To: Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B001A7CCD for ; Fri, 22 Sep 2017 08:33:14 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/09/2017 08:25, Shreyansh Jain: > > It is a very long series introducing 3 different subsystems. > > I think everybody was scared about reviewing it. > > Well, then Ferruh is quite a brave man - I got loads of comments from > him. :D He is :) > > Why you did not split it? > > All the components are serially orders. So, whether I split it into > three separate series, or clearly separated in a single series - it > would be same thing. Isn't it? > > In fact, having three series, one dependent on other, looks more > confusing to me. Personally, it would be difficult for me to review such > patch series(s). > > Still, if you and Ferruh think this split helps, I am OK. But, I don't > want it look as if a new request has been made which cannot be completed > within 17.11 window. I think it is too late now to split it. Let's continue with this big series.