From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C80CC433F5 for ; Wed, 27 Oct 2021 15:09:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A941360F5A for ; Wed, 27 Oct 2021 15:09:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A941360F5A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfkY4-0002JX-De for qemu-devel@archiver.kernel.org; Wed, 27 Oct 2021 11:09:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfjYr-0000tY-0P for qemu-devel@nongnu.org; Wed, 27 Oct 2021 10:05:49 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:39689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfjYn-0005cN-TS for qemu-devel@nongnu.org; Wed, 27 Oct 2021 10:05:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=hEeG/4SRebofxOZFLZqx11DEwYH/8UzBFqHv+vpicAs=; b=DSNCqBKXFz1NxQ4DNdYF050Thf srEH6leWzWWP143P8QrP0bLhnwobKGuL+ALyIgw7Pba7GMybCrdQmo/fWnK7fhRERnCvjmXbQjmvx Tcz+JYyP46oVXdk50S3dkQK4mEiBSMKeJiK3lWfRSuGf79f9eEEDqpEpBwv4hl4ESu6dGcav/Yf/7 EElg52zVVwwUk+P+bM7wdsIVGghp0aGSefwsPNv4Un9Vsmu4lvKEmezoFUnq0IvBRIQHXY76sb6fF jbtKHVRHtZ1akxPyvIosNro2oPvv/yz93O50onoRJoylN2e1B+SrP4PbJFeCB2guC8kEVkaBmYdsl qCG2esD9rv6nY4LMHpoFPbzG+GtRPS8im71YQ4RxsDhsg/gE+AnL6TTDhNZsFNIvhRxi3mn6k9fqN XRLWCFCt/4Plm+WZcFWEZfzCgeR8Bfqdq6qgtOugi03g+Wa45hjPFYrffMW0GiGBSCn4PgbfCtQSn H8L3wQD8O7JdHveVwtAyeu7BiXoPSOSoGW22OIJp3cVNIdYZ1uhADTzL/1tSHKKTH2ApLba6kA2Is dy1uMRcwM4fQ1WIbhdg/gzHFfRB59sP0pSim04XQVAFcTLuw3ygTkJgtpxFkdV000FFg1NRYZvpk4 OGOkYJuCQ8lWArvi3k4WJxO0ZUA4nkDzGe1DunQPs=; From: Christian Schoenebeck To: qemu-devel@nongnu.org, Peter Maydell Cc: Greg Kurz Subject: Re: [PULL 0/8] 9p queue 2021-10-27 Date: Wed, 27 Oct 2021 16:05:39 +0200 Message-ID: <1763549.VT83FdeJ1q@silver> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=5.189.157.229; envelope-from=qemu_oss@crudebyte.com; helo=kylie.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mittwoch, 27. Oktober 2021 15:18:33 CEST Christian Schoenebeck wrote: > The following changes since commit 931ce30859176f0f7daac6bac255dae5eb21284e: > > Merge remote-tracking branch 'remotes/dagrh/tags/pull-virtiofs-20211026' > into staging (2021-10-26 07:38:41 -0700) > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20211027 > > for you to fetch changes up to 7e985780aaab93d2c5be9b62d8d386568dfb071e: > > 9pfs: use P9Array in v9fs_walk() (2021-10-27 14:45:22 +0200) > > ---------------------------------------------------------------- > 9pfs: performance fix and cleanup > > * First patch fixes suboptimal I/O performance on guest due to previously > incorrect block size being transmitted to 9p client. > > * Subsequent patches are cleanup ones intended to reduce code complexity. > > ---------------------------------------------------------------- > Christian Schoenebeck (8): > 9pfs: fix wrong I/O block size in Rgetattr > 9pfs: deduplicate iounit code > 9pfs: simplify blksize_to_iounit() > 9pfs: introduce P9Array > fsdev/p9array.h: check scalar type in P9ARRAY_NEW() > 9pfs: make V9fsString usable via P9Array API > 9pfs: make V9fsPath usable via P9Array API > 9pfs: use P9Array in v9fs_walk() > > fsdev/9p-marshal.c | 2 + > fsdev/9p-marshal.h | 3 + > fsdev/file-op-9p.h | 2 + > fsdev/p9array.h | 160 > +++++++++++++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/9p.c | > 70 +++++++++++++---------- > 5 files changed, 208 insertions(+), 29 deletions(-) > create mode 100644 fsdev/p9array.h Regarding last 5 patches: Daniel raised a concern that not using g_autoptr would deviate from current QEMU coding patterns: https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg00081.html Unfortunately I saw no way to address his concern without adding unnecessary code complexity, so I decided to make this a 9p local type (QArray -> P9Array) for now, which can easily be replaced in future (e.g. when there will be something appropriate on glib side). Best regards, Christian Schoenebeck