All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart
Date: Wed, 10 Oct 2018 11:35:28 +0200	[thread overview]
Message-ID: <1764273.HaIcP3AaDl@xps> (raw)
In-Reply-To: <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com>

10/10/2018 11:05, Andrew Rybchenko:
> On 10/10/18 11:53 AM, Thomas Monjalon wrote:
> > 10/10/2018 09:51, Andrew Rybchenko:
> >> The documentation says MAC addresses array is retained and
> >> it is logical to assume that default MAC address is retained
> >> as well.
> > I'm confused. Default MAC address isn't implied by MAC addresses array?
> 
>  From API point of view it looks as different features (at least for me):
>   - default MAC address is rte_eth_dev_default_mac_addr_set()
>   - MAC addresses array is 
> rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove()
> but it is under one umbrella in NIC features (Unicast MAC filter).

Because default MAC address is mac_addrs[0].

> May be it is my misunderstanding.

More doc is better :)
If it can be thought as different features, let's document it as you do.

  reply	other threads:[~2018-10-10  9:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  7:51 [RFC PATCH 0/3] ethdev: document more retained across restart Andrew Rybchenko
2018-10-10  7:51 ` [RFC PATCH 1/3] ethdev: advertise MTU as retained across device stop/start Andrew Rybchenko
2018-10-10  7:51 ` [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart Andrew Rybchenko
2018-10-10  8:53   ` Thomas Monjalon
2018-10-10  9:05     ` Andrew Rybchenko
2018-10-10  9:35       ` Thomas Monjalon [this message]
2018-10-10  7:51 ` [RFC PATCH 3/3] ethdev: highlight that all-multicast is retained on restart Andrew Rybchenko
2018-12-19  6:22 ` [PATCH v1 0/3] ethdev: document more retained across restart Andrew Rybchenko
2018-12-19  6:22   ` [PATCH v1 1/3] ethdev: advertise MTU as retained across device stop/start Andrew Rybchenko
2018-12-19  6:22   ` [PATCH v1 2/3] ethdev: advertise default MAC as retained on device restart Andrew Rybchenko
2018-12-19  6:23   ` [PATCH v1 3/3] ethdev: highlight that all-multicast is retained on restart Andrew Rybchenko
2019-01-08 14:52   ` [PATCH v1 0/3] ethdev: document more retained across restart Ferruh Yigit
2019-01-09  7:15     ` Andrew Rybchenko
2019-01-10  2:03       ` WILLIAMS, CHARLES J
2019-01-23 12:23         ` Andrew Rybchenko
2019-03-19 13:21   ` Yigit, Ferruh
2019-03-20 14:26     ` Thomas Monjalon
2019-03-20 15:25       ` Ferruh Yigit
2019-03-20 15:32         ` Thomas Monjalon
2019-03-20 16:53           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1764273.HaIcP3AaDl@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.