From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E337C43334 for ; Mon, 6 Jun 2022 13:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238294AbiFFND4 (ORCPT ); Mon, 6 Jun 2022 09:03:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238221AbiFFND1 (ORCPT ); Mon, 6 Jun 2022 09:03:27 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8782036B57 for ; Mon, 6 Jun 2022 06:03:21 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id h19so18771547edj.0 for ; Mon, 06 Jun 2022 06:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9OxRTMOPQcoWtDJkrs/ws60KmhDcry5eiLie80rsiV0=; b=xoxeEc83WssMlenazqEebhL7ESdnn2WRPAKXcSsM1JgAPUMh85wEYEivR3T+D2TVMn vj1fhc9ErRY1A4NtIfYOtMrAB1C5/qlXZ7VyDuT1ERDuuE/Hhzu59eyNRZbQ5QXZaioB F70Uqz3Ej8KAxIrj1b6NXy9gOvDixOvxzV8X2hU1GGg385WBeT5ldpcakEZMrGwOF2Ya JlfE98zdHlnEMyvEJUDWxNrMtR8Wv1uto71QAHC6Zqh33wcrl888XzOy/YtuMZxevRWt OEF81cX4qBKpiEP6mkMx9ixt3bxEMKGWD7je8bHkKHUM3lUTBXGzJLDdUv11zR9MOrDU 0DWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9OxRTMOPQcoWtDJkrs/ws60KmhDcry5eiLie80rsiV0=; b=MemTkFpl6SZtVfeSbGnztqL2VEIzkwImGDMRNK1P+tffCvNt56AjvP/SYZyh+Dxzai KQJu8GEazJqfYEimh+0CTycPyYtP4DG5ARnLf9sND7u5gfdO23k9NYrzr7FGOYx9qqe+ 3rtUmVk8Kx/ldJjf0VkqgGlIENcBUeZyaYVeyDX3XS+zOLYdQzjQPljpFcDducSKxoEP TQDkhOZLIHPl8LbNgaWtEaA/o13aRUpUU7cm9knYuo6qd+H2SWtV7LxkL1WUVOVYRJvZ +d1gmJ4OlP4KaxWPgaBs6S2CNWpRGimUhXhWnLUldr4STHZra5xW6a0Cc/gh4O4dmA4L WeVw== X-Gm-Message-State: AOAM530UULNi9WYaYW4hP2jZtUSSHBH2p2QPN1MlPz5tIoCU+/BrzzEX agQf+3CXG/kpXPMcTXauZAg7/Q== X-Google-Smtp-Source: ABdhPJyIJ0g5jgaKC+UYSyfG1jno/pBLV87i2zkT42j9LvLZ9rhebxwHb50RHOMeIEFNkou/TJJ7zQ== X-Received: by 2002:a05:6402:438a:b0:42e:985:4944 with SMTP id o10-20020a056402438a00b0042e09854944mr25827674edc.283.1654520600280; Mon, 06 Jun 2022 06:03:20 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y24-20020a170906071800b006feed200464sm6356249ejb.131.2022.06.06.06.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 06:03:19 -0700 (PDT) Message-ID: <1764f3ce-608f-e55c-d977-18fb95e4a0fe@linaro.org> Date: Mon, 6 Jun 2022 15:03:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x Content-Language: en-US To: Kavyasree Kotagiri , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, UNGLinuxDriver@microchip.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220603121802.30320-1-kavyasree.kotagiri@microchip.com> <20220603121802.30320-3-kavyasree.kotagiri@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220603121802.30320-3-kavyasree.kotagiri@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2022 14:18, Kavyasree Kotagiri wrote: > LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1 in > flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins > can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on > functions being configured. > > Signed-off-by: Kavyasree Kotagiri > --- > .../bindings/mfd/atmel,flexcom.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > index 221bd840b49e..6050482ad8ef 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > @@ -16,7 +16,9 @@ description: > > properties: > compatible: > - const: atmel,sama5d2-flexcom > + enum: > + - atmel,sama5d2-flexcom > + - microchip,lan966x-flexcom Your new v1 is here worse than old v2, where this was just simple extension of existing enum. Why did you change it? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B3EC43334 for ; Mon, 6 Jun 2022 13:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9zcPQRU5dBhbZiCw67TdCDNyYTsho16HZ1LnEMu2cGs=; b=4CS8UnSpQn9BEK iqxl+losmR3xf3ay72FpqnBScn3ud1Jm06jsmNBWc74pYMAbWaHfVTo4/OhIChvFkeT4n8SC6+W63 FVSf2xKNARrV0GHHSHO5WX4gVSuK4K2a5/fMy2e99UfSUY2U6W9Nenlxx6Co64cboeNOVmFM4yZPJ bsrRuZWZiyrwLrebdeeVFlNxyIiy4ZacrHRS4cu9bFnzq3VfZRQEz3nkxtiHnksw6Pq7YdIlXk8ue kQkUq3NjKmmhaXXFPJ1+BkIkQn04Q1TmMDgEqV9lBVlMePk4t9DS5umS7yMi5CweOhNCPufeS2ulP 7cePo90ISRye0HQNji/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCOE-001GpD-Ud; Mon, 06 Jun 2022 13:03:27 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCOB-001GoO-SQ for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 13:03:25 +0000 Received: by mail-ed1-x534.google.com with SMTP id b8so2054219edj.11 for ; Mon, 06 Jun 2022 06:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9OxRTMOPQcoWtDJkrs/ws60KmhDcry5eiLie80rsiV0=; b=xoxeEc83WssMlenazqEebhL7ESdnn2WRPAKXcSsM1JgAPUMh85wEYEivR3T+D2TVMn vj1fhc9ErRY1A4NtIfYOtMrAB1C5/qlXZ7VyDuT1ERDuuE/Hhzu59eyNRZbQ5QXZaioB F70Uqz3Ej8KAxIrj1b6NXy9gOvDixOvxzV8X2hU1GGg385WBeT5ldpcakEZMrGwOF2Ya JlfE98zdHlnEMyvEJUDWxNrMtR8Wv1uto71QAHC6Zqh33wcrl888XzOy/YtuMZxevRWt OEF81cX4qBKpiEP6mkMx9ixt3bxEMKGWD7je8bHkKHUM3lUTBXGzJLDdUv11zR9MOrDU 0DWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9OxRTMOPQcoWtDJkrs/ws60KmhDcry5eiLie80rsiV0=; b=sdXkjE09ZNp8CzTQ/a1QAh3rIBWyZkgnf0BXljvwj+XMn9Qs20LGeIC6bOj/UtpKHr 6GJBtyPmmm9BSDIDy3MS2KrJyfDlf86rQWUlOMAz3IJgw7oTzLSmAO16qCeFkmNGmuaQ /WwzGrtAuKP3x+ij6164xAUuBo5n7hx9veKYsvyiiUt4Gqpnsp/m76GoYTNMJ6ADJoZx p76xZGhiLMSaYeZbXH4pzm9/dxtJWPuWcD9dRb3inOpWmHPyFqdiOF1WT0U0fJlSezcg vHiCRoFKJJC7qJdEHXh6RaDyol0qUQJKs7+CSGFZZ0DubY55achxnhzp4GIl2/SkJ82J +5ug== X-Gm-Message-State: AOAM532M3iHVnpFEJgTxdwhX3XiLgtWBqnFGWfF4MosB6o9N/OogjoNc g7t/e3hc8SzHLml2HwX38sF3Sw== X-Google-Smtp-Source: ABdhPJyIJ0g5jgaKC+UYSyfG1jno/pBLV87i2zkT42j9LvLZ9rhebxwHb50RHOMeIEFNkou/TJJ7zQ== X-Received: by 2002:a05:6402:438a:b0:42e:985:4944 with SMTP id o10-20020a056402438a00b0042e09854944mr25827674edc.283.1654520600280; Mon, 06 Jun 2022 06:03:20 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y24-20020a170906071800b006feed200464sm6356249ejb.131.2022.06.06.06.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 06:03:19 -0700 (PDT) Message-ID: <1764f3ce-608f-e55c-d977-18fb95e4a0fe@linaro.org> Date: Mon, 6 Jun 2022 15:03:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x Content-Language: en-US To: Kavyasree Kotagiri , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, UNGLinuxDriver@microchip.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220603121802.30320-1-kavyasree.kotagiri@microchip.com> <20220603121802.30320-3-kavyasree.kotagiri@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220603121802.30320-3-kavyasree.kotagiri@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_060323_991945_4BD6B61C X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/06/2022 14:18, Kavyasree Kotagiri wrote: > LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1 in > flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins > can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on > functions being configured. > > Signed-off-by: Kavyasree Kotagiri > --- > .../bindings/mfd/atmel,flexcom.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > index 221bd840b49e..6050482ad8ef 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > @@ -16,7 +16,9 @@ description: > > properties: > compatible: > - const: atmel,sama5d2-flexcom > + enum: > + - atmel,sama5d2-flexcom > + - microchip,lan966x-flexcom Your new v1 is here worse than old v2, where this was just simple extension of existing enum. Why did you change it? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel